From 75aeedde9e54ca8daf153a6824a84e313f0d5c9e Mon Sep 17 00:00:00 2001 From: Jon Saad-Falcon Date: Fri, 27 Feb 2026 20:55:03 +0000 Subject: [PATCH] Fix desktop CI: add icon.ico for Windows, skip macOS codesign, drop macos-13 - Add icons/icon.ico generated from 256x256.png (required for Windows resource file) - Add icon.ico to bundle.icon list in tauri.conf.json - Set APPLE_SIGNING_IDENTITY to '-' when APPLE_CERTIFICATE is not configured, skipping codesign instead of failing with keychain import error - Remove macos-13 matrix entry (Intel runners sunset by GitHub) Co-Authored-By: Claude Opus 4.6 --- .github/workflows/desktop.yml | 6 ++---- desktop/src-tauri/icons/icon.ico | Bin 0 -> 108 bytes desktop/src-tauri/tauri.conf.json | 3 ++- 3 files changed, 4 insertions(+), 5 deletions(-) create mode 100644 desktop/src-tauri/icons/icon.ico diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.yml index 605879b0..693a79ea 100644 --- a/.github/workflows/desktop.yml +++ b/.github/workflows/desktop.yml @@ -81,8 +81,6 @@ jobs: args: '' - platform: macos-latest args: '--target aarch64-apple-darwin' - - platform: macos-13 - args: '--target x86_64-apple-darwin' - platform: windows-latest args: '' @@ -106,7 +104,7 @@ jobs: - name: Install Rust stable uses: dtolnay/rust-toolchain@stable with: - targets: ${{ matrix.platform == 'macos-latest' && 'aarch64-apple-darwin' || matrix.platform == 'macos-13' && 'x86_64-apple-darwin' || '' }} + targets: ${{ matrix.platform == 'macos-latest' && 'aarch64-apple-darwin' || '' }} - name: Rust cache uses: swatinem/rust-cache@v2 @@ -144,7 +142,7 @@ jobs: TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }} APPLE_CERTIFICATE: ${{ secrets.APPLE_CERTIFICATE }} APPLE_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }} - APPLE_SIGNING_IDENTITY: ${{ secrets.APPLE_SIGNING_IDENTITY }} + APPLE_SIGNING_IDENTITY: ${{ secrets.APPLE_CERTIFICATE && secrets.APPLE_SIGNING_IDENTITY || '-' }} APPLE_ID: ${{ secrets.APPLE_ID }} APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }} APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }} diff --git a/desktop/src-tauri/icons/icon.ico b/desktop/src-tauri/icons/icon.ico new file mode 100644 index 0000000000000000000000000000000000000000..d41d586ac2e91e5787e6942bf5f82d68ab80a226 GIT binary patch literal 108 zcmZQzU<5(|0R|vYU1OaJ~3IPr_ASwU(elFz zshE@e<^At}^Bb8CxO6@XWOn0~FikL!WMJ4flj-xC1HXEK3K=|I{an^LB{Ts5*Yz41 literal 0 HcmV?d00001 diff --git a/desktop/src-tauri/tauri.conf.json b/desktop/src-tauri/tauri.conf.json index 9aa2399d..803cc48e 100644 --- a/desktop/src-tauri/tauri.conf.json +++ b/desktop/src-tauri/tauri.conf.json @@ -38,7 +38,8 @@ "icon": [ "icons/32x32.png", "icons/128x128.png", - "icons/128x128@2x.png" + "icons/128x128@2x.png", + "icons/icon.ico" ], "category": "Utility", "shortDescription": "On-device AI assistant with energy monitoring and trace debugging",