Files
OpenJarvis/tests/agents/test_opencode_agent.py
T
krypticmouseandClaude Opus 4.7 00b85b71dd fix(agents): unwrap wrapped engines to derive opencode provider URL (+ clear guard)
The real `jarvis ask --agent opencode` path passes an InstrumentedEngine
(telemetry wrapper) whose underlying engine — and its `_host` — lives at
`_inner`. The base-URL derivation only checked the top object, so it returned
"", no provider was registered, and opencode 500'd on `openjarvis/<model>`.
Direct construction with a raw engine masked this; only the CLI path exposed
it.

- _derive_openai_base_url now unwraps up to 6 wrapper layers
  (`_inner`/`_engine`/`_wrapped`) to find `_host`/`base_url`.
- run() resolves the provider/model spec up front and, when it genuinely
  can't (no base URL + bare model name), returns a clear actionable error
  instead of letting opencode 500.

Tests: wrapper-unwrap derivation + unresolvable-provider guard. 20 passed,
ruff clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-29 01:10:25 +00:00

221 lines
8.5 KiB
Python

"""Tests for OpenCodeAgent (wraps the `opencode` coding agent).
The pure helpers, provider-config wiring, graceful degradation, and response
parsing are tested without the `opencode` binary. SPIKE_RESPONSE is the actual
message shape captured from a live `opencode serve` session.
"""
from __future__ import annotations
from types import SimpleNamespace
from openjarvis.agents.opencode import (
OpenCodeAgent,
_derive_openai_base_url,
_extract_text,
_extract_tool_results,
is_opencode_available,
)
SPIKE_RESPONSE = {
"info": {
"role": "assistant",
"agent": "build",
"modelID": "local-model",
"providerID": "openjarvis",
"finish": "stop",
"tokens": {"input": 0, "output": 0},
"sessionID": "ses_x",
"id": "msg_x",
},
"parts": [
{"type": "step-start"},
{"type": "text", "text": "Hello from the local model. "},
{"type": "step-finish", "reason": "stop"},
],
}
class TestPartParsing:
def test_extract_text_joins_text_parts(self):
assert _extract_text(SPIKE_RESPONSE["parts"]) == "Hello from the local model."
def test_extract_text_ignores_non_text(self):
assert _extract_text([{"type": "step-start"}, {"type": "tool"}]) == ""
def test_extract_tool_results_success(self):
parts = [{"type": "tool", "tool": "bash",
"state": {"status": "completed", "output": "ok"}}]
tr = _extract_tool_results(parts)
assert len(tr) == 1
assert tr[0].tool_name == "bash"
assert tr[0].content == "ok"
assert tr[0].success is True
def test_extract_tool_results_error(self):
parts = [{"type": "tool", "tool": "edit",
"state": {"status": "error", "output": "boom"}}]
assert _extract_tool_results(parts)[0].success is False
class TestDeriveBaseUrl:
def test_from_host_appends_v1(self):
eng = SimpleNamespace(_host="http://localhost:11434")
assert _derive_openai_base_url(eng) == "http://localhost:11434/v1"
def test_host_already_v1(self):
eng = SimpleNamespace(_host="http://x:8000/v1")
assert _derive_openai_base_url(eng) == "http://x:8000/v1"
def test_explicit_base_url_attr(self):
eng = SimpleNamespace(base_url="http://y/v1")
assert _derive_openai_base_url(eng) == "http://y/v1"
def test_unwraps_wrapper_engine(self):
# InstrumentedEngine wraps the real engine at `_inner`; must unwrap.
wrapped = SimpleNamespace(_inner=SimpleNamespace(_host="http://localhost:11434"))
assert _derive_openai_base_url(wrapped) == "http://localhost:11434/v1"
def test_none_when_unknown(self):
assert _derive_openai_base_url(SimpleNamespace()) == ""
class TestAvailability:
def test_true(self, monkeypatch):
monkeypatch.setattr("openjarvis.agents.opencode.shutil.which",
lambda n: "/usr/bin/opencode")
assert is_opencode_available() is True
def test_false(self, monkeypatch):
monkeypatch.setattr("openjarvis.agents.opencode.shutil.which", lambda n: None)
assert is_opencode_available() is False
class TestConfigBuilding:
def test_includes_provider_when_base_url(self, tmp_path):
cfg = OpenCodeAgent(SimpleNamespace(_host="http://localhost:11434"),
"qwen3:8b", workspace=str(tmp_path))._build_config()
prov = cfg["provider"]["openjarvis"]
assert prov["npm"] == "@ai-sdk/openai-compatible"
assert prov["options"]["baseURL"] == "http://localhost:11434/v1"
assert "qwen3:8b" in prov["models"]
def test_no_provider_when_no_base_url(self, tmp_path):
# Pass-through model -> rely on opencode's own provider; no provider block.
cfg = OpenCodeAgent(SimpleNamespace(), "ollama/llama3",
workspace=str(tmp_path))._build_config()
assert "provider" not in cfg
def test_build_mode_permission_allows_edit_and_bash(self, tmp_path):
cfg = OpenCodeAgent(SimpleNamespace(_host="http://h:1"), "m",
workspace=str(tmp_path), agent="build")._build_config()
assert cfg["permission"]["edit"] == "allow"
assert cfg["permission"]["bash"] == "allow"
def test_plan_mode_permission_denies_edit_and_bash(self, tmp_path):
cfg = OpenCodeAgent(SimpleNamespace(_host="http://h:1"), "m",
workspace=str(tmp_path), agent="plan")._build_config()
assert cfg["permission"]["edit"] == "deny"
assert cfg["permission"]["bash"] == "deny"
def test_custom_permission_override(self, tmp_path):
cfg = OpenCodeAgent(SimpleNamespace(_host="http://h:1"), "m",
workspace=str(tmp_path),
permission={"bash": "deny"})._build_config()
assert cfg["permission"] == {"bash": "deny"}
def test_does_not_pollute_workspace(self, tmp_path):
# The config goes to a private OPENCODE_CONFIG file, never the workspace.
OpenCodeAgent(SimpleNamespace(_host="http://h:1"), "m",
workspace=str(tmp_path))._build_config()
assert not (tmp_path / "opencode.json").exists()
class TestRunGracefulDegradation:
def test_missing_binary_returns_error_result(self, monkeypatch, tmp_path):
monkeypatch.setattr("openjarvis.agents.opencode.shutil.which", lambda n: None)
agent = OpenCodeAgent(SimpleNamespace(_host="http://h:1"), "m",
workspace=str(tmp_path),
opencode_bin="/nonexistent/opencode")
res = agent.run("do something")
assert res.metadata.get("error") is True
assert "opencode" in res.content.lower()
def test_unresolvable_provider_fails_clearly(self, tmp_path):
# No derivable base URL + bare model name -> clear error, not a 500
# (and we fail before spawning a server).
agent = OpenCodeAgent(SimpleNamespace(), "qwen3:8b", workspace=str(tmp_path))
res = agent.run("do something")
assert res.metadata.get("error") is True
assert "could not determine" in res.content.lower()
class _FakeResp:
def __init__(self, data):
self._d = data
def raise_for_status(self):
pass
def json(self):
return self._d
# Full-turn message list as returned by GET /session/{id}/message: the tool
# executes in an intermediate assistant message, not the final one (this shape
# was captured from a live opencode session).
TURN_MESSAGES = [
{"info": {"role": "user"}, "parts": [{"type": "text", "text": "..."}]},
{"info": {"role": "assistant"}, "parts": [
{"type": "step-start"},
{"type": "tool", "tool": "write", "callID": "c1",
"state": {"status": "completed", "output": "Wrote file successfully.",
"input": {"filePath": "greet.py", "content": "x"}}},
{"type": "step-finish", "reason": "tool"},
]},
SPIKE_RESPONSE, # final assistant message (text only)
]
class _FakeClient:
def __enter__(self):
return self
def __exit__(self, *a):
return False
def post(self, path, json=None):
if path == "/session":
return _FakeResp({"id": "ses_x"})
if path.endswith("/message"):
_FakeClient.last_body = json
return _FakeResp(SPIKE_RESPONSE)
return _FakeResp({})
def get(self, path, **kw):
return _FakeResp(TURN_MESSAGES)
class TestRunParsing:
def test_run_parses_message_and_tools(self, monkeypatch, tmp_path):
agent = OpenCodeAgent(SimpleNamespace(_host="http://h:1"), "local-model",
workspace=str(tmp_path), agent="build")
monkeypatch.setattr(agent, "_ensure_server", lambda: "http://127.0.0.1:7654")
agent._base = "http://127.0.0.1:7654"
monkeypatch.setattr(agent, "_client", lambda: _FakeClient())
res = agent.run("Write a hello world")
assert res.content == "Hello from the local model."
assert res.metadata["finish"] == "stop"
assert res.metadata["model_id"] == "local-model"
assert res.metadata["agent"] == "build"
# the model was addressed as openjarvis/local-model
assert _FakeClient.last_body["model"] == {
"providerID": "openjarvis", "modelID": "local-model"
}
# tool-results recovered from the intermediate message (not the final one)
assert len(res.tool_results) == 1
assert res.tool_results[0].tool_name == "write"
assert res.tool_results[0].success is True
assert "Wrote file" in res.tool_results[0].content