mirror of
https://github.com/open-jarvis/OpenJarvis.git
synced 2026-07-30 19:02:16 +00:00
Jon Saad-FalconandClaude Opus 4.6
8d538cd1b0
Major changes across parallel sessions: - Add orchestrator SFT & GRPO training subpackage (learning/orchestrator/) with episode types, multi-objective reward, prompt registry, policy model, RL environment, and registered learning policies - Add structured THOUGHT/TOOL/INPUT/FINAL_ANSWER mode to OrchestratorAgent - Add 15 channel backends (Discord, Slack, Telegram, Email, Webhook, IRC, Matrix, Teams, WhatsApp, Signal, Mattermost, BlueBubbles, Feishu, Google Chat, Webchat) with channel tools and config - Add LiteLLM engine backend for unified LLM provider access - Add RLM agent and REPL tool - Remove ToolLearningPolicy — learning taxonomy now only targets Intelligence (LM weights/routing) and Agents (logic/ICL/tool strategies) - Rename SFTPolicy to SFTRouterPolicy (backward-compat alias kept) - Remove OpenClaw agent infrastructure (openclaw*.py, openclaw_bridge.py) - Fix async streaming tests (asyncio.run vs deprecated get_event_loop) - Fix server channel route tests (pytest.importorskip for optional fastapi) - Track uv.lock for reproducibility - Update CLAUDE.md and docs to reflect all changes 1676 tests pass, 37 skipped. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
132 lines
3.8 KiB
Python
132 lines
3.8 KiB
Python
"""Tests for orchestrator SFT trainer."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import MagicMock
|
|
|
|
from openjarvis.learning.orchestrator.sft_trainer import (
|
|
OrchestratorSFTConfig,
|
|
OrchestratorSFTDataset,
|
|
)
|
|
|
|
|
|
class TestOrchestratorSFTConfig:
|
|
def test_defaults(self):
|
|
cfg = OrchestratorSFTConfig()
|
|
assert cfg.model_name == "Qwen/Qwen3-1.7B"
|
|
assert cfg.num_epochs == 3
|
|
assert cfg.batch_size == 8
|
|
assert cfg.learning_rate == 2e-5
|
|
assert cfg.max_seq_length == 4096
|
|
assert cfg.gradient_checkpointing is True
|
|
|
|
def test_custom_values(self):
|
|
cfg = OrchestratorSFTConfig(
|
|
model_name="test-model",
|
|
num_epochs=5,
|
|
batch_size=16,
|
|
)
|
|
assert cfg.model_name == "test-model"
|
|
assert cfg.num_epochs == 5
|
|
assert cfg.batch_size == 16
|
|
|
|
def test_default_tools(self):
|
|
cfg = OrchestratorSFTConfig()
|
|
assert "calculator" in cfg.available_tools
|
|
assert "think" in cfg.available_tools
|
|
|
|
|
|
class TestOrchestratorSFTDataset:
|
|
def test_empty_on_missing_file(self):
|
|
tok = MagicMock()
|
|
ds = OrchestratorSFTDataset(
|
|
trace_path="/nonexistent/path.jsonl",
|
|
tokenizer=tok,
|
|
)
|
|
assert len(ds) == 0
|
|
|
|
def test_format_conversation_fallback(self, tmp_path):
|
|
"""Test manual formatting when tokenizer has no chat template."""
|
|
import json
|
|
|
|
trace_file = tmp_path / "traces.jsonl"
|
|
trace = {
|
|
"conversations": [
|
|
{"role": "user", "content": "Hello"},
|
|
{"role": "assistant", "content": "Hi there"},
|
|
],
|
|
}
|
|
trace_file.write_text(json.dumps(trace) + "\n")
|
|
|
|
tok = MagicMock()
|
|
tok.eos_token = "</s>"
|
|
del tok.apply_chat_template # no chat template
|
|
|
|
ds = OrchestratorSFTDataset(
|
|
trace_path=str(trace_file),
|
|
tokenizer=tok,
|
|
)
|
|
assert len(ds) == 1
|
|
|
|
text = ds._format_conversation(trace["conversations"])
|
|
assert "<|user|>" in text
|
|
assert "Hello" in text
|
|
assert "<|assistant|>" in text
|
|
assert "Hi there" in text
|
|
assert text.endswith("</s>")
|
|
|
|
def test_format_tool_message(self):
|
|
tok = MagicMock()
|
|
tok.eos_token = ""
|
|
del tok.apply_chat_template
|
|
|
|
ds = OrchestratorSFTDataset(
|
|
trace_path="/nonexistent",
|
|
tokenizer=tok,
|
|
)
|
|
convs = [
|
|
{"role": "tool", "name": "calculator", "content": "42"},
|
|
]
|
|
text = ds._format_conversation(convs)
|
|
assert "calculator" in text
|
|
assert "42" in text
|
|
|
|
def test_iter_batches(self, tmp_path):
|
|
import json
|
|
|
|
trace_file = tmp_path / "traces.jsonl"
|
|
traces = []
|
|
for i in range(5):
|
|
traces.append({
|
|
"conversations": [
|
|
{"role": "user", "content": f"q{i}"},
|
|
{"role": "assistant", "content": f"a{i}"},
|
|
]
|
|
})
|
|
trace_file.write_text(
|
|
"\n".join(json.dumps(t) for t in traces) + "\n"
|
|
)
|
|
|
|
tok = MagicMock()
|
|
tok.eos_token = ""
|
|
del tok.apply_chat_template
|
|
tok.return_value = {
|
|
"input_ids": MagicMock(),
|
|
"attention_mask": MagicMock(),
|
|
}
|
|
|
|
ds = OrchestratorSFTDataset(
|
|
trace_path=str(trace_file),
|
|
tokenizer=tok,
|
|
)
|
|
batches = list(ds.iter_batches(batch_size=2))
|
|
assert len(batches) == 3 # 2+2+1
|
|
|
|
|
|
class TestSFTRegistration:
|
|
def test_registered_in_learning_registry(self):
|
|
# Import to trigger registration
|
|
import openjarvis.learning.orchestrator.sft_trainer # noqa: F401
|
|
from openjarvis.core.registry import LearningRegistry
|
|
assert LearningRegistry.contains("orchestrator_sft")
|