Refactored

This commit is contained in:
butomo1989
2017-03-21 13:33:46 +01:00
parent 26b99bd32b
commit f4e16a3cf2
10 changed files with 76 additions and 176 deletions
+7 -20
View File
@@ -1,33 +1,20 @@
"""Unit test for android.py."""
from unittest import TestCase
import mock
from src import android
@mock.patch('src.android.get_available_sdk_packages')
class TestApiLevel(TestCase):
"""Unit test class to test method get_api_level."""
def setUp(self):
self.android_version = '4.2.2'
def test_get_api_level(self, mocked_packages):
mocked_packages.return_value = ['9- SDK Platform Android 4.4.2, API 19, revision 4',
'10- SDK Platform Android 4.3.1, API 18, revision 3',
'11- SDK Platform Android 4.2.2, API 17, revision 3']
api_level = android.get_api_level(self.android_version)
self.assertEqual(api_level, '17')
def test_get_api_level(self):
api_level = android.get_api_level('4.2')
self.assertEqual(api_level, 19)
def test_empty_packages(self, mocked_packages):
mocked_packages.return_value = None
with self.assertRaises(RuntimeError):
android.get_api_level(self.android_version)
def test_index_error(self, mocked_packages):
mocked_packages.return_value = ['9 SDK Platform Android 4.4.2, API 19, revision 4',
'10 SDK Platform Android 4.3.1, API 18, revision 3',
'11 SDK Platform Android 4.2.2, API 17, revision 3']
android.get_api_level(self.android_version)
self.assertRaises(IndexError)
def test_wrong_type(self):
api_level = android.get_api_level(4)
self.assertRaises(TypeError)
self.assertEqual(api_level, None)
@@ -1,28 +0,0 @@
"""Unit test for android.py."""
from unittest import TestCase
import mock
from src import android
class TestAvailablePackages(TestCase):
"""Unit test class to test method get_available_sdk_packages."""
@mock.patch('subprocess.check_output')
def test_valid_output(self, mocked_output):
mocked_output.return_value = 'package 1 \n package 2'
output = android.get_available_sdk_packages()
self.assertEqual(['package 1', 'package 2'], output)
@mock.patch('subprocess.check_output')
def test_without_line_break(self, mocked_output):
mocked_output.return_value = 'package 1, package 2'
output = android.get_available_sdk_packages()
self.assertEqual(['package 1, package 2'], output)
@mock.patch('subprocess.check_output')
def test_empty_string(self, mocked_output):
mocked_output.return_value = None
output = android.get_available_sdk_packages()
self.assertEqual(None, output)
+3 -4
View File
@@ -12,7 +12,6 @@ class TestAvd(TestCase):
"""Unit test class to test method create_avd."""
def setUp(self):
self.android_path = '/root'
self.avd_name = 'test_avd'
self.api_level = 21
@@ -22,7 +21,7 @@ class TestAvd(TestCase):
self.assertFalse(mocked_list_dir.called)
self.assertFalse(mocked_sys_link.called)
self.assertFalse(mocked_suprocess.called)
android.create_avd(self.android_path, 'Nexus 5', self.avd_name, self.api_level)
android.create_avd('Nexus 5', self.avd_name, self.api_level)
self.assertTrue(mocked_list_dir.called)
self.assertTrue(mocked_sys_link.called)
self.assertTrue(mocked_suprocess.called)
@@ -33,7 +32,7 @@ class TestAvd(TestCase):
self.assertFalse(mocked_list_dir.called)
self.assertFalse(mocked_sys_link.called)
self.assertFalse(mocked_suprocess.called)
android.create_avd(self.android_path, 'Samsung Galaxy S6', self.avd_name, self.api_level)
android.create_avd('Samsung Galaxy S6', self.avd_name, self.api_level)
self.assertTrue(mocked_list_dir.called)
self.assertTrue(mocked_sys_link.called)
self.assertTrue(mocked_suprocess.called)
@@ -44,5 +43,5 @@ class TestAvd(TestCase):
self.assertFalse(mocked_list_dir.called)
self.assertFalse(mocked_sys_link.called)
self.assertFalse(mocked_suprocess.called)
android.create_avd(self.android_path, 'emulator', self.avd_name, self.api_level)
android.create_avd('emulator', self.avd_name, self.api_level)
self.assertFalse(mocked_list_dir.called)
+1 -2
View File
@@ -10,7 +10,6 @@ class TestInstallPackage(TestCase):
"""Unit test class to test method install_package."""
def setUp(self):
self.android_path = '/root'
self.emulator_file = 'emulator64-arm'
self.api_level = 21
self.sys_img = 'armeabi-v7a'
@@ -20,6 +19,6 @@ class TestInstallPackage(TestCase):
def test_package_installation(self, mocked_sys_link, mocked_suprocess):
self.assertFalse(mocked_sys_link.called)
self.assertFalse(mocked_suprocess.called)
android.install_package(self.android_path, self.emulator_file, self.api_level, self.sys_img)
android.install_package(self.emulator_file, self.api_level, self.sys_img)
self.assertTrue(mocked_sys_link.called)
self.assertTrue(mocked_suprocess.called)
-27
View File
@@ -1,27 +0,0 @@
"""Unit test for android.py."""
from unittest import TestCase
from src import android
class TestItemPosition(TestCase):
"""Unit test class to test method get_item_position."""
def setUp(self):
self.items = ['android 4.1', 'android 4.2.2', 'android 4.3', 'android 4.4', 'android 4.4.2']
def test_valid_params(self):
keyword = '4.2'
output = android.get_item_position(keyword, self.items)
self.assertEqual(4, output)
def test_invalid_keyword(self):
keyword = 'fake'
output = android.get_item_position(keyword, self.items)
self.assertEqual(0, output)
def test_empty_array(self):
items = []
keyword = '4.2'
output = android.get_item_position(keyword, items)
self.assertEqual(0, output)