From 79d8c6773ec92abd8a9e1c11acf53fa20fdcd8a8 Mon Sep 17 00:00:00 2001 From: Eric Loes <163129+eloe@users.noreply.github.com> Date: Thu, 16 Jul 2026 20:49:28 -0700 Subject: [PATCH] fix(doctor): treat disabled retrieval reflex as intentional (#2459) --- src/commands/doctor.ts | 4 ++-- test/doctor-retrieval-reflex.test.ts | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/commands/doctor.ts b/src/commands/doctor.ts index 134646dc5..7fb94fe6b 100644 --- a/src/commands/doctor.ts +++ b/src/commands/doctor.ts @@ -4096,8 +4096,8 @@ export function buildRetrievalReflexCheck(skillsDir: string | null): Check { if (!enabled) { return { name, - status: 'warn', - message: 'retrieval reflex disabled (config/env) — entity pointer layer off', + status: 'ok', + message: 'retrieval reflex intentionally disabled (config/env) — entity pointer layer off', details: { enabled: false, engine: engineKind, policy_skill_installed: skillInstalled }, }; } diff --git a/test/doctor-retrieval-reflex.test.ts b/test/doctor-retrieval-reflex.test.ts index 6718dea76..2c9be1247 100644 --- a/test/doctor-retrieval-reflex.test.ts +++ b/test/doctor-retrieval-reflex.test.ts @@ -9,12 +9,12 @@ import { buildRetrievalReflexCheck } from '../src/commands/doctor.ts'; import { withEnv } from './helpers/with-env.ts'; describe('buildRetrievalReflexCheck', () => { - test('disabled via env → warn, names the right check', async () => { + test('disabled via env → ok intentional-off, names the right check', async () => { await withEnv({ GBRAIN_RETRIEVAL_REFLEX: 'false' }, async () => { const c = buildRetrievalReflexCheck(null); expect(c.name).toBe('retrieval_reflex_health'); - expect(c.status).toBe('warn'); - expect(c.message).toContain('disabled'); + expect(c.status).toBe('ok'); + expect(c.message).toContain('intentionally disabled'); expect((c.details as any)?.enabled).toBe(false); }); });