mirror of
https://github.com/garrytan/gbrain.git
synced 2026-07-27 22:15:33 +00:00
fix: 8 root-cause fixes from /investigate (v0.14.2) (#259)
* fix: 8 root-cause fixes from /investigate wave
Consolidated bundle of bug fixes from /investigate on the 8 deferred bugs.
Each fix was designed to go at the structural gap, not the symptom. Codex
verified 20 load-bearing claims on the plan; 12 triggered plan revisions.
Bug 2 — GBRAIN_POOL_SIZE env knob + init finally blocks (no auto-detect).
Covers both the singleton pool (db.ts) and instance pool (import.ts:140).
Bug 3 — Centralize migration ledger writes in apply-migrations runner.
Removed appendCompletedMigration from v0_11_0, v0_12_0, v0_12_2,
v0_13_0, v0_13_1. Added 3-partial wedge cap + --force-retry reset.
'complete wins' preserved; no partial can regress a completed migration.
Bug 5 — v0.14.0 migration registered. src/commands/migrations/v0_14_0.ts
ships Phase A (ALTER minion_jobs.max_stalled SET DEFAULT 3) + Phase B
(pending-host-work ping for shell-jobs adoption).
Bug 6/10 — jsonb_agg(DISTINCT ...) in legacy traverseGraph (both engines).
Presentation-level dedup; schema still preserves provenance rows.
Bug 7 — doctor --fast reads DB URL source via getDbUrlSource() in config.ts.
Precise message: 'Skipping DB checks (--fast mode, URL present from env)'
replaces the misleading 'No database configured'.
Bug 8 — max_stalled default bumped 1→3 in schema-embedded.ts, pglite-schema.ts,
schema.sql (new installs). v0_14_0 Phase A ALTER for existing installs.
autopilot-cycle handler yields to event loop between phases so the
worker's lock-renewal timer fires on huge brains. (Deep AbortSignal
threading through runEmbedCore/runExtractCore/runBacklinksCore/performSync
deferred to v0.15 queue polish.)
Bug 9 — Gate sync.last_commit on no-failures across all three sync paths
(incremental, full via runImport, gbrain import git continuity).
recordSyncFailures() helper + ~/.gbrain/sync-failures.jsonl with
dedup key path+commit+error-hash. New flags: --skip-failed (ack) +
--retry-failed (re-attempt). Doctor surfaces unacknowledged failures.
Bug 11 — brain_score breakdown fields on BrainHealth (embed_coverage_score,
link_density_score, timeline_coverage_score, no_orphans_score,
no_dead_links_score); sum equals brain_score by construction.
dead_links now on the type (resolves featuresTeaserForDoctor drift).
orphan_pages kept as 'islanded' (no inbound AND no outbound) and
docs updated to match — explicit semantic instead of doc drift.
New tests: test/traverse-graph-dedup.test.ts, test/sync-failures.test.ts,
test/brain-score-breakdown.test.ts, test/migration-resume.test.ts,
test/migrations-v0_14_0.test.ts. Extended: migrate, doctor, apply-migrations.
All 1696 unit tests pass locally. postgres-jsonb E2E regression unchanged
(none of these touch the JSONB write surface).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* docs: v0.14.2 CHANGELOG + CLAUDE.md; align migration-flow E2E with runner-owned ledger
CHANGELOG: v0.14.2 entry in the standard release-summary format
(two-line headline + lead + numbers table + "what this means" +
"To take advantage of v0.14.2" self-repair block + itemized
changes grouped by reliability / observability / graph correctness /
new migration / tests / deferred-to-v0.15).
CLAUDE.md: new "Key commands added in v0.14.2" section covers
--skip-failed, --retry-failed, --force-retry, GBRAIN_POOL_SIZE env,
and the new doctor checks (sync_failures, brain_score breakdown).
Migration orchestrator docs updated to describe v0_14_0.ts + the
runner-owned ledger contract from Bug 3.
test/e2e/migration-flow.test.ts: three assertions updated to match
the Bug 3 contract — orchestrators no longer append to completed.jsonl
directly, so direct-orchestrator E2E calls leave the ledger empty.
Preferences assertions remain (that's still the orchestrator's side
of the contract). Runner's ledger write is covered by the unit suite
(test/apply-migrations.test.ts + test/migration-resume.test.ts).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.6
parent
ebfbd5e6f7
commit
b5fa3d044a
@@ -201,3 +201,49 @@ describe('migrate: v9 (timeline_dedup_index) regression — must be fast on 1K d
|
||||
expect(helperIdx.length).toBe(0);
|
||||
});
|
||||
});
|
||||
|
||||
// ─────────────────────────────────────────────────────────────────
|
||||
// resolvePoolSize — GBRAIN_POOL_SIZE env override
|
||||
// ─────────────────────────────────────────────────────────────────
|
||||
//
|
||||
// Guards the Bug 2 fix: users on constrained poolers (Supabase port 6543)
|
||||
// must be able to cap the pool size via GBRAIN_POOL_SIZE. The default
|
||||
// (10) is unchanged when the env var is unset.
|
||||
|
||||
describe('resolvePoolSize — env var + explicit override', () => {
|
||||
const { resolvePoolSize } = require('../src/core/db.ts');
|
||||
const original = process.env.GBRAIN_POOL_SIZE;
|
||||
|
||||
afterAll(() => {
|
||||
if (original === undefined) delete process.env.GBRAIN_POOL_SIZE;
|
||||
else process.env.GBRAIN_POOL_SIZE = original;
|
||||
});
|
||||
|
||||
test('returns 10 default when unset and no explicit override', () => {
|
||||
delete process.env.GBRAIN_POOL_SIZE;
|
||||
expect(resolvePoolSize()).toBe(10);
|
||||
});
|
||||
|
||||
test('reads GBRAIN_POOL_SIZE as an integer', () => {
|
||||
process.env.GBRAIN_POOL_SIZE = '2';
|
||||
expect(resolvePoolSize()).toBe(2);
|
||||
process.env.GBRAIN_POOL_SIZE = '5';
|
||||
expect(resolvePoolSize()).toBe(5);
|
||||
});
|
||||
|
||||
test('ignores invalid GBRAIN_POOL_SIZE values', () => {
|
||||
process.env.GBRAIN_POOL_SIZE = 'not-a-number';
|
||||
expect(resolvePoolSize()).toBe(10);
|
||||
process.env.GBRAIN_POOL_SIZE = '0';
|
||||
expect(resolvePoolSize()).toBe(10);
|
||||
process.env.GBRAIN_POOL_SIZE = '-1';
|
||||
expect(resolvePoolSize()).toBe(10);
|
||||
});
|
||||
|
||||
test('explicit argument wins over env + default', () => {
|
||||
delete process.env.GBRAIN_POOL_SIZE;
|
||||
expect(resolvePoolSize(3)).toBe(3);
|
||||
process.env.GBRAIN_POOL_SIZE = '7';
|
||||
expect(resolvePoolSize(3)).toBe(3);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user