mirror of
https://github.com/garrytan/gbrain.git
synced 2026-07-27 22:15:33 +00:00
* feat(chronicle): register event + diary page types (#2390) Life Chronicle Phase A.1. Adds `event` (timeline atom) and `diary` (first-person interiority) as temporal-primitive page types under life/events/ and life/diary/, extractable:false — registered in ALL_PAGE_TYPES, both base schema packs, and the inferType prefix table, with parity fixtures. Also lands the chronicle read result types (ChronicleTimelineRow/ChronicleTimelineOpts/LastSeenResult) consumed by Phase A.2. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(chronicle): event_page_id timeline projection + day/since/last-seen reads (#2390) Life Chronicle Phase A.2. Adds a nullable event_page_id FK to timeline_entries (migration v120; mirrored in schema.sql, pglite-schema, schema-embedded) so a type:event page projects ONE date-index row keyed to its depth page; a partial UNIQUE(event_page_id, date) makes re-extraction with a changed summary an update, not a duplicate. Dual-engine getTimelineForDate / getSince / getLastSeen filter the depth page on deleted_at, hide soft-deleted event projections at READ time (not just doctor), order by event effective_date for intra-day sequence, and honor source scope (sourceIds[] > sourceId). Ops surface as `gbrain day <date> [--week]`, `gbrain since <date> [--kind]`, `gbrain last-seen <entity>`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(chronicle): auto-emit extractor — backstop + chronicle_extract job (#2390) Life Chronicle Phase A.3. A put_page backstop (gated on status==='imported', the auto-link/timeline trust gate, and the default-OFF auto_chronicle flag; diary + event pages never eligible) enqueues a chronicle_extract minion job. The job runs the extractor off the write path: deterministic when/who, an injectable LLM judge (default = chat gateway; no-op when no gateway), an all-or-nothing parse barrier (a malformed proposal writes NOTHING), then content-addressed event pages + a timeline projection via the new dual-engine upsertEventProjection (idempotent — re-run yields one event + one projection). New: src/core/chronicle/{eligibility,config,extract-events,backstop}.ts, engine.upsertEventProjection (both engines), the jobs.ts handler + a 10-min timeout. 14 unit tests (eligibility, idempotency, parse barrier, backstop gating + enqueue) green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(chronicle): quick-capture for diary + manual events (#2390) Life Chronicle Phase A.5. `gbrain capture` now routes the default slug by type (diary → life/diary/, event → life/events/, else inbox/) and accepts --who/--what/--where/--kind/--depth to assemble the `event:` frontmatter block for `--type event`. User-declared event keys win per-key over the flags. Goes through the existing put_page → write-through → embed path. 6 new unit tests; existing capture tests stay green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(chronicle): bi-temporal per-entity ontology on the facts table (#2390) Life Chronicle Phase B.10 — the feature's differentiator. Rather than a parallel store, the open-world per-entity ontology EXTENDS the existing `facts` table (eng-review G1): migration v121 adds dimension/value/value_hash /dim_status columns + a deterministic partial-UNIQUE dedup key + an asof read index. facts already supplies bi-temporal validity, supersession (superseded_by), visibility (remote redaction), confidence, provenance, and embedding — all inherited. Dual-engine methods: mergeOntologyFact (deterministic value_hash dedup → idempotent retry; same value corroborates; a different value forward-closes the prior row's valid_until + superseded_by; a BACKDATED conflicting value is recorded WITHOUT rewriting, surfaced by findOntologyConflicts), getOntology with `--asof` valid-time travel (expired_at + status + validity-window in the predicate so quarantined/superseded never leak), discoverOntologyDimensions, findOntologyConflicts. Novel/LLM-proposed dimensions quarantine; a seed lexicon canonicalizes name drift (job_role → role). 9 unit tests cover the full lifecycle; typecheck pins both engines to the interface. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(chronicle): ontology ops — get/add/dimensions/contradictions (#2390) Life Chronicle Phase B.11. Exposes the bi-temporal ontology over CLI + MCP (contract-first, auto-generated): `gbrain ontology <entity> [--asof]`, `gbrain ontology-add <entity> <dim> <value>`, `gbrain ontology-dimensions` (meta-ontology rollup), `gbrain ontology-contradictions`. All reads route through sourceScopeOpts. Privacy: ontology_get redacts diary-sourced observations (source under life/diary/) for untrusted (remote) callers. 3 op tests (incl. the remote-redaction path); 47 op-registry/tool-def/description tests stay green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(chronicle): agent-context loader — volunteer_chronicle (#2390) Life Chronicle Phase B.12. `loadChronicleContext` hands an agent the recent timeline (last N days) + the validity-resolved current ontology for the entities in play, in one zero-LLM payload, so it orients before acting — the exact gap behind fumbled chronology. Pure composition over getSince + getOntology (no new SQL). Exposed as the `volunteer_chronicle` read op (`gbrain orient [--days] [--entities a,b]`); diary-sourced ontology is redacted for remote callers. 2 loader tests + op-registry green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(chronicle): backfill op — sweep existing meetings into events (#2390) Life Chronicle Phase A.8. `chronicle_backfill` (local-only admin op; `gbrain chronicle-backfill [--since] [--limit] [--dry-run]`) lists existing meeting/conversation/calendar pages (source-scoped via listPages), filters through the chronicle eligibility predicate, and enqueues one chronicle_extract job per eligible page so existing brains populate the timeline. --dry-run counts only; per-page enqueue failures are surfaced in `errors`, never swallowed. 2 op tests (dry-run count + enqueue). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(chronicle): delight — on-this-day + narrative rendering (#2390) Life Chronicle Phase A.6 (delight). Dual-engine getOnThisDay (events from the same month-day in prior years; `gbrain on-this-day [--date]`) reusing the chronicle JOIN shape (deleted-event hiding + source scope). A pure renderTimelineNarrative turns timeline rows into prose; `gbrain day --narrative` returns it alongside the events. 5 tests. (Coverage gap-detection ships with the advisor collectors next.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(chronicle): proactive advisor collector (#2390) Life Chronicle Phase A.7. A brain-state advisor collector surfaces two proactive signals in `gbrain advisor`: unresolved ontology conflicts (warn, → `gbrain ontology-contradictions`) and recent meetings with no timeline coverage (info, → `gbrain chronicle-backfill`). Advisory-only (no dispatch_id); runs over MCP too (not workspace-dependent); tolerant of pre-migration brains. 3 tests + advisor-op-gate green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(chronicle): doctor chronicle_projection_health probe (#2390) Life Chronicle Phase B.13. An always-run doctor check (keyed off the event_page_id schema, NOT a migration verify-hook) counts timeline projections whose event page is soft-deleted — hidden at read time, surfaced here as a cleanup backlog (`gbrain integrity auto`). Tolerant of pre-migration brains. 1 detection test. (auto_chronicle / chronicle.tz flags already work via getConfig defaults; their docs land with document-release at ship.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(chronicle): E1 temporal recall — chronicle-type boost on temporal queries (#2390) Life Chronicle Phase A.4 (E1, ambient temporality). Rather than a separate RRF arm (which needs chunk hydration + risks the fusion path), E1 is a bounded post-fusion boost: applyChronicleTypeBoost lifts `event`/`diary` results on temporal queries, wired INSIDE runPostFusionStages' `recency !== 'off'` branch so it fires ONLY on temporal intent — non-temporal search is bit-for-bit unchanged (proven by 110 passing search-path tests). Bounded ([1.0,1.25]) + floor-gated like the other metadata stages; attribution via `chronicle_boost`. 3 unit tests. (Empirical precision/negative measurement lands with the eval.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(chronicle): feature eval — gbrain eval chronicle (PRIMARY proof) (#2390) Life Chronicle Phase A.9, the North-Star proof. A deterministic, CI-safe eval (brings its own in-memory PGLite; no LLM, no gateway) builds a synthetic month corpus with a known gold chronology + a planted ontology supersession + a planted conflict, then scores the chronicle layer on six gold tasks: day reconstruction (intra-day order), last-seen exact date, ontology supersession, --asof valid-time travel, contradiction surfacing, and source isolation. `gbrain eval chronicle [--json]` exits 0 iff all pass — currently 6/6. The OFF baseline (raw meeting pages) structurally can't order intra-day events or time-travel ontology; the ON path does. (The live-LLM OFF-vs-ON agent arm + LongMemEval temporal slice are a follow-up; this deterministic bar gates CI.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(chronicle): pre-landing review — conflict validity, parse-barrier date, remote conflict redaction (#2390) Three bugs caught by the codex pre-landing review on the diff: 1. findOntologyConflicts ignored valid_until, so a normal forward supersession (founder→advisor from two sources) falsely reported as a live conflict. Now restricted to currently-open rows (valid_until IS NULL) in both engines. 2. The extractor parse barrier accepted any when-string >= 4 chars; a non-date value slipped past, wrote the event page, then threw on the projection's ::date cast (partial write). isValidProposal now requires a real parseable date. 3. The ontology_conflicts op had no remote diary redaction (ontology_get did); remote callers now get diary-sourced values filtered, and conflicts that lose their disagreement after redaction are dropped. Three regression tests added; 29 chronicle tests + eval 6/6 green; typecheck clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * v0.42.56.0 feat(chronicle): Life Chronicle — temporal timeline + diary + bi-temporal ontology (#2390) Bump VERSION + package.json to 0.42.56.0 and add the CHANGELOG entry for the Life Chronicle feature (#2390, closes duplicate #2388). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(chronicle): register #2390 surfaces with the five CI guard suites (#2390) CI caught five guard tests that pin registration invariants my diff tripped: - schema-bootstrap-coverage: the four v122 facts ontology columns join COLUMN_EXEMPTIONS (facts is migration-created; the partial indexes live inside v122; every reader filters dimension IS NOT NULL — same precedent as facts.claim_metric et al). - no-valid-until-write (R8): both engines' mergeOntologyFact forward- supersession is a deliberate, documented valid_until write authority (engine-layer, dimension IS NOT NULL only; the contradiction probe still never mutates). - doctor-categories: chronicle_projection_health registered under BRAIN_CHECK_NAMES (same class as child_table_orphans). - checkTypeProliferation: the test is now threshold-relative (computes declared from the active pack, seeds declared+6) so base-pack growth can't silently move the fixed threshold again. - schema-cli: gbrain-base page-type count 25 → 27 (event + diary), with assertions on both new types. All 41 guard tests green; typecheck clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs: file Life Chronicle follow-up TODOs (v0.42.56.0, #2390) Eight deferred items from the CEO/eng review decisions (auto-emit default-flip fast-follow, live eval arm + LongMemEval slice, passive diary consent, interval-splitting, federation, place-as-entity, meta-ontology dashboard, materialized daily pages), each with decision provenance. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(architecture): KEY_FILES entry for the Life Chronicle module (#2390) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
177 lines
7.1 KiB
TypeScript
177 lines
7.1 KiB
TypeScript
// v0.38 Phase C: gbrain schema CLI smoke tests.
|
|
//
|
|
// Tests the runSchema dispatch + each subcommand's output shape via
|
|
// the public CLI entrypoint. Hermetic — uses Bun's subprocess to run
|
|
// the CLI like a user would.
|
|
|
|
import { describe, expect, test, beforeAll, afterAll, beforeEach, afterEach } from 'bun:test';
|
|
import { spawnSync } from 'node:child_process';
|
|
import { mkdtempSync, rmSync, existsSync, readFileSync, writeFileSync, mkdirSync } from 'node:fs';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
|
|
const REPO_ROOT = join(import.meta.dir, '..');
|
|
|
|
// Default-isolated GBRAIN_HOME for every gbrain() call. Without this,
|
|
// tests that read `~/.gbrain/config.json` inherit the developer's real
|
|
// brain config — and sibling Conductor worktrees writing to the same
|
|
// config (e.g. via `schema use` or `config set` during their own tests)
|
|
// cause flakes (the failing test pre-fix saw `schema_pack: "gbrain-base-v2"`
|
|
// from another worktree, which doesn't exist in the bundle, and got
|
|
// exit 1 instead of the asserted 0).
|
|
let DEFAULT_GBRAIN_HOME: string;
|
|
|
|
beforeAll(() => {
|
|
DEFAULT_GBRAIN_HOME = mkdtempSync(join(tmpdir(), 'gbrain-schema-cli-default-'));
|
|
});
|
|
|
|
afterAll(() => {
|
|
rmSync(DEFAULT_GBRAIN_HOME, { recursive: true, force: true });
|
|
});
|
|
|
|
function gbrain(
|
|
args: string[],
|
|
extraEnv: Record<string, string> = {},
|
|
): { stdout: string; stderr: string; code: number } {
|
|
// bun's spawnSync does NOT inherit env mutations done via process.env = ...,
|
|
// so pass env explicitly. CLAUDE.md flags this pattern as load-bearing for
|
|
// any subprocess test that needs GBRAIN_HOME isolation.
|
|
const env = { ...process.env, GBRAIN_HOME: DEFAULT_GBRAIN_HOME, ...extraEnv };
|
|
const result = spawnSync('bun', ['run', 'src/cli.ts', ...args], {
|
|
cwd: REPO_ROOT,
|
|
encoding: 'utf-8',
|
|
env,
|
|
});
|
|
return {
|
|
stdout: result.stdout ?? '',
|
|
stderr: result.stderr ?? '',
|
|
code: result.status ?? -1,
|
|
};
|
|
}
|
|
|
|
describe('gbrain schema CLI (Phase C)', () => {
|
|
test('schema with no subcommand shows help text', () => {
|
|
// Note: `schema --help` is intercepted by the CLI's parent help system
|
|
// and prints generic help (`gbrain --help` for full command list). The
|
|
// schema-specific help fires when no subcommand is provided.
|
|
const r = gbrain(['schema']);
|
|
expect(r.stdout + r.stderr).toMatch(/schema|active|list|show|validate|use/i);
|
|
});
|
|
|
|
test('schema list shows gbrain-base bundled', () => {
|
|
const r = gbrain(['schema', 'list']);
|
|
expect(r.code).toBe(0);
|
|
expect(r.stdout).toContain('Bundled packs:');
|
|
expect(r.stdout).toContain('gbrain-base');
|
|
});
|
|
|
|
test('schema show gbrain-base prints manifest details', () => {
|
|
const r = gbrain(['schema', 'show', 'gbrain-base']);
|
|
expect(r.code).toBe(0);
|
|
expect(r.stdout).toContain('gbrain-base v1.0.0');
|
|
// v0.41.11.0: page types extended from 22 to 24 by promoting
|
|
// `conversation` and `atom` into gbrain-base.
|
|
// v0.41.23.0: extended to 25 by adding `extract_receipt` for the
|
|
// unified extract receipt-writer surface (D-EXTRACT-19 belt+suspenders).
|
|
// v0.42.56.0 (#2390): extended to 27 by adding the Life Chronicle
|
|
// `event` + `diary` temporal types (life/events/, life/diary/).
|
|
expect(r.stdout).toContain('Page types (27)');
|
|
expect(r.stdout).toContain('event :: temporal');
|
|
expect(r.stdout).toContain('diary :: temporal');
|
|
expect(r.stdout).toContain('Link verbs (12)');
|
|
expect(r.stdout).toContain('Takes kinds: fact, take, bet, hunch');
|
|
expect(r.stdout).toContain('person :: entity');
|
|
expect(r.stdout).toContain('company :: entity');
|
|
});
|
|
|
|
test('schema validate gbrain-base passes', () => {
|
|
const r = gbrain(['schema', 'validate', 'gbrain-base']);
|
|
expect(r.code).toBe(0);
|
|
expect(r.stdout).toContain('✓');
|
|
expect(r.stdout).toContain('valid manifest');
|
|
});
|
|
|
|
test('schema active reports default resolution', () => {
|
|
const r = gbrain(['schema', 'active']);
|
|
expect(r.code).toBe(0);
|
|
expect(r.stdout).toContain('Active pack:');
|
|
expect(r.stdout).toContain('Pack identity:');
|
|
});
|
|
|
|
test('schema show unknown-pack errors with hint', () => {
|
|
const r = gbrain(['schema', 'show', 'nonexistent-pack']);
|
|
expect(r.code).not.toBe(0);
|
|
expect(r.stderr).toContain('Unknown pack');
|
|
expect(r.stderr).toContain('schema list');
|
|
});
|
|
|
|
test('unknown subcommand exits with hint', () => {
|
|
const r = gbrain(['schema', 'frobnicate']);
|
|
expect(r.code).toBe(2);
|
|
expect(r.stderr).toContain('Unknown schema subcommand');
|
|
});
|
|
|
|
test('schema use without arg shows usage hint', () => {
|
|
const r = gbrain(['schema', 'use']);
|
|
expect(r.code).toBe(2);
|
|
expect(r.stderr).toContain('Usage:');
|
|
});
|
|
});
|
|
|
|
describe('gbrain schema use (Phase C, gap-fill T3)', () => {
|
|
let home: string;
|
|
|
|
beforeEach(() => {
|
|
home = mkdtempSync(join(tmpdir(), 'gbrain-schema-use-'));
|
|
});
|
|
|
|
afterEach(() => {
|
|
rmSync(home, { recursive: true, force: true });
|
|
});
|
|
|
|
test('writes schema_pack to ~/.gbrain/config.json on happy path', () => {
|
|
const r = gbrain(['schema', 'use', 'gbrain-base'], { GBRAIN_HOME: home });
|
|
expect(r.code).toBe(0);
|
|
expect(r.stdout).toContain('Active schema pack set to: gbrain-base');
|
|
expect(r.stdout).toContain('schema active');
|
|
const cfgPath = join(home, '.gbrain', 'config.json');
|
|
expect(existsSync(cfgPath)).toBe(true);
|
|
const cfg = JSON.parse(readFileSync(cfgPath, 'utf-8'));
|
|
expect(cfg.schema_pack).toBe('gbrain-base');
|
|
});
|
|
|
|
test('preserves pre-existing config fields when writing schema_pack', () => {
|
|
// Pre-seed a config with engine + a custom key so the merge preserves them.
|
|
mkdirSync(join(home, '.gbrain'), { recursive: true });
|
|
const cfgPath = join(home, '.gbrain', 'config.json');
|
|
writeFileSync(cfgPath, JSON.stringify({ engine: 'pglite', openai_key: 'sk-fake' }, null, 2), 'utf-8');
|
|
const r = gbrain(['schema', 'use', 'gbrain-base'], { GBRAIN_HOME: home });
|
|
expect(r.code).toBe(0);
|
|
const cfg = JSON.parse(readFileSync(cfgPath, 'utf-8'));
|
|
expect(cfg.engine).toBe('pglite');
|
|
expect(cfg.openai_key).toBe('sk-fake');
|
|
expect(cfg.schema_pack).toBe('gbrain-base');
|
|
});
|
|
|
|
test('overwrites prior schema_pack value on re-run', () => {
|
|
// First set a placeholder, then overwrite via the CLI.
|
|
mkdirSync(join(home, '.gbrain'), { recursive: true });
|
|
const cfgPath = join(home, '.gbrain', 'config.json');
|
|
writeFileSync(cfgPath, JSON.stringify({ engine: 'pglite', schema_pack: 'something-else' }, null, 2), 'utf-8');
|
|
const r = gbrain(['schema', 'use', 'gbrain-base'], { GBRAIN_HOME: home });
|
|
expect(r.code).toBe(0);
|
|
const cfg = JSON.parse(readFileSync(cfgPath, 'utf-8'));
|
|
expect(cfg.schema_pack).toBe('gbrain-base');
|
|
});
|
|
|
|
test('unknown pack rejected with exit 1 + paste-ready hint', () => {
|
|
const r = gbrain(['schema', 'use', 'no-such-pack-xyz'], { GBRAIN_HOME: home });
|
|
expect(r.code).toBe(1);
|
|
expect(r.stderr).toContain('Unknown pack');
|
|
expect(r.stderr).toContain('schema list');
|
|
// Importantly: a failed `use` must NOT have written a config.
|
|
const cfgPath = join(home, '.gbrain', 'config.json');
|
|
expect(existsSync(cfgPath)).toBe(false);
|
|
});
|
|
});
|