Files
gbrain/test/engine-find-trajectory.test.ts
a25209bbb2 v0.42.58.0 fix(ai): provider-agnostic gateway — env clobber, base-URL /v1, embedding dims (#1249 #1250 #1292 #2271 #2209) (#2627)
* fix(ai): drop empty-string env values before merge so they can't clobber config keys (#1249)

Claude Code injects ANTHROPIC_API_KEY='' to neuter subprocess LLM calls; an
unconditional process.env spread let that empty string override a valid
config.json key, breaking every gateway op with NO_ANTHROPIC_API_KEY. Filter
'' / undefined before the merge; '0' and 'false' are preserved.

* fix(ai): normalize native provider base URLs + replace embedding guard with a dims-presence check (#1250, #1292)

#1250: createAnthropic/createOpenAI were called with no baseURL, so an
env-injected bare host (e.g. ANTHROPIC_BASE_URL without /v1) 404'd. Add a
shared resolveNativeBaseUrl and pass a normalized baseURL at all anthropic +
openai native sites (google deferred until its suffix is verified).

#1292/D6: the user_provided_model_unset guard was structurally unreachable as
a no-model check (parseModelId throws on a bare provider) and only ever
false-positived for litellm:<model>, silently disabling vector search. Replace
it with a real dims-presence check for user-provided/zero-default recipes and
delete the dead branch in both consumers. Also stop configureGateway from
fabricating a default embedding_dimensions, so 'no dims set' stays honest.

* fix(ai): trust user-declared embedding dims for local recipes + litellm /v1 hint (#2271, #2209)

#2271: a new trust_custom_dims flag adds a passthrough tier so ollama /
llama-server / litellm accept a user-supplied --embedding-dimensions instead of
being hard-rejected. Fail-closed for fixed-dim providers (openai/voyage/
zeroentropy) and excludes openrouter (declares dims_options). Register modern
ollama embed model names.

#2209: litellm setup_hint now states the /v1 path convention and the docs
pointer is corrected to docs/integrations/embedding-providers.md.

* docs+test(ai): KEY_FILES current-state for provider-agnostic gateway + embed-preflight dims-unset test (#1249, #1250, #1292)

* fix(ai): point user_provided_dims_unset remediation at 'gbrain init' (config set rejects it) + coverage

Pre-landing adversarial review (P1): the new dims-unset guard told users to run
'gbrain config set embedding_dimensions <N>', which config.ts hard-rejects (it's a
schema-sizing field). Both consumer messages now point at 'gbrain init
--embedding-dimensions'. Adds: pgvector-cap-still-fires regression for the
trust_custom_dims passthrough, and a configureGateway backfill-invariant test.

* chore: bump version and changelog (v0.42.57.0)

Provider-agnostic plumbing wave: #1249 empty-env clobber, #1250 native baseURL
normalization, #1292 embedding dims-presence guard, #2271 trust_custom_dims
passthrough, #2209 litellm /v1 hint.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs: sync embedding-providers guide for provider-agnostic gateway wave (v0.42.57.0)

Post-ship doc drift fix for the v0.42.57.0 AI-gateway wave:
- LiteLLM section now names the /v1 base-URL convention (#2209).
- Ollama section lists the newly-registered modern embedders qwen3-embed-8b
  + snowflake-arctic-embed-l-v2, and notes dims-trust for local recipes (#2271).
- llama-server section notes gbrain trusts the user-declared dimension (#2271).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs: post-ship doc sweep for v0.42.57.0 provider-agnostic gateway wave

- KEY_FILES.md types.ts entry: document EmbeddingTouchpoint.trust_custom_dims
  (#2271 passthrough tier, runs after dims_options + Matryoshka allowlists)
- ENGINES.md: embedding design-choice note now names the provider-agnostic
  gateway delegation instead of the stale OpenAI-only parenthetical
- embedding-providers.md: drop an exact-duplicate doctor-8c paragraph
- llms-full.txt regenerated (ENGINES.md is inlined in the bundle)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs: apply codex doc-review findings for v0.42.57.0 (base-URL env note, litellm multimodal)

- embedding-providers.md OpenAI section: document OPENAI_BASE_URL /
  ANTHROPIC_BASE_URL bare-host /v1 normalization (#1250 user-facing surface)
- TL;DR table: litellm multimodal is backend-permitting (recipe declares
  supports_multimodal: true, routed via the openai-compat multimodal path),
  not "no"

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test: pin engine-find-trajectory schema to 1536 + stop gateway-state leaks across shard files

CI shard 5 failed 7 findTrajectory tests with 'expected 1280 dimensions, not
1536': engine-find-trajectory hardcodes 1536-d vectors but sizes its schema
from AMBIENT gateway state in beforeAll — which runs before the
legacy-embedding-preload's per-test 1536 restore. A preceding file that ends
with a dimensionless configureGateway (facts-extract-silent-no-op) or a bare
resetGateway poisons the next fresh initSchema down to 1280-d columns. The
new test files in this PR reshuffled shard bin-packing and exposed the trap.

- engine-find-trajectory: pin OpenAI/1536 explicitly before initSchema (the
  pattern bunfig's preload documents) — deterministic regardless of neighbors
- facts-extract-silent-no-op, diagnose-embedding-dims, embed-preflight:
  restore the legacy 1536 pin in afterAll instead of ending reset/dimensionless

Reproduced: synthetic dimensionless-gateway file + old victim = the exact 7
CI failures; with the pin = 0. Verified in-process pair runs both orders.

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-10 10:05:23 +09:00

334 lines
14 KiB
TypeScript

/**
* v0.35.4 — BrainEngine.findTrajectory (T4) + trajectory.ts derived
* metrics tests.
*
* Pins:
* - Chronological ordering by (valid_from ASC, fact_id ASC) — R3.
* - Source scoping (scalar + federated array, D-CDX-6).
* - Visibility filter for remote callers (D-CDX-1) — R6.
* - Metric filter narrows results to a single canonical name.
* - since/until window honored.
* - Regression detection per locked threshold (D-ENG-2).
* - Drift score returns null when <3 embedded points (G3).
* - Empty entity returns {points: [], regressions: [], drift_score: null} (G1).
*/
import { describe, test, expect, beforeAll, afterAll, beforeEach } from 'bun:test';
import { PGLiteEngine } from '../src/core/pglite-engine.ts';
import { configureGateway } from '../src/core/ai/gateway.ts';
import {
detectRegressions,
computeDriftScore,
computeTrajectoryStats,
DEFAULT_REGRESSION_THRESHOLD,
} from '../src/core/trajectory.ts';
import type { TrajectoryPoint } from '../src/core/engine.ts';
let engine: PGLiteEngine;
beforeAll(async () => {
// This file hardcodes 1536-d vectors (vecForMetric). initSchema sizes the
// facts halfvec column from the AMBIENT gateway state, and a beforeAll runs
// before the legacy-embedding-preload's per-test restore — so a preceding
// file in the shard that left the gateway reset or non-1536 would seed a
// 1280-d schema and every insert here would fail with a width mismatch.
// Pin the schema shape explicitly (the pattern bunfig's preload documents).
configureGateway({
embedding_model: 'openai:text-embedding-3-large',
embedding_dimensions: 1536,
env: { ...process.env },
});
engine = new PGLiteEngine();
await engine.connect({});
await engine.initSchema();
});
afterAll(async () => {
await engine.disconnect();
});
beforeEach(async () => {
await engine.executeRaw(`DELETE FROM facts WHERE entity_slug LIKE 'traj-%'`);
await engine.executeRaw(`DELETE FROM sources WHERE id LIKE 'traj-%'`);
});
function vecForMetric(metric: string, offset: number): string {
// Deterministic per-metric/offset embedding: each metric gets a
// unit-vector in a different "direction" of the embedding space, with
// a small perturbation per offset so consecutive same-metric facts
// are very-similar-but-not-identical (drift score lands between 0 and
// some small value).
const a = new Float32Array(1536);
const idx = (metric.charCodeAt(0) + offset) % 1536;
a[idx] = 1.0;
a[(idx + 1) % 1536] = 0.05 * offset; // tiny drift between consecutive
return '[' + Array.from(a).join(',') + ']';
}
async function insertTyped(args: {
source_id?: string;
entity_slug: string;
metric: string;
value: number;
unit?: string;
period?: string;
valid_from: Date;
visibility?: 'private' | 'world';
offset?: number;
text?: string;
}): Promise<number> {
const sid = args.source_id ?? 'default';
await engine.executeRaw(
`INSERT INTO sources (id, name) VALUES ($1, $1) ON CONFLICT DO NOTHING`,
[sid],
);
const r = await engine.executeRaw<{ id: number }>(
`INSERT INTO facts (source_id, entity_slug, fact, kind, source, valid_from,
claim_metric, claim_value, claim_unit, claim_period,
visibility, embedding, embedded_at)
VALUES ($1, $2, $3, 'fact', 'test', $4::timestamptz,
$5, $6, $7, $8,
$9, $10::vector, $4::timestamptz)
RETURNING id`,
[
sid, args.entity_slug, args.text ?? `${args.metric} ${args.value}`,
args.valid_from.toISOString(),
args.metric, args.value, args.unit ?? null, args.period ?? null,
args.visibility ?? 'private',
vecForMetric(args.metric, args.offset ?? 0),
],
);
return r[0].id;
}
describe('findTrajectory — chronological ordering (R3)', () => {
test('returns points in (valid_from ASC, id ASC) order regardless of insert order', async () => {
// Insert out of order. Engine must re-order.
const idJul = await insertTyped({ entity_slug: 'traj-order', metric: 'mrr', value: 150000, valid_from: new Date('2026-07-08') });
const idJan = await insertTyped({ entity_slug: 'traj-order', metric: 'mrr', value: 50000, valid_from: new Date('2026-01-15') });
const idApr = await insertTyped({ entity_slug: 'traj-order', metric: 'mrr', value: 200000, valid_from: new Date('2026-04-12') });
const points = await engine.findTrajectory({ entitySlug: 'traj-order' });
expect(points.map(p => p.fact_id)).toEqual([idJan, idApr, idJul]);
expect(points[0].valid_from.toISOString().slice(0, 10)).toBe('2026-01-15');
expect(points[2].valid_from.toISOString().slice(0, 10)).toBe('2026-07-08');
});
});
describe('findTrajectory — source scoping (D-CDX-6)', () => {
test('scalar sourceId returns only that source', async () => {
await insertTyped({ source_id: 'traj-src-A', entity_slug: 'traj-srcscope', metric: 'mrr', value: 50000, valid_from: new Date('2026-01-15') });
await insertTyped({ source_id: 'traj-src-B', entity_slug: 'traj-srcscope', metric: 'mrr', value: 99999, valid_from: new Date('2026-01-15') });
const pointsA = await engine.findTrajectory({ entitySlug: 'traj-srcscope', sourceId: 'traj-src-A' });
expect(pointsA.length).toBe(1);
expect(pointsA[0].value).toBe(50000);
const pointsB = await engine.findTrajectory({ entitySlug: 'traj-srcscope', sourceId: 'traj-src-B' });
expect(pointsB.length).toBe(1);
expect(pointsB[0].value).toBe(99999);
});
test('federated sourceIds returns union across the array', async () => {
await insertTyped({ source_id: 'traj-src-A', entity_slug: 'traj-fed', metric: 'mrr', value: 50000, valid_from: new Date('2026-01-15') });
await insertTyped({ source_id: 'traj-src-B', entity_slug: 'traj-fed', metric: 'mrr', value: 99999, valid_from: new Date('2026-04-12') });
await insertTyped({ source_id: 'traj-src-C', entity_slug: 'traj-fed', metric: 'mrr', value: 11111, valid_from: new Date('2026-07-08') });
const points = await engine.findTrajectory({
entitySlug: 'traj-fed',
sourceIds: ['traj-src-A', 'traj-src-B'],
});
// Two of three sources visible, in chronological order.
expect(points.length).toBe(2);
expect(points.map(p => p.value)).toEqual([50000, 99999]);
});
});
describe('findTrajectory — visibility filter (D-CDX-1 / R6)', () => {
test('remote=true returns ONLY world-visibility points', async () => {
await insertTyped({ entity_slug: 'traj-vis', metric: 'mrr', value: 50000, visibility: 'private', valid_from: new Date('2026-01-15') });
await insertTyped({ entity_slug: 'traj-vis', metric: 'mrr', value: 99999, visibility: 'world', valid_from: new Date('2026-04-12') });
const trusted = await engine.findTrajectory({ entitySlug: 'traj-vis', remote: false });
expect(trusted.length).toBe(2); // local CLI sees both
const remote = await engine.findTrajectory({ entitySlug: 'traj-vis', remote: true });
expect(remote.length).toBe(1); // OAuth client sees world only
expect(remote[0].value).toBe(99999);
});
test('remote default (undefined) is treated as trusted — sees both', async () => {
await insertTyped({ entity_slug: 'traj-vis-default', metric: 'mrr', value: 50000, visibility: 'private', valid_from: new Date('2026-01-15') });
await insertTyped({ entity_slug: 'traj-vis-default', metric: 'mrr', value: 99999, visibility: 'world', valid_from: new Date('2026-04-12') });
// No `remote` field — engine default must be trusted.
const all = await engine.findTrajectory({ entitySlug: 'traj-vis-default' });
expect(all.length).toBe(2);
});
});
describe('findTrajectory — metric + since + until filters', () => {
test('metric filter narrows to one canonical name', async () => {
await insertTyped({ entity_slug: 'traj-m', metric: 'mrr', value: 50000, valid_from: new Date('2026-01-15') });
await insertTyped({ entity_slug: 'traj-m', metric: 'arr', value: 600000, valid_from: new Date('2026-01-15') });
const mrrOnly = await engine.findTrajectory({ entitySlug: 'traj-m', metric: 'mrr' });
expect(mrrOnly.length).toBe(1);
expect(mrrOnly[0].metric).toBe('mrr');
});
test('since/until window honored', async () => {
await insertTyped({ entity_slug: 'traj-w', metric: 'mrr', value: 50000, valid_from: new Date('2026-01-15') });
await insertTyped({ entity_slug: 'traj-w', metric: 'mrr', value: 99999, valid_from: new Date('2026-04-12') });
await insertTyped({ entity_slug: 'traj-w', metric: 'mrr', value: 11111, valid_from: new Date('2026-07-08') });
const inWindow = await engine.findTrajectory({
entitySlug: 'traj-w',
since: '2026-02-01',
until: '2026-05-01',
});
expect(inWindow.length).toBe(1);
expect(inWindow[0].value).toBe(99999);
});
test('unknown entity returns empty array', async () => {
const empty = await engine.findTrajectory({ entitySlug: 'traj-does-not-exist' });
expect(empty).toEqual([]);
});
});
// ────────────────────────────────────────────────────────────────────────
// trajectory.ts pure-function tests
// ────────────────────────────────────────────────────────────────────────
function makePoint(args: {
id: number;
metric: string;
value: number;
date: string;
emb?: Float32Array | null;
}): TrajectoryPoint {
return {
fact_id: args.id,
valid_from: new Date(args.date),
metric: args.metric,
value: args.value,
unit: 'USD',
period: 'monthly',
event_type: null,
text: `${args.metric} = ${args.value}`,
source_session: null,
source_markdown_slug: null,
embedding: args.emb ?? null,
};
}
describe('detectRegressions (D-ENG-2)', () => {
test('emits a regression when newer value drops by >= threshold', () => {
const points: TrajectoryPoint[] = [
makePoint({ id: 1, metric: 'mrr', value: 200000, date: '2026-04-12' }),
makePoint({ id: 2, metric: 'mrr', value: 150000, date: '2026-07-08' }), // -25%
];
const regs = detectRegressions(points, DEFAULT_REGRESSION_THRESHOLD);
expect(regs.length).toBe(1);
expect(regs[0].metric).toBe('mrr');
expect(regs[0].delta_pct).toBeCloseTo(-0.25, 4);
expect(regs[0].from_date).toBe('2026-04-12');
expect(regs[0].to_date).toBe('2026-07-08');
});
test('skips when drop is below threshold (5% with default 10%)', () => {
const points: TrajectoryPoint[] = [
makePoint({ id: 1, metric: 'mrr', value: 100000, date: '2026-01-15' }),
makePoint({ id: 2, metric: 'mrr', value: 95000, date: '2026-04-12' }), // -5%
];
expect(detectRegressions(points).length).toBe(0);
});
test('multiple metrics tracked independently', () => {
const points: TrajectoryPoint[] = [
makePoint({ id: 1, metric: 'mrr', value: 200000, date: '2026-04-12' }),
makePoint({ id: 2, metric: 'arr', value: 600000, date: '2026-04-12' }),
makePoint({ id: 3, metric: 'mrr', value: 150000, date: '2026-07-08' }), // -25% mrr
makePoint({ id: 4, metric: 'arr', value: 700000, date: '2026-07-08' }), // +16% arr → no regression
];
const regs = detectRegressions(points);
expect(regs.length).toBe(1);
expect(regs[0].metric).toBe('mrr');
});
test('skips points with null value', () => {
const points: TrajectoryPoint[] = [
makePoint({ id: 1, metric: 'mrr', value: 200000, date: '2026-04-12' }),
{ ...makePoint({ id: 2, metric: 'mrr', value: 0, date: '2026-07-08' }), value: null },
];
expect(detectRegressions(points).length).toBe(0);
});
test('skips when older value is 0 (division-by-zero guard)', () => {
const points: TrajectoryPoint[] = [
makePoint({ id: 1, metric: 'mrr', value: 0, date: '2026-04-12' }),
makePoint({ id: 2, metric: 'mrr', value: 1000, date: '2026-07-08' }),
];
expect(detectRegressions(points).length).toBe(0);
});
});
describe('computeDriftScore (D-ENG-3 / G3)', () => {
function unitVec(dim: number, offset: number): Float32Array {
const a = new Float32Array(8);
a[offset % 8] = 1.0;
return a;
}
test('returns null with fewer than 3 embedded points', () => {
const points: TrajectoryPoint[] = [
makePoint({ id: 1, metric: 'mrr', value: 1, date: '2026-01-15', emb: unitVec(8, 0) }),
makePoint({ id: 2, metric: 'mrr', value: 2, date: '2026-04-12', emb: unitVec(8, 1) }),
];
expect(computeDriftScore(points)).toBeNull();
});
test('returns null when no points have embeddings (G3 graceful fallback)', () => {
const points: TrajectoryPoint[] = [
makePoint({ id: 1, metric: 'mrr', value: 1, date: '2026-01-15' }),
makePoint({ id: 2, metric: 'mrr', value: 2, date: '2026-04-12' }),
makePoint({ id: 3, metric: 'mrr', value: 3, date: '2026-07-08' }),
];
expect(computeDriftScore(points)).toBeNull();
});
test('identical consecutive embeddings → drift 0 (cohesive narrative)', () => {
const v = unitVec(8, 0);
const points: TrajectoryPoint[] = [
makePoint({ id: 1, metric: 'mrr', value: 1, date: '2026-01-15', emb: v }),
makePoint({ id: 2, metric: 'mrr', value: 2, date: '2026-04-12', emb: v }),
makePoint({ id: 3, metric: 'mrr', value: 3, date: '2026-07-08', emb: v }),
];
expect(computeDriftScore(points)).toBe(0);
});
test('orthogonal consecutive embeddings → drift 1 (every claim unrelated)', () => {
const points: TrajectoryPoint[] = [
makePoint({ id: 1, metric: 'mrr', value: 1, date: '2026-01-15', emb: unitVec(8, 0) }),
makePoint({ id: 2, metric: 'mrr', value: 2, date: '2026-04-12', emb: unitVec(8, 1) }),
makePoint({ id: 3, metric: 'mrr', value: 3, date: '2026-07-08', emb: unitVec(8, 2) }),
];
expect(computeDriftScore(points)).toBe(1);
});
});
describe('computeTrajectoryStats — composed shape', () => {
test('returns both regressions + drift_score in one call', () => {
const v = new Float32Array(4);
v[0] = 1;
const points: TrajectoryPoint[] = [
makePoint({ id: 1, metric: 'mrr', value: 200000, date: '2026-04-12', emb: v }),
makePoint({ id: 2, metric: 'mrr', value: 150000, date: '2026-07-08', emb: v }),
];
const stats = computeTrajectoryStats(points);
expect(stats.regressions.length).toBe(1);
expect(stats.drift_score).toBeNull(); // <3 embedded
});
});