Files
gbrain/test/cli-help-discoverability.test.ts
MasaandGitHub 9f7244a77f fix(cli): remove sync --install-cron help text — no handler ever existed (#2795) (#2972)
The top-level `gbrain --help` advertised `sync --install-cron` since the
line was first added, but `src/commands/sync.ts` never parsed or handled
the flag — `gbrain sync --install-cron` silently ran an ordinary one-off
sync instead of installing anything, manufacturing false confidence in
the exact durability layer operators reach for it to secure.

git blame shows the line was introduced once (v0.42.29.0 help-text
scaffold) and never touched again — no design intent to recover.
Implementing it would also compete with autopilot, which already owns
this job: `gbrain autopilot --install` runs a self-maintaining daemon
(sync+extract+embed) on a schedule, including a per-source freshness
check that submits `sync` jobs on its own interval. A second, separate
sync-only cron would be a competing scheduler outside the D10
cycle-lock invariant that already keeps autopilot's own targeted-submit
and full-cycle paths from double-processing.

Removed the misleading line and pointed sync's --watch entry at
`autopilot --install`, mirroring the existing `dream` command's
"See also: autopilot --install (continuous daemon)." pattern one
section below. Added regression coverage to
test/cli-help-discoverability.test.ts asserting the help text no
longer promises install-cron and does point at autopilot.
2026-07-20 14:27:50 -07:00

143 lines
6.0 KiB
TypeScript

/**
* v0.39.3.0 WARN-5 + WARN-6 — CLI help discoverability.
*
* WARN-5: `gbrain capture --help` was showing only the generic
* `Usage: gbrain capture` line because `capture` was missing from
* CLI_ONLY_SELF_HELP (src/cli.ts:34-53). Fix added it to the set AND
* added a pre-engine-bind `--help` short-circuit at handleCliOnly so
* the HELP constant is reachable on a fresh tmpdir with no config.
*
* WARN-6: `capture`, `brainstorm`, `lsd` were missing from the main
* `gbrain --help` text. Added a BRAIN section to printHelp.
*
* These tests spawn `bun run src/cli.ts` as a subprocess so they
* exercise the real dispatcher flow end-to-end (no mocking of
* cli.ts internals).
*/
import { describe, test, expect } from 'bun:test';
import { spawnSync } from 'node:child_process';
function runCli(args: string[]): { stdout: string; stderr: string; status: number } {
const result = spawnSync('bun', ['run', 'src/cli.ts', ...args], {
cwd: process.cwd(),
encoding: 'utf8',
env: { ...process.env, GBRAIN_HOME: '/tmp/gbrain-test-help-nonexistent' },
});
return {
stdout: result.stdout ?? '',
stderr: result.stderr ?? '',
status: result.status ?? -1,
};
}
describe('WARN-5 — `gbrain capture --help` reaches the detailed HELP constant', () => {
test('output contains every documented flag', () => {
const { stdout, status } = runCli(['capture', '--help']);
expect(status).toBe(0);
expect(stdout).toContain('--slug');
expect(stdout).toContain('--type');
expect(stdout).toContain('--file');
expect(stdout).toContain('--stdin');
expect(stdout).toContain('--source');
expect(stdout).toContain('--quiet');
expect(stdout).toContain('--json');
});
test('output is NOT the generic short-circuit fallback', () => {
const { stdout } = runCli(['capture', '--help']);
// Pre-fix output was: "Usage: gbrain capture\n\ngbrain capture - run gbrain --help ..."
// Post-fix HELP is much longer and includes Examples.
expect(stdout).toContain('Examples:');
expect(stdout.split('\n').length).toBeGreaterThan(10);
expect(stdout).not.toMatch(/^Usage: gbrain capture\s*$/m);
});
test('-h short flag also works', () => {
const { stdout, status } = runCli(['capture', '-h']);
expect(status).toBe(0);
expect(stdout).toContain('--file PATH');
});
});
describe('WARN-6 — main `gbrain --help` lists capture/brainstorm/lsd', () => {
test('output mentions all three commands by name', () => {
const { stdout, status } = runCli(['--help']);
expect(status).toBe(0);
// Must appear as command names (not just words in prose somewhere)
expect(stdout).toMatch(/^\s*capture\s/m);
expect(stdout).toMatch(/^\s*brainstorm\s/m);
expect(stdout).toMatch(/^\s*lsd\s/m);
});
test('BRAIN section heading is present and groups the three commands', () => {
const { stdout } = runCli(['--help']);
expect(stdout).toContain('BRAIN');
// The 3 commands should appear AFTER the BRAIN heading in textual order.
const brainIdx = stdout.indexOf('BRAIN');
expect(brainIdx).toBeGreaterThan(-1);
expect(stdout.indexOf('capture', brainIdx)).toBeGreaterThan(brainIdx);
expect(stdout.indexOf('brainstorm', brainIdx)).toBeGreaterThan(brainIdx);
expect(stdout.indexOf('lsd', brainIdx)).toBeGreaterThan(brainIdx);
});
test('regression: existing top-level commands still listed', () => {
// Snapshot guard against accidentally deleting other groups when we
// added the BRAIN section. Spot-check a few commands from different
// groups (SETUP, PAGES, SEARCH, IMPORT/EXPORT).
const { stdout } = runCli(['--help']);
expect(stdout).toContain('init');
expect(stdout).toContain('doctor');
expect(stdout).toContain('get');
expect(stdout).toContain('search');
expect(stdout).toContain('query');
expect(stdout).toContain('import');
expect(stdout).toContain('export');
expect(stdout).toContain('files');
expect(stdout).toContain('embed');
});
});
describe('#2795 — `sync --install-cron` help line no longer promises an unbuilt feature', () => {
test('main `gbrain --help` does not advertise install-cron', () => {
// Pre-fix: `sync --install-cron Install persistent sync daemon` was
// listed in the top-level help with no flag parsing or handler behind
// it anywhere in src/commands/sync.ts — `gbrain sync --install-cron`
// silently ran an ordinary sync instead of installing anything.
const { stdout, status } = runCli(['--help']);
expect(status).toBe(0);
expect(stdout).not.toContain('install-cron');
expect(stdout).not.toContain('Install persistent sync daemon');
});
test('main `gbrain --help` points sync users at the real continuous-daemon command', () => {
const { stdout } = runCli(['--help']);
// autopilot --install already runs sync+extract+embed on a schedule
// (docs/architecture/KEY_FILES.md); point discoverability there instead
// of promising a separate sync-only cron installer that never existed.
expect(stdout).toMatch(/sync --watch \[--interval N\][^\n]*\n\s*See also: autopilot --install/);
});
test('`gbrain sync --help` never listed install-cron either', () => {
const { stdout, status } = runCli(['sync', '--help']);
expect(status).toBe(0);
expect(stdout).not.toContain('install-cron');
});
});
describe('#1175 — main `gbrain --help` SOURCES block matches the real subcommand set', () => {
test('archive and its lifecycle siblings are listed', () => {
const { stdout, status } = runCli(['--help']);
expect(status).toBe(0);
// Pre-fix the SOURCES block listed only list/add/remove; the soft-delete
// alternative that `sources remove` itself recommends was undiscoverable.
expect(stdout).toMatch(/^\s*sources archive <id>\s/m);
expect(stdout).toMatch(/^\s*sources restore <id>\s/m);
expect(stdout).toMatch(/^\s*sources archived\s/m);
expect(stdout).toMatch(/^\s*sources purge/m);
expect(stdout).toMatch(/^\s*sources status\s/m);
// Pointer at the full per-subcommand help for the long tail.
expect(stdout).toMatch(/^\s*sources --help\s/m);
});
});