mirror of
https://github.com/garrytan/gbrain.git
synced 2026-07-27 22:15:33 +00:00
The signal-handler test asserted an absolute liveReporters===0 on a module-global set, so any other test file in the shard holding a live reporter flaked it — it red-flagged ~12 unrelated PR runs and one master push in two days, purely as a function of shard composition. The delta form pins the same claim (50 reporter lifecycles leak nothing). The 15-minute shard timeout cancelled 13 fully-passing runs under parallel PR load (PGLite WASM cold-starts stretch shards); the test-status gate then reported the cancellations as failures. Co-authored-by: Garry Tan <garrytan@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
270 lines
10 KiB
TypeScript
270 lines
10 KiB
TypeScript
import { describe, test, expect } from 'bun:test';
|
|
import { PassThrough } from 'node:stream';
|
|
import { createProgress, startHeartbeat, __liveReporterCountForTest, __signalHandlerInstalledForTest } from '../src/core/progress.ts';
|
|
|
|
/** Collect everything a reporter writes into a string. */
|
|
function sink(isTTY = false): { stream: PassThrough & { isTTY?: boolean }; read: () => string } {
|
|
const s = new PassThrough() as PassThrough & { isTTY?: boolean };
|
|
s.isTTY = isTTY;
|
|
const chunks: string[] = [];
|
|
s.on('data', (c) => chunks.push(c.toString('utf8')));
|
|
return { stream: s, read: () => chunks.join('') };
|
|
}
|
|
|
|
function parseJsonl(raw: string): Record<string, unknown>[] {
|
|
return raw
|
|
.split('\n')
|
|
.filter((l) => l.length > 0)
|
|
.map((l) => JSON.parse(l));
|
|
}
|
|
|
|
describe('progress reporter', () => {
|
|
test('auto mode: non-TTY → human-plain (NOT JSON)', () => {
|
|
const { stream, read } = sink(false);
|
|
const p = createProgress({ mode: 'auto', stream, minIntervalMs: 0, minItems: 1 });
|
|
p.start('scan', 3);
|
|
p.tick();
|
|
p.tick();
|
|
p.tick();
|
|
p.finish();
|
|
const out = read();
|
|
// plain lines, no JSON
|
|
expect(out).not.toContain('"event"');
|
|
expect(out).toContain('[scan]');
|
|
expect(out).toContain('1/3');
|
|
expect(out).toContain('3/3');
|
|
});
|
|
|
|
test('auto mode: TTY → human-\\r (carriage return, no newline between ticks)', () => {
|
|
const { stream, read } = sink(true);
|
|
const p = createProgress({ mode: 'auto', stream, minIntervalMs: 0, minItems: 1 });
|
|
p.start('scan', 2);
|
|
p.tick();
|
|
p.tick();
|
|
p.finish();
|
|
const out = read();
|
|
// TTY path uses \r + clear-line escape; final newline on finish.
|
|
expect(out).toContain('\r');
|
|
expect(out).toContain('[scan]');
|
|
});
|
|
|
|
test('json mode emits one JSON object per line with schema', () => {
|
|
const { stream, read } = sink(false);
|
|
const p = createProgress({ mode: 'json', stream, minIntervalMs: 0, minItems: 1 });
|
|
p.start('doctor.jsonb_integrity', 4);
|
|
p.tick(1, 'pages.frontmatter');
|
|
p.tick(1, 'raw_data.data');
|
|
p.finish();
|
|
const events = parseJsonl(read());
|
|
expect(events.length).toBeGreaterThanOrEqual(3);
|
|
expect(events[0]).toMatchObject({ event: 'start', phase: 'doctor.jsonb_integrity', total: 4 });
|
|
expect(events[0].ts).toMatch(/^\d{4}-\d{2}-\d{2}T/);
|
|
expect(events[1]).toMatchObject({ event: 'tick', phase: 'doctor.jsonb_integrity', done: 1, total: 4 });
|
|
expect(events[1].pct).toBe(25);
|
|
expect(typeof events[1].elapsed_ms).toBe('number');
|
|
expect(events[events.length - 1]).toMatchObject({ event: 'finish', phase: 'doctor.jsonb_integrity' });
|
|
});
|
|
|
|
test('quiet mode emits nothing', () => {
|
|
const { stream, read } = sink(false);
|
|
const p = createProgress({ mode: 'quiet', stream });
|
|
p.start('scan', 10);
|
|
p.tick();
|
|
p.heartbeat('hello');
|
|
p.finish();
|
|
expect(read()).toBe('');
|
|
});
|
|
|
|
test('tick() time-gated: calls inside minIntervalMs collapse to one emit', () => {
|
|
const { stream, read } = sink(false);
|
|
const p = createProgress({ mode: 'json', stream, minIntervalMs: 5000, minItems: 999999 });
|
|
p.start('scan', 100);
|
|
// Rapid ticks — should not emit intermediate 'tick' events (only the final one if eq total).
|
|
for (let i = 0; i < 10; i++) p.tick();
|
|
const events = parseJsonl(read());
|
|
const ticks = events.filter((e) => e.event === 'tick');
|
|
// 10 ticks, total=100, final-tick-on-complete heuristic doesn't apply (done < total).
|
|
// Time-gated + item-gated should suppress all.
|
|
expect(ticks.length).toBe(0);
|
|
p.finish();
|
|
});
|
|
|
|
test('tick() item-gated: minItems threshold emits after N items', () => {
|
|
const { stream, read } = sink(false);
|
|
const p = createProgress({ mode: 'json', stream, minIntervalMs: 999999, minItems: 50 });
|
|
p.start('scan', 1000);
|
|
for (let i = 0; i < 100; i++) p.tick();
|
|
p.finish();
|
|
const events = parseJsonl(read());
|
|
const ticks = events.filter((e) => e.event === 'tick');
|
|
// 100 ticks with minItems=50 ⇒ expect ~2 emits
|
|
expect(ticks.length).toBeGreaterThanOrEqual(1);
|
|
expect(ticks.length).toBeLessThanOrEqual(3);
|
|
});
|
|
|
|
test('final tick emits regardless of gating when done === total', () => {
|
|
const { stream, read } = sink(false);
|
|
const p = createProgress({ mode: 'json', stream, minIntervalMs: 999999, minItems: 999999 });
|
|
p.start('scan', 3);
|
|
p.tick();
|
|
p.tick();
|
|
p.tick(); // this one hits done===total, must emit
|
|
p.finish();
|
|
const events = parseJsonl(read());
|
|
const ticks = events.filter((e) => e.event === 'tick');
|
|
expect(ticks.length).toBe(1);
|
|
expect(ticks[0]).toMatchObject({ done: 3, total: 3 });
|
|
});
|
|
|
|
test('start(phase) with no total → ticks omit pct/eta_ms', () => {
|
|
const { stream, read } = sink(false);
|
|
const p = createProgress({ mode: 'json', stream, minIntervalMs: 0, minItems: 1 });
|
|
p.start('unknown_size_scan'); // no total
|
|
p.tick();
|
|
p.finish();
|
|
const events = parseJsonl(read());
|
|
const tick = events.find((e) => e.event === 'tick')!;
|
|
expect(tick).toBeDefined();
|
|
expect(tick.total).toBeUndefined();
|
|
expect(tick.pct).toBeUndefined();
|
|
expect(tick.eta_ms).toBeUndefined();
|
|
expect(tick.done).toBe(1);
|
|
});
|
|
|
|
test('heartbeat() emits without bumping done', () => {
|
|
const { stream, read } = sink(false);
|
|
const p = createProgress({ mode: 'json', stream, minIntervalMs: 0, minItems: 1 });
|
|
p.start('slow_query');
|
|
p.heartbeat('still scanning…');
|
|
p.heartbeat('still scanning…');
|
|
p.finish();
|
|
const events = parseJsonl(read());
|
|
const hb = events.filter((e) => e.event === 'heartbeat');
|
|
expect(hb.length).toBe(2);
|
|
expect(hb[0]).toMatchObject({ phase: 'slow_query', note: 'still scanning…' });
|
|
// No 'done' field on heartbeat.
|
|
expect(hb[0].done).toBeUndefined();
|
|
});
|
|
|
|
test('child() composes phase path with dots', () => {
|
|
const { stream, read } = sink(false);
|
|
const p = createProgress({ mode: 'json', stream, minIntervalMs: 0, minItems: 1 });
|
|
p.start('sync');
|
|
const c = p.child('import');
|
|
c.start('file1', 1);
|
|
c.tick();
|
|
c.finish();
|
|
p.finish();
|
|
const events = parseJsonl(read());
|
|
const startEvents = events.filter((e) => e.event === 'start');
|
|
const phases = startEvents.map((e) => e.phase);
|
|
expect(phases).toContain('sync');
|
|
expect(phases).toContain('sync.import.file1');
|
|
});
|
|
|
|
test('child.finish() does not close parent', () => {
|
|
const { stream, read } = sink(false);
|
|
const p = createProgress({ mode: 'json', stream, minIntervalMs: 0, minItems: 1 });
|
|
p.start('sync');
|
|
const c = p.child('import');
|
|
c.start('batch1', 1);
|
|
c.tick();
|
|
c.finish();
|
|
// Parent still alive — another tick should work.
|
|
// (parent.tick requires a started phase; start was called on 'sync'.)
|
|
p.tick(1, 'after-child');
|
|
p.finish();
|
|
const events = parseJsonl(read());
|
|
const finishes = events.filter((e) => e.event === 'finish');
|
|
const finishPhases = finishes.map((e) => e.phase);
|
|
expect(finishPhases).toContain('sync.import.batch1');
|
|
expect(finishPhases).toContain('sync');
|
|
});
|
|
|
|
test('EPIPE sync throw is swallowed; subsequent writes are no-ops', () => {
|
|
const brokenStream = {
|
|
isTTY: false,
|
|
write: () => {
|
|
throw Object.assign(new Error('write EPIPE'), { code: 'EPIPE' });
|
|
},
|
|
on: () => {},
|
|
} as unknown as NodeJS.WritableStream;
|
|
const p = createProgress({ mode: 'json', stream: brokenStream, minIntervalMs: 0, minItems: 1 });
|
|
// Must not throw.
|
|
expect(() => {
|
|
p.start('scan', 3);
|
|
p.tick();
|
|
p.tick();
|
|
p.finish();
|
|
}).not.toThrow();
|
|
});
|
|
|
|
test("EPIPE stream 'error' event marks stream broken", () => {
|
|
const { stream, read } = sink(false);
|
|
const p = createProgress({ mode: 'json', stream, minIntervalMs: 0, minItems: 1 });
|
|
p.start('scan', 2);
|
|
p.tick();
|
|
// Simulate async EPIPE via error event.
|
|
stream.emit('error', Object.assign(new Error('EPIPE'), { code: 'EPIPE' }));
|
|
// Subsequent calls must not throw.
|
|
expect(() => {
|
|
p.tick();
|
|
p.finish();
|
|
}).not.toThrow();
|
|
// We did get at least the pre-error emissions.
|
|
expect(read()).toContain('"event":"start"');
|
|
});
|
|
|
|
test('only one process-level signal handler installed across many reporters', () => {
|
|
// Baseline: one handler already installed by prior tests in this file.
|
|
const installedBefore = __signalHandlerInstalledForTest();
|
|
// liveReporters is module-global, so a reporter left running by ANOTHER
|
|
// test file in the same shard shows up here. Assert the DELTA (these 50
|
|
// lifecycles leak nothing) instead of an absolute zero — the absolute
|
|
// form flaked whenever shard composition changed and an unrelated file
|
|
// held a live reporter across this test.
|
|
const liveBefore = __liveReporterCountForTest();
|
|
const { stream } = sink(false);
|
|
for (let i = 0; i < 50; i++) {
|
|
const p = createProgress({ mode: 'json', stream, minIntervalMs: 0, minItems: 1 });
|
|
p.start(`phase_${i}`, 1);
|
|
p.finish();
|
|
}
|
|
// After 50 reporter lifecycles, still exactly one handler and no new live entries.
|
|
expect(__signalHandlerInstalledForTest()).toBe(installedBefore || true);
|
|
expect(__liveReporterCountForTest()).toBe(liveBefore);
|
|
});
|
|
|
|
test('startHeartbeat() fires heartbeats and stop() clears', async () => {
|
|
const { stream, read } = sink(false);
|
|
const p = createProgress({ mode: 'json', stream, minIntervalMs: 0, minItems: 1 });
|
|
p.start('slow_query');
|
|
// Larger window + wider tolerance: under 4-way parallel CI shards on a
|
|
// contended host, setTimeout's effective quantum can balloon and a tight
|
|
// 85ms/2-6 bound flakes. We just need to confirm "fires multiple times,
|
|
// stops cleanly" — exact count isn't load-bearing.
|
|
const stop = startHeartbeat(p, 'still running…', 20);
|
|
await new Promise((r) => setTimeout(r, 200));
|
|
stop();
|
|
p.finish();
|
|
const events = parseJsonl(read());
|
|
const hb = events.filter((e) => e.event === 'heartbeat');
|
|
expect(hb.length).toBeGreaterThanOrEqual(1);
|
|
expect(hb.length).toBeLessThanOrEqual(20);
|
|
});
|
|
|
|
test('finish without prior start is a no-op (no crash)', () => {
|
|
const { stream, read } = sink(false);
|
|
const p = createProgress({ mode: 'json', stream });
|
|
expect(() => p.finish()).not.toThrow();
|
|
expect(read()).toBe('');
|
|
});
|
|
|
|
test('tick without prior start is a no-op (no crash)', () => {
|
|
const { stream, read } = sink(false);
|
|
const p = createProgress({ mode: 'json', stream });
|
|
expect(() => p.tick()).not.toThrow();
|
|
expect(read()).toBe('');
|
|
});
|
|
});
|