Files
gbrain/test/conversation-parser/nightly-probe.test.ts
T
f702ec053b v0.41.16.0 feat: conversation parser cathedral + progressive-batch primitive (closes #1461) (#1510)
* v0.41.15.0 feat: conversation parser cathedral + progressive-batch primitive (closes #1461)

Replaces PR #1461's single-format Telegram regex with a 12-pattern
built-in registry covering iMessage/Slack, Telegram (×2), Discord
(×2), WhatsApp (×2 locales), Signal, Matrix/Element, IRC (×2), Teams.
Each pattern is hand-vetted from public format docs (signal-cli,
DiscordChatExporter, Telegram Desktop, WhatsApp export docs, Element
matrix-archive, irssi/weechat defaults); module-load validation runs
test_positive[] + test_negative[] for every pattern at startup so a
typo makes gbrain refuse to start.

PR #1461 contributor's BRACKET_TIME_RX + cleanSpeaker survive verbatim
as the `telegram-bracket` built-in pattern + DEFAULT_SPEAKER_CLEAN
export. All 33 of their test cases pass against the new orchestrator.

Three layers per page (orchestrator chooses):
  1. Built-in pattern registry (zero-cost, deterministic)
  2. User-declared simple_pattern via config (deferred to v0.42+)
  3. Opt-IN LLM polish + fallback (privacy-first; chat content goes
     to Anthropic only when user explicitly enables)

D18 priority scoring picks the highest-match-rate pattern across the
first 10 lines (not first-wins) so overlapping formats don't silently
mis-route. D5 multi_line per-pattern + D11 quick_reject prefix screen
+ D19 timezone_policy per-pattern complete the registry shape.

Companion: src/core/progressive-batch/ primitive (rule of three
satisfied across 12+ ad-hoc cost-prompt sites). Wintermute-inspired
ramp shape (trial 10 → 100 → 500 → full with verification at each
stage), productionized with verifier+policy injection (callers
describe HOW TO MEASURE SUCCESS, not WHEN TO WAIT FOR CTRL-C). D3
fail-closed budget gate: null tracker + null Policy.maxCostUsd →
abort_cost_cap reason='no_budget_safety_net'. D20 discriminated
Verifier union (output_count | idempotent_mutation | noop).
extract-conversation-facts is the one proven consumer in v0.41.15.0;
9-site retrofit deferred to v0.41.16.0+ per TODOS.md.

Codex outside-voice review absorbed 8 substantive findings:
  - Privacy posture (LLM polish/fallback flipped to opt-IN)
  - ReDoS theater (dropped arbitrary user regex; v0.42+ uses RE2)
  - LLM-inferred-regex persistence as silent-corruption machine
  - Pattern priority scoring across first 10 lines
  - Timezone policy on every PatternEntry
  - Verifier shape discriminated union
  - Behavior parity for sites that "jumped straight to full"
  - Real-corpus-redacted fixture gap (v0.42+ TODO)

CI gates:
  - bun run check:conversation-parser (13 fixtures, --no-llm, deterministic)
  - bun run check:fixture-privacy (banned-token grep)

Doctor surfaces 3 new checks: conversation_format_coverage,
progressive_batch_audit_health, conversation_parser_probe_health.

Tests: 198/198 across primitive + parser + LLM + nightly probe + eval
CLI + debug CLI + doctor checks + migration v97 round-trip + E2E
parser ↔ engine integration. Real bug caught + fixed during gap audit:
IdempotentMutationVerifier was comparing absolute mutated-count vs
per-stage expected (failed silently on stage 2+); now uses per-stage
delta semantics matching OutputCountVerifier.

Schema migration v97: conversation_parser_llm_cache table with
(content_sha256, model_id, call_shape) composite key. NO
inferred_patterns table (D17: silent-corruption machine).

Plan + 23 decisions + codex outside-voice absorption at
~/.claude/plans/system-instruction-you-are-working-cuddly-hollerith.md.

Co-Authored-By: garrytan-agents (PR #1461) <noreply@github.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(check-privacy): allowlist scripts/check-fixture-privacy.sh

The new sibling privacy guard literally names the banned tokens in its
BANNED_TOKENS array — same meta-exception that check-privacy.sh itself
gets. Without this allowlist entry, bun run verify rejects the file
post-merge because the banned name appears in the rule-definition script.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: renumber v0.41.15.0 → v0.41.16.0 (queue drift)

Mechanical rename across all surfaces: VERSION, package.json,
CHANGELOG (header + body refs), CLAUDE.md, TODOS.md, src/core/
migrate.ts (migration v98 comment), all src/core/conversation-parser/*
and src/core/progressive-batch/* file headers, all test/ headers,
scripts/check-privacy.sh allowlist comment, llms-full.txt regenerated.

Audit clean: VERSION + package.json + CHANGELOG header all show
0.41.16.0. verify 24/24, touched tests 179/179.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: garrytan-agents (PR #1461) <noreply@github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-26 17:31:48 -07:00

108 lines
4.0 KiB
TypeScript

/**
* v0.41.16.0 — Nightly probe unit tests.
*
* Hermetic via NightlyProbeDeps injection. No real LLM calls.
*
* Pins:
* - Disabled + mode=conservative → rate_limited (informational)
* - Mode=tokenmax overrides disable
* - 24h rate limit → rate_limited
* - No LLM key → no_embedding_key
* - Fixture path missing → fail
* - Adversarial false positive → adversarial_false_positive
* - All pass → pass
*/
import { describe, expect, test } from 'bun:test';
import { mkdtempSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import {
runConversationParserNightlyProbe,
type NightlyProbeDeps,
} from '../../src/core/conversation-parser/nightly-probe.ts';
function tmpFixture(content: string): string {
const dir = mkdtempSync(join(tmpdir(), 'probe-'));
const path = join(dir, 'fix.jsonl');
writeFileSync(path, content);
return path;
}
const POSITIVE = `{"fixture_id":"f1","pattern":"imessage-slack","frontmatter":{"date":"2024-03-15"},"body":"**Alice** (2024-03-15 9:00 AM): hi","expected_messages":1,"expected_participants":["Alice"]}`;
const ADVERSARIAL = `{"fixture_id":"a1","pattern":null,"frontmatter":{"date":"2024-03-15"},"body":"just prose","expected_messages":0,"expected_participants":[]}`;
function baseDeps(overrides: Partial<NightlyProbeDeps> = {}): NightlyProbeDeps {
return {
isEnabled: () => true,
searchMode: () => 'balanced',
hasLlmKey: () => true,
resolveFixturePath: () => tmpFixture(POSITIVE),
resolveAdversarialPath: () => tmpFixture(ADVERSARIAL),
now: () => new Date('2026-05-26T00:00:00Z'),
shouldSkipForRateLimit: () => false,
...overrides,
};
}
describe('runConversationParserNightlyProbe', () => {
test('disabled + balanced mode → rate_limited (informational)', async () => {
const r = await runConversationParserNightlyProbe(
baseDeps({ isEnabled: () => false, searchMode: () => 'balanced' }),
);
expect(r.outcome).toBe('rate_limited');
expect(r.reason).toContain('enabled=false');
});
test('disabled but mode=tokenmax → proceeds (default-on per D10)', async () => {
const r = await runConversationParserNightlyProbe(
baseDeps({ isEnabled: () => false, searchMode: () => 'tokenmax' }),
);
expect(r.outcome).toBe('pass');
});
test('24h rate limit → rate_limited', async () => {
const r = await runConversationParserNightlyProbe(
baseDeps({ shouldSkipForRateLimit: () => true }),
);
expect(r.outcome).toBe('rate_limited');
expect(r.reason).toContain('24h');
});
test('no LLM key → no_embedding_key', async () => {
const r = await runConversationParserNightlyProbe(
baseDeps({ hasLlmKey: () => false }),
);
expect(r.outcome).toBe('no_embedding_key');
});
test('happy path: all pass', async () => {
const r = await runConversationParserNightlyProbe(baseDeps());
expect(r.outcome).toBe('pass');
expect(r.fixtures_total).toBe(2);
expect(r.fixtures_passed).toBe(2);
expect(r.adversarial_false_positives).toBe(0);
});
test('adversarial false positive → adversarial_false_positive', async () => {
// Adversarial fixture that LOOKS like iMessage; the parser will
// match it and the eval will flag as fp.
const adversarialThatMatches = `{"fixture_id":"a-bad","pattern":null,"frontmatter":{"date":"2024-03-15"},"body":"**Alice** (2024-03-15 9:00 AM): I was supposed to be unparseable","expected_messages":0,"expected_participants":[]}`;
const r = await runConversationParserNightlyProbe(
baseDeps({
resolveAdversarialPath: () => tmpFixture(adversarialThatMatches),
}),
);
expect(r.outcome).toBe('adversarial_false_positive');
expect(r.adversarial_false_positives).toBe(1);
});
test('fixture path missing → fail', async () => {
const r = await runConversationParserNightlyProbe(
baseDeps({ resolveFixturePath: () => '/nonexistent/path.jsonl' }),
);
expect(r.outcome).toBe('fail');
expect(r.reason).toContain('missing');
});
});