gbrain/test/lint.test.ts

import { describe, test, expect } from 'bun:test';
import { lintContent, fixContent } from '../src/commands/lint.ts';

describe('lintContent', () => {
  test('detects LLM preamble "Of course"', () => {
    const content = 'Of course. Here is a detailed brain page for Jane Doe.\n\n# Jane Doe\n\nContent.';
    const issues = lintContent(content, 'test.md');
    expect(issues.some(i => i.rule === 'llm-preamble')).toBe(true);
  });

  test('detects LLM preamble "I\'ve created"', () => {
    const content = "I've created a comprehensive brain page for the company.\n\n# Acme\n\nContent.";
    const issues = lintContent(content, 'test.md');
    expect(issues.some(i => i.rule === 'llm-preamble')).toBe(true);
  });

  test('detects LLM preamble "Certainly"', () => {
    const content = 'Certainly. Here is the brain page.\n\n# Page\n\nContent.';
    const issues = lintContent(content, 'test.md');
    expect(issues.some(i => i.rule === 'llm-preamble')).toBe(true);
  });

  test('no false positive on normal content', () => {
    const content = '---\ntitle: Test\ntype: person\ncreated: 2026-04-11\n---\n\n# Test\n\nNormal content.';
    const issues = lintContent(content, 'test.md');
    expect(issues.filter(i => i.rule === 'llm-preamble')).toHaveLength(0);
  });

  test('detects wrapping code fences', () => {
    const content = '```markdown\n---\ntitle: Test\n---\n\n# Test\n\nContent.\n```';
    const issues = lintContent(content, 'test.md');
    expect(issues.some(i => i.rule === 'code-fence-wrap')).toBe(true);
  });

  test('no false positive: page CONTAINS an inner ```markdown code block', () => {
    // Real-world case: a docs/SKILL page that shows a markdown example inline.
    // Before this fix, the detector used the /m flag so ^/$ matched start/end
    // of any line, which fired on any file that simply contained a ```markdown
    // line. But fixContent's regex has no /m flag and can only strip whole-file
    // wrappers, so the issue was reported as "fixable: true" yet never fixed.
    const content =
      '---\ntitle: Skill\n---\n\n# Skill\n\nExample input shape:\n\n' +
      '```markdown\n# Inner page\nContent.\n```\n\nThat ends the example.\n';
    const issues = lintContent(content, 'test.md');
    expect(issues.filter(i => i.rule === 'code-fence-wrap')).toHaveLength(0);
  });

  test('no false positive: multiple inner ```markdown blocks', () => {
    // Documentation pages frequently include several markdown examples.
    const content =
      '---\ntitle: Examples\n---\n\n# Examples\n\nFirst:\n\n' +
      '```markdown\nfoo\n```\n\nSecond:\n\n' +
      '```markdown\nbar\n```\n\nDone.\n';
    const issues = lintContent(content, 'test.md');
    expect(issues.filter(i => i.rule === 'code-fence-wrap')).toHaveLength(0);
  });

  test('detects placeholder dates', () => {
    const content = '---\ntitle: Test\ntype: person\ncreated: YYYY-MM-DD\n---\n\n# Test';
    const issues = lintContent(content, 'test.md');
    expect(issues.some(i => i.rule === 'placeholder-date')).toBe(true);
  });

  test('detects XX-XX placeholder dates', () => {
    const content = '---\ntitle: Test\ntype: person\ncreated: 2026-04-11\n---\n\n# Test\n\n- 2026-XX-XX | Something happened';
    const issues = lintContent(content, 'test.md');
    expect(issues.some(i => i.rule === 'placeholder-date')).toBe(true);
  });

  test('detects missing frontmatter title', () => {
    const content = '---\ntype: person\ncreated: 2026-04-11\n---\n\n# Test';
    const issues = lintContent(content, 'test.md');
    expect(issues.some(i => i.rule === 'missing-title')).toBe(true);
  });

  test('detects missing frontmatter type', () => {
    const content = '---\ntitle: Test\ncreated: 2026-04-11\n---\n\n# Test';
    const issues = lintContent(content, 'test.md');
    expect(issues.some(i => i.rule === 'missing-type')).toBe(true);
  });

  test('detects no frontmatter at all', () => {
    const content = '# Test\n\nContent without frontmatter.';
    const issues = lintContent(content, 'test.md');
    expect(issues.some(i => i.rule === 'no-frontmatter')).toBe(true);
  });

  test('detects empty sections', () => {
    const content = '---\ntitle: Test\ntype: person\ncreated: 2026-04-11\n---\n\n# Test\n\n## What They Believe\n\n[No data yet]\n\n## State\n\nReal content here.';
    const issues = lintContent(content, 'test.md');
    expect(issues.some(i => i.rule === 'empty-section' && i.message.includes('What They Believe'))).toBe(true);
  });

  test('detects agent placeholder sections', () => {
    const content = '---\ntitle: Test\ntype: person\ncreated: 2026-04-11\n---\n\n# Test\n\n## Summary\n\n*[To be filled by agent]*\n\n## State\n\nContent.';
    const issues = lintContent(content, 'test.md');
    expect(issues.some(i => i.rule === 'empty-section' && i.message.includes('Summary'))).toBe(true);
  });

  test('clean page has no issues', () => {
    const content = '---\ntitle: Jane Doe\ntype: person\ncreated: 2026-04-11\n---\n\n# Jane Doe\n\n## State\n\nCTO of Acme Corp.\n\n## Timeline\n\n- **2026-04-11** | Met at event [Source: User]';
    const issues = lintContent(content, 'test.md');
    expect(issues).toHaveLength(0);
  });
});

describe('fixContent', () => {
  test('removes LLM preamble', () => {
    const input = 'Of course. Here is a detailed brain page for Jane.\n\n# Jane Doe\n\nContent.';
    const fixed = fixContent(input);
    expect(fixed).not.toContain('Of course');
    expect(fixed).toContain('# Jane Doe');
    expect(fixed).toContain('Content.');
  });

  test('removes wrapping code fences', () => {
    const input = '```markdown\n# Title\n\nContent.\n```';
    const fixed = fixContent(input);
    expect(fixed).not.toContain('```');
    expect(fixed).toContain('# Title');
  });

  test('cleans up excessive blank lines after fix', () => {
    const input = 'Of course. Here is the brain page.\n\n\n\n# Title\n\nContent.';
    const fixed = fixContent(input);
    expect(fixed).not.toMatch(/\n{3,}/);
  });

  test('preserves content that needs no fixing', () => {
    const input = '# Normal Title\n\nNormal content.\n';
    expect(fixContent(input)).toBe(input);
  });

  test('handles multiple preambles', () => {
    const input = 'Sure! Here is the page.\nCertainly. Here is the brain page.\n\n# Title\n\nContent.';
    const fixed = fixContent(input);
    expect(fixed).not.toContain('Sure');
    expect(fixed).not.toContain('Certainly');
    expect(fixed).toContain('# Title');
  });
});

describe('runLintCore exclude (takeover of #2649)', () => {
  const { mkdtempSync, rmSync, mkdirSync, writeFileSync } = require('node:fs') as typeof import('node:fs');
  const { tmpdir } = require('node:os') as typeof import('node:os');
  const { join } = require('node:path') as typeof import('node:path');
  const { runLintCore } = require('../src/commands/lint.ts') as typeof import('../src/commands/lint.ts');

  const PAGE = '---\ntitle: T\ntype: note\ncreated: 2026-04-11\n---\n\n# T\n\nBody.\n';

  function makeRepo(): string {
    const dir = mkdtempSync(join(tmpdir(), 'gbrain-lint-excl-'));
    writeFileSync(join(dir, 'page.md'), PAGE);
    writeFileSync(join(dir, 'README.md'), PAGE);
    mkdirSync(join(dir, 'node_modules', 'dep'), { recursive: true });
    writeFileSync(join(dir, 'node_modules', 'dep', 'vendor.md'), PAGE);
    mkdirSync(join(dir, 'software'));
    writeFileSync(join(dir, 'software', 'notes.md'), PAGE);
    return dir;
  }

  test('node_modules is excluded by default; nothing else is', async () => {
    const dir = makeRepo();
    try {
      const result = await runLintCore({ target: dir, contentSanity: { disabled: true } });
      // page.md + README.md + software/notes.md — vendor.md skipped.
      expect(result.pages_scanned).toBe(3);
    } finally {
      rmSync(dir, { recursive: true, force: true });
    }
  });

  test('--exclude basenames skip dirs and files', async () => {
    const dir = makeRepo();
    try {
      const result = await runLintCore({
        target: dir,
        contentSanity: { disabled: true },
        exclude: ['software', 'README.md'],
      });
      expect(result.pages_scanned).toBe(1); // only page.md
    } finally {
      rmSync(dir, { recursive: true, force: true });
    }
  });
});