mirror of
https://github.com/garrytan/gbrain.git
synced 2026-07-27 22:15:33 +00:00
* fix(tests): root-cause two master test-infra flakes
gateway.test.ts: add afterAll(resetGateway) hook. The file's tests use
beforeEach(resetGateway) for per-test isolation, but the FINAL test was
leaving configureGateway({env: {OPENAI_API_KEY: 'openai-fake'}}) in the
gateway module state. Sibling files in the same bun shard (e.g.
test/ingestion/ingest-capture.test.ts) then triggered embed() against
the real OpenAI endpoint with the leaked fake key, wedging the shard
with 'Incorrect API key provided: openai-fake'.
header-transport.test.ts → .serial.test.ts: the file mutates RECIPES
(gateway's module-scoped recipe map) plus configureGateway, then asserts
fakeChatFetch was invoked. Under bun's intra-shard parallelism, sibling
files like test/ai/rerank.test.ts race the same state — chat would see
result.text === '[]' instead of 'ok' because another test called
resetGateway between this test's configureGateway and chat. Quarantining
as .serial.test.ts moves the file into the post-parallel serial pass
at --max-concurrency=1 per repo convention.
* refactor(doctor): extract buildChecks seam + behavioral coverage
src/commands/doctor.ts: extract buildChecks(engine, args, dbSource):
Promise<Check[]> from runDoctor. The check-building logic moves into
the new exported function; existing exported computeDoctorReport(checks)
at line 78 stays untouched. runDoctor becomes a thin wrapper:
buildChecks → computeDoctorReport → render + process.exit. All 10
process.exit sites stay in place. The two early-return paths drop
their inline outputResults+process.exit calls and return the partial
check list; the wrapper still produces identical observable output.
test/doctor-behavioral.test.ts (13 cases): pure pure-aggregation cases
pin computeDoctorReport math (3 fails → -60 points, score clamped at 0,
mixed outcome → unhealthy with fail dominating). Orchestrator cases
assert --fast flag honors the skip set, --json doesn't alter the list,
no-engine path returns partial without process.exit, and the snapshot
of load-bearing check names catches accidental drop-outs during
future refactors.
test/doctor-cli-smoke.serial.test.ts (1 case): subprocess smoke spawning
'bun run src/cli.ts doctor --json' against a fresh PGLite tempdir brain.
Catches render-path bugs that buildChecks-only tests miss — the class
the v0.38.2.0 partial-scan wave exposed. Quarantined as .serial because
PGLite write-locks don't play well with parallel runners; skippable via
GBRAIN_SKIP_SUBPROCESS_TESTS=1.
* feat(operations): trust-boundary contract test + filter-bypass shell guard
test/operations-trust-boundary.test.ts (14 cases): hybrid design per
plan D7. Pure assertions over all 74 ops cover the drift-detection
win (every op has a scope; every mutating op has a non-read scope;
hasScope(['read'], op.scope) correctly rejects 'admin' or 'write').
Plus the canonical filter contract: every localOnly: true op is
excluded from operations.filter(op => !op.localOnly). Plus targeted
handler-invocation cases for the two historically-broken HTTP-callable
classes: submit_job(name='shell', ctx.remote=true) MUST reject (F7b
HTTP MCP shell-job RCE class), and search_by_image(image_path,
ctx.remote=true) MUST reject (D18 P0 image-leak class). file_upload
and sync_brain are deliberately omitted from handler-invocation tests
because they're localOnly — calling their handlers directly tests an
impossible production path (codex CMT-3). All 7 localOnly ops are
snapshot-pinned by name to catch future flag-flips.
scripts/check-operations-filter-bypass.sh: greps src/ for any module
that imports the 'operations' value from core/operations.ts outside
the canonical filter site. Three import shapes detected: destructured,
aliased ('as ops'), namespace ('import * as'). Explicit allow-list of
10 known-safe importers with one-line rationale per entry. Plus a
filter-presence check on serve-http.ts that fails if the canonical
filter expression is refactored out. Codex /ship adversarial review
caught the original narrow regex missed aliased + namespace bypasses;
the expanded regex closes that class. Type-only imports of sibling
exports (sourceScopeOpts, OperationContext) are not flagged.
package.json: wires check:operations-filter-bypass into the verify
chain alongside check:jsonb and check:progress.
* refactor(cycle): export runPhaseLint+runPhaseBacklinks; add wrapper tests
src/core/cycle.ts: adds 'export' keyword to two existing phase
functions so behavioral tests can drive them without going through
runCycle's full setup cost. No body changes; no behavior change.
Documented as internal helpers exposed for test-only consumption —
downstream code should NOT take a dependency on them; existing
plan-eng-review D9 explicitly accepted the API-widening tax for
testability.
test/cycle-legacy-phases.test.ts (11 cases): combined file with two
describe blocks per plan D5 (DRY — shared setup, future phase
wrappers land as additional describes). Narrowed to result-mapping
+ error envelope per codex CMT-1 (legacy phases don't extend
BaseCyclePhase and don't take a progress reporter or AbortSignal
directly, so the contract surface is counter → status enum + try/catch
envelope). Cases: clean run → status='ok', partial fix → status='warn'
with dryRun in details, dry-run path doesn't write, throw-from-lib
→ status='fail' with envelope populated (no exception escape).
Verified runLintCore and runBacklinksCore both throw on missing dir,
so the throw-from-lib cases are deterministic.
* chore: bump version and changelog (v0.40.4.1)
E2E + unit test gap coverage wave. Closes 4 audit gaps with new
behavioral coverage (doctor orchestrator + subprocess smoke, operations
trust-boundary contract + filter-bypass guard, cycle phase wrapper
result-mapping). Verifies 3 audit gaps were already covered (ingestion
dedup/daemon/skillpack-load, phantom-redirect, ingestion test-harness).
Root-causes 2 pre-existing master flakes (gateway state leak, header-
transport cross-shard race). Files 5 follow-up TODOs from codex
adversarial-review findings.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs: note v0.40.4.1 doctor.buildChecks + cycle phase exports in CLAUDE.md
Adds three Key-files entries pinning the v0.40.4.1 test-wave additions:
- doctor.ts extension: buildChecks seam + behavioral tests (13+1 cases)
- cycle.ts extension: runPhaseLint + runPhaseBacklinks exports (11 cases)
- operations-trust-boundary contract + check-operations-filter-bypass.sh
Regenerates llms-full.txt to match (CLAUDE.md edits require build:llms per
project rule, otherwise test/build-llms.test.ts fails in CI shard 1).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix(tests): reset gateway in put_page write-through tests to skip embed in CI
CI failure mode: 9 tests in test/ingestion/put-page-write-through.test.ts
failed with `AIConfigError: [embed(zeroentropyai:zembed-1)] Unauthorized`
because put_page's handler at src/core/operations.ts:622 computes
`noEmbed = !isAvailable('embedding')`. When the gateway state has been
configured by a sibling test (or by the cli.ts module-load path reading
.env.testing) with a fake/stale ZEROENTROPY_API_KEY, isAvailable returns
true → put_page tries to embed → the real ZeroEntropy API returns 401.
Local dev passes because real ZE keys are present; CI doesn't have them.
Fix: call resetGateway() in beforeEach so isAvailable('embedding')
returns false → put_page's noEmbed path activates → no network call.
Also reset in afterAll to avoid leaking the cleared state to sibling
files in the same bun shard (the v0.40.4.1 gateway state-leak class
that motivated the earlier gateway.test.ts fix).
The test exercises write-through behavior, not embedding. No need for
a real or fake embed transport — bypass entirely.
* fix(tests): widen brain-writer partial-scan deadlines to absorb CI timing variance
CI failure: scanBrainSources partial-scan state > "hanging COUNT does not
exceed deadline — Promise.race timeout fires" failed once on a GitHub
Actions runner. The test asserted a 100ms deadline budget with a 500ms
bound; observed test duration was 187ms on CI (passes locally 20/20
runs at the original budget).
Root cause: Node.js timer drift under shard parallelism. The deadline
check at src/core/brain-writer.ts:503 uses strict `Date.now() > deadline`,
so when the setTimeout in Promise.race fires exactly at the boundary
(e.g. start+100ms when deadline is start+100ms), the post-await check
sees equality and skips the markRemainingSkipped branch. The test
also asserts elapsed < 500ms; CI overhead can push elapsed past that
bound when setTimeout drifts.
Fix: widen the deadline budget on both deadline-race tests proportionally
(keeps the same 2x ratio that proves "query exceeds deadline"). No
src/ changes — this is purely a test robustness widening.
- "hanging COUNT" test: 100ms → 500ms deadline, 500ms → 2500ms bound
- "slow COUNT" test: 50ms → 250ms deadline, 100ms → 500ms query delay
Verified locally: 20/20 stress runs at the widened budgets, no fails.
* fix(brain-writer): deadline check is >= not > (closes CI flake at boundary)
CI failure recurred: same "hanging COUNT does not exceed deadline" test
failed again at 588ms (past my previous 500ms deadline + 2500ms bound
widening). The root cause isn't test timing — it's an off-by-one in
the source.
src/core/brain-writer.ts had two deadline checks using strict `>`:
- line 445 (between-source abort)
- line 503 (post-COUNT-await re-check)
The Promise.race setTimeout resolves null at exactly `remainingMs` from
now, so post-await Date.now() OFTEN equals the deadline within
integer-ms precision. With `>`, the check skipped → scanOneSource ran
on the source whose budget had just been eaten → that source got
status='scanned' instead of 'skipped'. The test's `expect(firstSource
.status).toBe('skipped')` failed.
Fix: both checks now use `>=`. When Date.now() equals deadline exactly,
the budget IS exhausted — proceeding would let the next source eat its
own budget on top of what's already spent. Matches the boundary the
Promise.race's remainingMs <= 0 immediate-null path uses (line 481).
This is the real fix for the v0.40.x CI flakes; my earlier test-budget
widening papered over the symptom without closing the boundary. Kept
the wider 500ms deadline for headroom but added a comment pointing at
the operator fix as the load-bearing change.
Verified: 20/20 stress runs green locally after the operator fix.
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
463 lines
18 KiB
TypeScript
463 lines
18 KiB
TypeScript
import { describe, test, expect, beforeEach, afterAll } from 'bun:test';
|
|
import {
|
|
configureGateway,
|
|
resetGateway,
|
|
isAvailable,
|
|
embed,
|
|
getEmbeddingModel,
|
|
getEmbeddingDimensions,
|
|
getExpansionModel,
|
|
VoyageResponseTooLargeError,
|
|
} from '../../src/core/ai/gateway.ts';
|
|
|
|
// v0.39.x ship-wave fix: gateway module is process-scoped. Without an
|
|
// afterAll cleanup, the last test's configureGateway({env: {OPENAI_API_KEY:
|
|
// 'openai-fake'}}) state leaked into sibling files in the same bun shard
|
|
// (capture / ingest-capture tests), where it produced "Incorrect API key
|
|
// provided: openai-fake" against the real OpenAI endpoint and wedged
|
|
// the shard. Reset once at file teardown so no caller sees the residue.
|
|
afterAll(() => resetGateway());
|
|
import { parseModelId, resolveRecipe } from '../../src/core/ai/model-resolver.ts';
|
|
import {
|
|
dimsProviderOptions,
|
|
VOYAGE_VALID_OUTPUT_DIMS,
|
|
isValidVoyageOutputDim,
|
|
} from '../../src/core/ai/dims.ts';
|
|
import { AIConfigError } from '../../src/core/ai/errors.ts';
|
|
|
|
describe('gateway configuration', () => {
|
|
beforeEach(() => resetGateway());
|
|
|
|
test('configureGateway sets current models and dims', () => {
|
|
configureGateway({
|
|
embedding_model: 'google:gemini-embedding-001',
|
|
embedding_dimensions: 768,
|
|
expansion_model: 'anthropic:claude-haiku-4-5-20251001',
|
|
env: { GOOGLE_GENERATIVE_AI_API_KEY: 'fake', ANTHROPIC_API_KEY: 'fake' },
|
|
});
|
|
expect(getEmbeddingModel()).toBe('google:gemini-embedding-001');
|
|
expect(getEmbeddingDimensions()).toBe(768);
|
|
expect(getExpansionModel()).toBe('anthropic:claude-haiku-4-5-20251001');
|
|
});
|
|
|
|
test('defaults are ZE 1280d as of v0.36.0.0 (D3)', () => {
|
|
// The default flipped from openai:text-embedding-3-large 1536d to
|
|
// zeroentropyai:zembed-1 1280d in v0.36.0.0. The cost story is in
|
|
// CHANGELOG.md; the rationale lives in src/core/ai/gateway.ts:45-54.
|
|
configureGateway({ env: {} });
|
|
expect(getEmbeddingModel()).toBe('zeroentropyai:zembed-1');
|
|
expect(getEmbeddingDimensions()).toBe(1280);
|
|
expect(getExpansionModel()).toBe('anthropic:claude-haiku-4-5-20251001');
|
|
});
|
|
});
|
|
|
|
describe('gateway.isAvailable (silent-drop regression surface)', () => {
|
|
beforeEach(() => resetGateway());
|
|
|
|
test('returns false when gateway not configured', () => {
|
|
expect(isAvailable('embedding')).toBe(false);
|
|
});
|
|
|
|
test('embedding available when OPENAI_API_KEY set and model is openai', () => {
|
|
configureGateway({
|
|
embedding_model: 'openai:text-embedding-3-large',
|
|
embedding_dimensions: 1536,
|
|
env: { OPENAI_API_KEY: 'sk-fake' },
|
|
});
|
|
expect(isAvailable('embedding')).toBe(true);
|
|
});
|
|
|
|
test('embedding UNAVAILABLE when OPENAI_API_KEY missing even if config names openai', () => {
|
|
configureGateway({
|
|
embedding_model: 'openai:text-embedding-3-large',
|
|
embedding_dimensions: 1536,
|
|
env: {},
|
|
});
|
|
expect(isAvailable('embedding')).toBe(false);
|
|
});
|
|
|
|
test('embedding AVAILABLE for google when GOOGLE_GENERATIVE_AI_API_KEY set even if OPENAI_API_KEY is NOT (Codex silent-drop regression)', () => {
|
|
configureGateway({
|
|
embedding_model: 'google:gemini-embedding-001',
|
|
embedding_dimensions: 768,
|
|
env: { GOOGLE_GENERATIVE_AI_API_KEY: 'fake-google' }, // NOTE: OPENAI_API_KEY deliberately absent
|
|
});
|
|
expect(isAvailable('embedding')).toBe(true);
|
|
});
|
|
|
|
test('embedding AVAILABLE for ollama with no API key (local)', () => {
|
|
configureGateway({
|
|
embedding_model: 'ollama:nomic-embed-text',
|
|
embedding_dimensions: 768,
|
|
env: {},
|
|
});
|
|
expect(isAvailable('embedding')).toBe(true);
|
|
});
|
|
|
|
test('anthropic rejects embedding touchpoint (has no embedding model)', () => {
|
|
configureGateway({
|
|
embedding_model: 'anthropic:claude-haiku-4-5-20251001',
|
|
embedding_dimensions: 1536,
|
|
env: { ANTHROPIC_API_KEY: 'fake' },
|
|
});
|
|
expect(isAvailable('embedding')).toBe(false);
|
|
});
|
|
|
|
test('expansion available when ANTHROPIC_API_KEY set', () => {
|
|
configureGateway({
|
|
expansion_model: 'anthropic:claude-haiku-4-5-20251001',
|
|
env: { ANTHROPIC_API_KEY: 'fake' },
|
|
});
|
|
expect(isAvailable('expansion')).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe('model-resolver', () => {
|
|
test('parseModelId splits on first colon', () => {
|
|
expect(parseModelId('openai:text-embedding-3-large')).toEqual({
|
|
providerId: 'openai',
|
|
modelId: 'text-embedding-3-large',
|
|
});
|
|
});
|
|
|
|
test('parseModelId handles model ids with colons', () => {
|
|
expect(parseModelId('litellm:azure:gpt-4')).toEqual({
|
|
providerId: 'litellm',
|
|
modelId: 'azure:gpt-4',
|
|
});
|
|
});
|
|
|
|
test('parseModelId rejects missing colon', () => {
|
|
expect(() => parseModelId('openai-text-embedding-3-large')).toThrow(AIConfigError);
|
|
});
|
|
|
|
test('parseModelId rejects empty provider or model', () => {
|
|
expect(() => parseModelId(':model')).toThrow(AIConfigError);
|
|
expect(() => parseModelId('provider:')).toThrow(AIConfigError);
|
|
});
|
|
|
|
test('resolveRecipe finds known providers', () => {
|
|
const { recipe, parsed } = resolveRecipe('openai:text-embedding-3-large');
|
|
expect(recipe.id).toBe('openai');
|
|
expect(parsed.modelId).toBe('text-embedding-3-large');
|
|
});
|
|
|
|
test('resolveRecipe throws AIConfigError for unknown provider', () => {
|
|
expect(() => resolveRecipe('cohere:embed-v3')).toThrow(AIConfigError);
|
|
});
|
|
});
|
|
|
|
describe('dims.dimsProviderOptions', () => {
|
|
test('OpenAI text-embedding-3 returns dimensions param', () => {
|
|
const opts = dimsProviderOptions('native-openai', 'text-embedding-3-large', 1536);
|
|
expect(opts).toEqual({ openai: { dimensions: 1536 } });
|
|
});
|
|
|
|
test('OpenAI ada-002 returns undefined (no dim param)', () => {
|
|
const opts = dimsProviderOptions('native-openai', 'text-embedding-ada-002', 1536);
|
|
expect(opts).toBeUndefined();
|
|
});
|
|
|
|
test('Google gemini-embedding returns outputDimensionality', () => {
|
|
const opts = dimsProviderOptions('native-google', 'gemini-embedding-001', 768);
|
|
expect(opts).toEqual({ google: { outputDimensionality: 768 } });
|
|
});
|
|
|
|
test('Anthropic returns undefined (no embedding model)', () => {
|
|
const opts = dimsProviderOptions('native-anthropic', 'claude-haiku-4-5', 1536);
|
|
expect(opts).toBeUndefined();
|
|
});
|
|
|
|
test('openai-compatible returns undefined for providers without a dim param', () => {
|
|
const opts = dimsProviderOptions('openai-compatible', 'nomic-embed-text', 768);
|
|
expect(opts).toBeUndefined();
|
|
});
|
|
|
|
test('Voyage flexible-dim models return dimensions for the SDK shim', () => {
|
|
const opts = dimsProviderOptions('openai-compatible', 'voyage-3-large', 1024);
|
|
expect(opts).toEqual({ openaiCompatible: { dimensions: 1024 } });
|
|
const v4Opts = dimsProviderOptions('openai-compatible', 'voyage-4-large', 2048);
|
|
expect(v4Opts).toEqual({ openaiCompatible: { dimensions: 2048 } });
|
|
});
|
|
|
|
test('Voyage model without flexible dimensions returns undefined', () => {
|
|
const opts = dimsProviderOptions('openai-compatible', 'voyage-3-lite', 1024);
|
|
expect(opts).toBeUndefined();
|
|
});
|
|
|
|
// Negative regression pin: voyage-4-nano is an open-weight variant that
|
|
// Voyage's hosted API rejects `output_dimension` on (fixed 1024-dim).
|
|
// Don't re-add it to VOYAGE_OUTPUT_DIMENSION_MODELS without cross-checking
|
|
// Voyage's docs. See src/core/ai/dims.ts for the rationale.
|
|
test('voyage-4-nano returns undefined (open-weight, fixed-dim)', () => {
|
|
const opts = dimsProviderOptions('openai-compatible', 'voyage-4-nano', 512);
|
|
expect(opts).toBeUndefined();
|
|
});
|
|
});
|
|
|
|
describe('Voyage openai-compatible request shim', () => {
|
|
beforeEach(() => resetGateway());
|
|
|
|
test('sends output_dimension on the actual Voyage embedding request body', async () => {
|
|
const originalFetch = globalThis.fetch;
|
|
let requestBody: Record<string, unknown> | undefined;
|
|
globalThis.fetch = (async (_url: string | URL | Request, init?: RequestInit) => {
|
|
requestBody = JSON.parse(String(init?.body ?? '{}'));
|
|
return new Response(JSON.stringify({
|
|
object: 'list',
|
|
data: [
|
|
{
|
|
object: 'embedding',
|
|
index: 0,
|
|
embedding: new Array(2048).fill(0.01),
|
|
},
|
|
],
|
|
model: 'voyage-4-large',
|
|
usage: { total_tokens: 3 },
|
|
}), {
|
|
status: 200,
|
|
headers: { 'content-type': 'application/json' },
|
|
});
|
|
}) as unknown as typeof fetch;
|
|
|
|
try {
|
|
configureGateway({
|
|
embedding_model: 'voyage:voyage-4-large',
|
|
embedding_dimensions: 2048,
|
|
env: { VOYAGE_API_KEY: 'voyage-fake' },
|
|
});
|
|
|
|
const vectors = await embed(['dimension probe']);
|
|
|
|
expect(vectors[0].length).toBe(2048);
|
|
expect(requestBody?.output_dimension).toBe(2048);
|
|
expect(requestBody?.encoding_format).toBe('base64');
|
|
} finally {
|
|
globalThis.fetch = originalFetch;
|
|
}
|
|
});
|
|
});
|
|
|
|
// ─────────────────────────────────────────────────────────────────────
|
|
// Voyage OOM-cap rethrow regression (Codex P3 follow-up after PR #962).
|
|
// Pins the contract that VoyageResponseTooLargeError thrown from the
|
|
// inbound rewriter is NOT swallowed by the surrounding try/catch.
|
|
// ─────────────────────────────────────────────────────────────────────
|
|
describe('Voyage OOM-cap: too-large response throws (Codex P3 follow-up)', () => {
|
|
beforeEach(() => resetGateway());
|
|
|
|
test('Layer 1 — Content-Length above cap propagates as VoyageResponseTooLargeError', async () => {
|
|
const originalFetch = globalThis.fetch;
|
|
// 257 MB > 256 MB cap.
|
|
const oversized = String(257 * 1024 * 1024);
|
|
globalThis.fetch = (async () => {
|
|
return new Response('{"data": []}', {
|
|
status: 200,
|
|
headers: {
|
|
'content-type': 'application/json',
|
|
'content-length': oversized,
|
|
},
|
|
});
|
|
}) as unknown as typeof fetch;
|
|
try {
|
|
configureGateway({
|
|
embedding_model: 'voyage:voyage-4-large',
|
|
embedding_dimensions: 1024,
|
|
env: { VOYAGE_API_KEY: 'voyage-fake' },
|
|
});
|
|
let caught: unknown;
|
|
try {
|
|
await embed(['probe']);
|
|
} catch (e) {
|
|
caught = e;
|
|
}
|
|
// The OOM throw propagates. Provider plumbing may wrap it, but the
|
|
// VoyageResponseTooLargeError class name + characteristic message
|
|
// must survive.
|
|
const msg = caught instanceof Error ? caught.message : String(caught);
|
|
expect(msg).toContain('Content-Length=');
|
|
expect(msg).toContain('exceeds');
|
|
} finally {
|
|
globalThis.fetch = originalFetch;
|
|
}
|
|
});
|
|
|
|
test('Layer 2 — oversized base64 embedding string propagates (not swallowed)', async () => {
|
|
const originalFetch = globalThis.fetch;
|
|
// Build a JSON response with an `embedding` base64 string that decodes
|
|
// to > 256 MB. base64 ratio is ~0.75; 360 MB of base64 chars ≈ 270 MB
|
|
// decoded.
|
|
const oversizedBase64 = 'A'.repeat(360 * 1024 * 1024);
|
|
const respBody = `{"object":"list","data":[{"object":"embedding","index":0,"embedding":"${oversizedBase64}"}],"model":"voyage-4-large","usage":{"total_tokens":1}}`;
|
|
globalThis.fetch = (async () => {
|
|
// No Content-Length header → Layer 1 skipped, Layer 2 must fire.
|
|
return new Response(respBody, {
|
|
status: 200,
|
|
headers: { 'content-type': 'application/json' },
|
|
});
|
|
}) as unknown as typeof fetch;
|
|
try {
|
|
configureGateway({
|
|
embedding_model: 'voyage:voyage-4-large',
|
|
embedding_dimensions: 1024,
|
|
env: { VOYAGE_API_KEY: 'voyage-fake' },
|
|
});
|
|
let caught: unknown;
|
|
try {
|
|
await embed(['probe']);
|
|
} catch (e) {
|
|
caught = e;
|
|
}
|
|
const msg = caught instanceof Error ? caught.message : String(caught);
|
|
// The Layer 2 throw fired and was not swallowed by the inbound
|
|
// try/catch (pre-fix bug: bare `catch {}` returned the original
|
|
// response and let the AI SDK OOM trying to parse it).
|
|
expect(msg).toContain('Voyage embedding base64 exceeds');
|
|
} finally {
|
|
globalThis.fetch = originalFetch;
|
|
}
|
|
}, 15000);
|
|
|
|
test('VoyageResponseTooLargeError is exported as a tagged class', () => {
|
|
expect(VoyageResponseTooLargeError).toBeDefined();
|
|
const err = new VoyageResponseTooLargeError('test');
|
|
expect(err).toBeInstanceOf(Error);
|
|
expect(err).toBeInstanceOf(VoyageResponseTooLargeError);
|
|
expect(err.name).toBe('VoyageResponseTooLargeError');
|
|
});
|
|
});
|
|
|
|
// ─────────────────────────────────────────────────────────────────────
|
|
// Voyage flexible-dim runtime validation (Codex P3 follow-up after PR #962).
|
|
// The bug class: brain configured for Voyage flexible-dim model without
|
|
// `embedding_dimensions` → gateway falls back to DEFAULT 1536 → Voyage
|
|
// HTTP 400. Catch it at the embed-call boundary with a clear AIConfigError.
|
|
// ─────────────────────────────────────────────────────────────────────
|
|
describe('Voyage flexible-dim runtime validation', () => {
|
|
test('rejects 1536 (the default that bites Voyage-first users) with AIConfigError', () => {
|
|
expect(() => dimsProviderOptions('openai-compatible', 'voyage-4-large', 1536))
|
|
.toThrow(AIConfigError);
|
|
expect(() => dimsProviderOptions('openai-compatible', 'voyage-4-large', 1536))
|
|
.toThrow(/embedding_dimensions|256.*512.*1024.*2048/);
|
|
});
|
|
|
|
test('rejects 3072 with AIConfigError', () => {
|
|
expect(() => dimsProviderOptions('openai-compatible', 'voyage-3-large', 3072))
|
|
.toThrow(AIConfigError);
|
|
});
|
|
|
|
test('accepts every Voyage-allowed flexible dim', () => {
|
|
for (const dim of VOYAGE_VALID_OUTPUT_DIMS) {
|
|
const opts = dimsProviderOptions('openai-compatible', 'voyage-4-large', dim);
|
|
expect(opts).toEqual({ openaiCompatible: { dimensions: dim } });
|
|
}
|
|
});
|
|
|
|
test('VOYAGE_VALID_OUTPUT_DIMS pins exactly the four Voyage values', () => {
|
|
expect([...VOYAGE_VALID_OUTPUT_DIMS]).toEqual([256, 512, 1024, 2048]);
|
|
});
|
|
|
|
test('isValidVoyageOutputDim returns true only for the four valid sizes', () => {
|
|
expect(isValidVoyageOutputDim(256)).toBe(true);
|
|
expect(isValidVoyageOutputDim(512)).toBe(true);
|
|
expect(isValidVoyageOutputDim(1024)).toBe(true);
|
|
expect(isValidVoyageOutputDim(2048)).toBe(true);
|
|
expect(isValidVoyageOutputDim(1536)).toBe(false);
|
|
expect(isValidVoyageOutputDim(3072)).toBe(false);
|
|
expect(isValidVoyageOutputDim(0)).toBe(false);
|
|
expect(isValidVoyageOutputDim(-1)).toBe(false);
|
|
});
|
|
|
|
test('voyage-3-lite (non-flexible-dim) bypasses the validator — still returns undefined', () => {
|
|
// Sanity: the validator only fires inside the flexible-dim branch, so
|
|
// a fixed-dim Voyage model with any dim value goes straight through to
|
|
// the `undefined` return path (no error, no providerOptions).
|
|
expect(dimsProviderOptions('openai-compatible', 'voyage-3-lite', 1536)).toBeUndefined();
|
|
expect(dimsProviderOptions('openai-compatible', 'voyage-4-nano', 1536)).toBeUndefined();
|
|
});
|
|
|
|
test('AIConfigError fix hint names the canonical recovery commands', () => {
|
|
let caught: AIConfigError | undefined;
|
|
try {
|
|
dimsProviderOptions('openai-compatible', 'voyage-4-large', 1536);
|
|
} catch (e) {
|
|
caught = e as AIConfigError;
|
|
}
|
|
expect(caught).toBeInstanceOf(AIConfigError);
|
|
expect(caught?.fix).toContain('embedding_dimensions');
|
|
expect(caught?.fix).toContain('256');
|
|
expect(caught?.fix).toContain('2048');
|
|
});
|
|
});
|
|
|
|
describe('embedding response integrity', () => {
|
|
beforeEach(() => resetGateway());
|
|
|
|
test('rejects partial embedding responses instead of silently dropping rows', async () => {
|
|
const originalFetch = globalThis.fetch;
|
|
globalThis.fetch = (async () => new Response(JSON.stringify({
|
|
object: 'list',
|
|
data: [
|
|
{
|
|
object: 'embedding',
|
|
index: 0,
|
|
embedding: new Array(1536).fill(0.01),
|
|
},
|
|
],
|
|
model: 'text-embedding-3-large',
|
|
usage: { prompt_tokens: 3, total_tokens: 3 },
|
|
}), {
|
|
status: 200,
|
|
headers: { 'content-type': 'application/json' },
|
|
})) as unknown as typeof fetch;
|
|
|
|
try {
|
|
configureGateway({
|
|
embedding_model: 'openai:text-embedding-3-large',
|
|
embedding_dimensions: 1536,
|
|
env: { OPENAI_API_KEY: 'openai-fake' },
|
|
});
|
|
|
|
await expect(embed(['first', 'second'])).rejects.toThrow('1 embedding(s) for 2 input(s)');
|
|
} finally {
|
|
globalThis.fetch = originalFetch;
|
|
}
|
|
});
|
|
|
|
test('checks every returned vector dimension, not just the first one', async () => {
|
|
const originalFetch = globalThis.fetch;
|
|
globalThis.fetch = (async () => new Response(JSON.stringify({
|
|
object: 'list',
|
|
data: [
|
|
{
|
|
object: 'embedding',
|
|
index: 0,
|
|
embedding: new Array(1536).fill(0.01),
|
|
},
|
|
{
|
|
object: 'embedding',
|
|
index: 1,
|
|
embedding: new Array(768).fill(0.01),
|
|
},
|
|
],
|
|
model: 'text-embedding-3-large',
|
|
usage: { prompt_tokens: 3, total_tokens: 3 },
|
|
}), {
|
|
status: 200,
|
|
headers: { 'content-type': 'application/json' },
|
|
})) as unknown as typeof fetch;
|
|
|
|
try {
|
|
configureGateway({
|
|
embedding_model: 'openai:text-embedding-3-large',
|
|
embedding_dimensions: 1536,
|
|
env: { OPENAI_API_KEY: 'openai-fake' },
|
|
});
|
|
|
|
await expect(embed(['first', 'second'])).rejects.toThrow('returned 768 but schema expects 1536');
|
|
} finally {
|
|
globalThis.fetch = originalFetch;
|
|
}
|
|
});
|
|
});
|