mirror of
https://github.com/garrytan/gbrain.git
synced 2026-07-27 22:15:33 +00:00
766604dea0
* fix(minions): self-identifying RSS watchdog + cgroup-aware default + pooler-reap self-heal (#1678) Problem 1: distinct WORKER_EXIT_RSS_WATCHDOG exit code + cause-keyed supervisor breaker (bypasses the stable-run reset that hid the 400x/24h loop) + rss_watchdog audit bucket + 80% soft-warn; cgroup-aware resolveDefaultMaxRssMb replaces the flat 2048 default at every spawn site. Problem 2: CONNECTION_ENDED classified retryable; postgres-engine sql getter throws a retryable error on a reaped instance pool instead of the misleading module-singleton fallthrough; promoteDelayed reconnect-retry; claim recovers on the next poll tick (no double-claim); lock-renewal tick reconnect-once dep. * feat(cycle): surface silent extract_atoms backlog + bounded --drain + fix lint clobbering the shared DB connection (#1678) Problem 3: extract_atoms_backlog doctor check + pack_gated skip marker + shared countExtractAtomsBacklog; `gbrain dream --phase extract_atoms --drain [--window N]` single-hold bounded drain (same cycleLockIdFor, rediscover each batch, reports remaining, exits non-zero while work remains). Also fixes a real production bug found via E2E: the cycle lint phase's resolveLintContentSanity created + disconnected a module-style engine that nulled the shared db singleton mid-cycle, breaking every later phase with "connect() has not been called". Lint now reuses the caller's live engine (cycle + Minion handlers thread it; standalone CLI keeps the create-own path). * chore: bump version and changelog (v0.41.39.0) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(#1678): pre-landing review — route transaction/withReservedConnection through the sql getter + drain treats failed count as incomplete Codex adversarial review findings: - #2: transaction(), withReservedConnection(), and one other site bypassed the v0.42.2.0 sql-getter self-heal via `this._sql || db.getConnection()`, so a reaped instance pool fell through to the module singleton there. Route all three through `this.sql` so they throw the retryable instance-pool error and recover consistently (MinionQueue.transaction hits this). - #4: `gbrain dream --drain` treated a null backlog count (query failure) as success via `remaining ?? 0`; now null exits EXIT_DRAIN_INCOMPLETE so automation never believes an unverified backlog drained. - #1 (claim orphan) + #3 (PGLite drain lock) documented as follow-ups in TODOS. * docs: document v0.42.2.0 #1678 modules + behavior in CLAUDE.md Adds Key Files entries for worker-exit-codes.ts, rss-default.ts, and extract-atoms-drain.ts, plus v0.42.2.0 annotations on worker.ts, child-worker-supervisor.ts, lock-renewal-tick.ts, and dream.ts. Regenerated llms-full.txt to match (test/build-llms.test.ts gate). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: re-version v0.42.2.0 → v0.42.5.0 across VERSION/package.json/CHANGELOG/docs/comments Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
52 lines
2.2 KiB
TypeScript
52 lines
2.2 KiB
TypeScript
/**
|
|
* issue #1678 — lint must REUSE a caller-provided engine for the
|
|
* content-sanity DB-plane config lift, never create + disconnect its own.
|
|
*
|
|
* The bug: resolveLintContentSanity created a module-style engine
|
|
* (createEngine without poolSize wraps the db.ts singleton) and disconnect()ed
|
|
* it, which cascaded to db.disconnect() and NULLED the shared singleton the
|
|
* cycle's lint phase depends on — breaking every subsequent cycle phase with a
|
|
* misleading "connect() has not been called". When the caller passes a live
|
|
* engine, lint must use it directly with zero connection churn.
|
|
*
|
|
* Hermetic: a fake BrainEngine that records disconnect() calls + serves
|
|
* getConfig. No real DB.
|
|
*/
|
|
|
|
import { describe, it, expect, beforeEach, afterEach } from 'bun:test';
|
|
import { mkdtempSync, writeFileSync, rmSync } from 'fs';
|
|
import { tmpdir } from 'os';
|
|
import { join } from 'path';
|
|
import { runLintCore } from '../src/commands/lint.ts';
|
|
import type { BrainEngine } from '../src/core/engine.ts';
|
|
|
|
let dir: string;
|
|
beforeEach(() => {
|
|
dir = mkdtempSync(join(tmpdir(), 'lint-shared-engine-'));
|
|
writeFileSync(join(dir, 'a.md'), '---\ntype: note\ntitle: A\n---\n\nSome content.\n');
|
|
});
|
|
afterEach(() => {
|
|
try { rmSync(dir, { recursive: true, force: true }); } catch { /* noop */ }
|
|
});
|
|
|
|
describe('runLintCore engine reuse (issue #1678)', () => {
|
|
it('reuses a provided engine for the content-sanity lift and NEVER disconnects it', async () => {
|
|
const state = { disconnects: 0, connects: 0, getConfigCalls: 0 };
|
|
const engine = {
|
|
kind: 'postgres' as const,
|
|
getConfig: async () => { state.getConfigCalls++; return null; },
|
|
connect: async () => { state.connects++; },
|
|
disconnect: async () => { state.disconnects++; },
|
|
} as unknown as BrainEngine;
|
|
|
|
await runLintCore({ target: dir, fix: false, dryRun: true, engine });
|
|
|
|
// The load-bearing assertion: the shared engine was used (getConfig hit)
|
|
// but NEVER disconnected and NEVER re-connected — no connection churn that
|
|
// could null a shared singleton mid-cycle.
|
|
expect(state.getConfigCalls).toBeGreaterThan(0);
|
|
expect(state.disconnects).toBe(0);
|
|
expect(state.connects).toBe(0);
|
|
});
|
|
});
|