mirror of
https://github.com/garrytan/gbrain.git
synced 2026-07-27 22:15:33 +00:00
* fix(subagent): bind Anthropic SDK messages.create() correctly The makeSubagentHandler was casting `new Anthropic()` directly to MessagesClient, but MessagesClient.create() maps to sdk.messages.create(), not sdk.create(). Every subagent job immediately died with: client.create is not a function Fix: wrap the SDK instance so .create() delegates to .messages.create() with proper `this` binding via .bind(sdk.messages). Discovered on first production run of gbrain agent against Supabase. Co-Authored-By: Wintermute <wintermute@openclaw.ai> * chore(ci): add typescript typecheck to test pipeline + clean up baseline errors Root cause infra gap that let the v0.16.0 subagent bug ship: CI ran only `bun test`, which transpiles types without checking them. Type errors only surfaced at runtime, in production. Changes: - Add `typescript` devDep and a `typecheck` npm script (`tsc --noEmit`). - Chain `bun run typecheck` into `bun run test` so developers get the same pipeline locally that CI runs. - Flip `.github/workflows/test.yml` to invoke `bun run test` (the npm script, including typecheck) instead of `bun test` (runner only). - Clean up 100+ pre-existing type errors across 30+ files so the first run of `tsc --noEmit` is green. Root causes were: - `databaseUrl` → `database_url` rename drift in test fixtures (9 files) - `PageType` union missing `'meeting'` / `'note'` entries that are already used in both src and tests (link-extraction.ts comments acknowledged the gap) - `GBrainConfig.storage` field never declared despite being read in files.ts and operations.ts - `ErrorCode` union missing `'permission_denied'` - `OrchestratorOpts` shape changed; test callers not updated - Dead-code comparisons in migration orchestrators against narrowed status types - postgres.js `Row`-callback type drift on several `.map()` calls - Buffer-as-BodyInit assignment in supabase.ts (real but non-fatal runtime bug; Uint8Array slice works and is type-correct) - Various `as X` single-step casts that now need `as unknown as X` per TS's stricter structural-conversion rules - Bump `beforeAll` hook timeout to 30s on four PGLite-heavy tests that were flaky under parallel test execution: wait-for-completion, extract-fs, e2e/search-quality, e2e/graph-quality. All pass in isolation; timeouts only happened when dozens of PGLite instances init'd simultaneously. The new CI pipeline now fails on any type error across src/ or test/, giving us the compile-time regression guard the subagent fix depends on. * fix(subagent): bind Anthropic SDK messages.create() correctly Shipped bug: v0.16.0 cast `new Anthropic()` to `MessagesClient`, but `.create()` lives at `sdk.messages.create`, not on the top-level client. Every subagent job in production died on first LLM call with `client.create is not a function`. Discovered on the first `gbrain agent run` against Supabase. Fix: assign `sdk.messages` directly to the `MessagesClient` slot. `sdk.messages` IS the object with a callable `.create()`; the original bug was picking the wrong entry point on the SDK. No helper, no wrapper, no `.bind()` — JS method-call semantics preserve `this` at the call site because `subagent.ts:336` invokes `client.create(...)` with `client === sdk.messages`. The one-line assignment also typechecks cleanly against the existing `MessagesClient` interface (SDK's first `create` overload: `(MessageCreateParamsNonStreaming, Core.RequestOptions?) => APIPromise<Message>` is assignable structurally). This gives us compile-time regression protection: anyone reverting to `new Anthropic()` would fail tsc because `Anthropic` has no top-level `.create`. (The companion chore commit puts `tsc --noEmit` in CI so this guard is enforced.) Also adds a `makeAnthropic?: () => Anthropic` dep-injection seam so the factory default construction branch is testable without real API calls. Regression test drives one handler turn through a fake SDK, asserting `sdk.messages.create` is actually called. If someone later reverts to `new Anthropic()`, both guards fire: tsc fails AND the test fails. Co-Authored-By: Wintermute <wintermute@garrytan.com> * chore(tests): add bunfig.toml + 60s hook timeouts to stabilize PGLite-heavy suites After turning on tsc in CI (previous commit), running the full `bun run test` suite in one shot triggered flaky `beforeEach/afterEach hook timed out` failures on 8+ test files. Every failure traced to PGLite WASM init contention when many test files spin up fresh PGLite instances in parallel; each one alone passes in isolation. - `bunfig.toml` sets the global test hook timeout to 60s (default is 5s), covering every test file without per-file edits. - Individual `beforeAll(fn, 60_000)` / `beforeEach(fn, 15_000)` calls on the 8 tests that flaked most stay in place as explicit safety nets so a future bunfig config change doesn't silently re-introduce the flake. Result: 1997 pass, 0 fail on `bun run test` (117 tests added since the prior baseline by picking up typecheck-gated passes). No infrastructure flake tolerated in CI. * chore: bump version and changelog (v0.16.3) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Wintermute <wintermute@garrytan.com> Co-authored-by: Wintermute <wintermute@openclaw.ai> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
94 lines
4.4 KiB
TypeScript
94 lines
4.4 KiB
TypeScript
import { describe, test, expect } from 'bun:test';
|
|
|
|
describe('doctor command', () => {
|
|
test('doctor module exports runDoctor', async () => {
|
|
const { runDoctor } = await import('../src/commands/doctor.ts');
|
|
expect(typeof runDoctor).toBe('function');
|
|
});
|
|
|
|
test('LATEST_VERSION is importable from migrate', async () => {
|
|
const { LATEST_VERSION } = await import('../src/core/migrate.ts');
|
|
expect(typeof LATEST_VERSION).toBe('number');
|
|
});
|
|
|
|
test('CLI registers doctor command', async () => {
|
|
const result = Bun.spawnSync({
|
|
cmd: ['bun', 'run', 'src/cli.ts', '--help'],
|
|
cwd: import.meta.dir + '/..',
|
|
});
|
|
const stdout = new TextDecoder().decode(result.stdout);
|
|
expect(stdout).toContain('doctor');
|
|
expect(stdout).toContain('--fast');
|
|
});
|
|
|
|
test('Check interface supports issues array', async () => {
|
|
// `Check` is a TypeScript interface — type-only, no runtime value.
|
|
// Importing it for type assertion is enough to validate the shape.
|
|
const check: import('../src/commands/doctor.ts').Check = {
|
|
name: 'resolver_health',
|
|
status: 'warn',
|
|
message: '2 issues',
|
|
issues: [{ type: 'unreachable', skill: 'test-skill', action: 'Add trigger row' }],
|
|
};
|
|
expect(check.issues).toHaveLength(1);
|
|
expect(check.issues![0].action).toContain('trigger');
|
|
});
|
|
|
|
test('runDoctor accepts null engine for filesystem-only mode', async () => {
|
|
const { runDoctor } = await import('../src/commands/doctor.ts');
|
|
// runDoctor should accept null engine — it runs filesystem checks only.
|
|
// Signature is (engine, args, dbSource?) — third param is optional and
|
|
// used by --fast to distinguish "no config" from "user skipped DB check".
|
|
// Function.length counts required params only (JS ignores ?-marked).
|
|
expect(runDoctor.length).toBeGreaterThanOrEqual(2);
|
|
expect(runDoctor.length).toBeLessThanOrEqual(3);
|
|
});
|
|
|
|
// Bug 7 — --fast should differentiate "no config anywhere" from "user
|
|
// chose --fast with GBRAIN_DATABASE_URL / config-file URL present".
|
|
test('getDbUrlSource reflects GBRAIN_DATABASE_URL env var', async () => {
|
|
const { getDbUrlSource } = await import('../src/core/config.ts');
|
|
const orig = process.env.GBRAIN_DATABASE_URL;
|
|
const origAlt = process.env.DATABASE_URL;
|
|
try {
|
|
process.env.GBRAIN_DATABASE_URL = 'postgresql://test@localhost/x';
|
|
expect(getDbUrlSource()).toBe('env:GBRAIN_DATABASE_URL');
|
|
delete process.env.GBRAIN_DATABASE_URL;
|
|
process.env.DATABASE_URL = 'postgresql://test@localhost/x';
|
|
expect(getDbUrlSource()).toBe('env:DATABASE_URL');
|
|
} finally {
|
|
if (orig === undefined) delete process.env.GBRAIN_DATABASE_URL;
|
|
else process.env.GBRAIN_DATABASE_URL = orig;
|
|
if (origAlt === undefined) delete process.env.DATABASE_URL;
|
|
else process.env.DATABASE_URL = origAlt;
|
|
}
|
|
});
|
|
|
|
test('doctor --fast emits source-specific message when URL present', async () => {
|
|
const source = await Bun.file(new URL('../src/commands/doctor.ts', import.meta.url)).text();
|
|
// The source-aware message must reference the variable name so users
|
|
// know where their URL is coming from.
|
|
expect(source).toContain('Skipping DB checks (--fast mode, URL present from');
|
|
// The null-source fallback must still mention both config + env paths.
|
|
expect(source).toContain('GBRAIN_DATABASE_URL');
|
|
});
|
|
|
|
// v0.12.2 reliability wave — doctor detects JSONB double-encode + truncated
|
|
// bodies and points users at the standalone `gbrain repair-jsonb` command.
|
|
// Detection only; repair lives in src/commands/repair-jsonb.ts.
|
|
test('doctor source contains jsonb_integrity and markdown_body_completeness checks', async () => {
|
|
const source = await Bun.file(new URL('../src/commands/doctor.ts', import.meta.url)).text();
|
|
expect(source).toContain('jsonb_integrity');
|
|
expect(source).toContain('markdown_body_completeness');
|
|
expect(source).toContain('gbrain repair-jsonb');
|
|
});
|
|
|
|
test('jsonb_integrity check covers the four JSONB sites fixed in v0.12.1', async () => {
|
|
const source = await Bun.file(new URL('../src/commands/doctor.ts', import.meta.url)).text();
|
|
expect(source).toMatch(/table:\s*'pages'.*col:\s*'frontmatter'/);
|
|
expect(source).toMatch(/table:\s*'raw_data'.*col:\s*'data'/);
|
|
expect(source).toMatch(/table:\s*'ingest_log'.*col:\s*'pages_updated'/);
|
|
expect(source).toMatch(/table:\s*'files'.*col:\s*'metadata'/);
|
|
});
|
|
});
|