mirror of
https://github.com/garrytan/gbrain.git
synced 2026-07-27 22:15:33 +00:00
* fix(subagent): bind Anthropic SDK messages.create() correctly The makeSubagentHandler was casting `new Anthropic()` directly to MessagesClient, but MessagesClient.create() maps to sdk.messages.create(), not sdk.create(). Every subagent job immediately died with: client.create is not a function Fix: wrap the SDK instance so .create() delegates to .messages.create() with proper `this` binding via .bind(sdk.messages). Discovered on first production run of gbrain agent against Supabase. Co-Authored-By: Wintermute <wintermute@openclaw.ai> * chore(ci): add typescript typecheck to test pipeline + clean up baseline errors Root cause infra gap that let the v0.16.0 subagent bug ship: CI ran only `bun test`, which transpiles types without checking them. Type errors only surfaced at runtime, in production. Changes: - Add `typescript` devDep and a `typecheck` npm script (`tsc --noEmit`). - Chain `bun run typecheck` into `bun run test` so developers get the same pipeline locally that CI runs. - Flip `.github/workflows/test.yml` to invoke `bun run test` (the npm script, including typecheck) instead of `bun test` (runner only). - Clean up 100+ pre-existing type errors across 30+ files so the first run of `tsc --noEmit` is green. Root causes were: - `databaseUrl` → `database_url` rename drift in test fixtures (9 files) - `PageType` union missing `'meeting'` / `'note'` entries that are already used in both src and tests (link-extraction.ts comments acknowledged the gap) - `GBrainConfig.storage` field never declared despite being read in files.ts and operations.ts - `ErrorCode` union missing `'permission_denied'` - `OrchestratorOpts` shape changed; test callers not updated - Dead-code comparisons in migration orchestrators against narrowed status types - postgres.js `Row`-callback type drift on several `.map()` calls - Buffer-as-BodyInit assignment in supabase.ts (real but non-fatal runtime bug; Uint8Array slice works and is type-correct) - Various `as X` single-step casts that now need `as unknown as X` per TS's stricter structural-conversion rules - Bump `beforeAll` hook timeout to 30s on four PGLite-heavy tests that were flaky under parallel test execution: wait-for-completion, extract-fs, e2e/search-quality, e2e/graph-quality. All pass in isolation; timeouts only happened when dozens of PGLite instances init'd simultaneously. The new CI pipeline now fails on any type error across src/ or test/, giving us the compile-time regression guard the subagent fix depends on. * fix(subagent): bind Anthropic SDK messages.create() correctly Shipped bug: v0.16.0 cast `new Anthropic()` to `MessagesClient`, but `.create()` lives at `sdk.messages.create`, not on the top-level client. Every subagent job in production died on first LLM call with `client.create is not a function`. Discovered on the first `gbrain agent run` against Supabase. Fix: assign `sdk.messages` directly to the `MessagesClient` slot. `sdk.messages` IS the object with a callable `.create()`; the original bug was picking the wrong entry point on the SDK. No helper, no wrapper, no `.bind()` — JS method-call semantics preserve `this` at the call site because `subagent.ts:336` invokes `client.create(...)` with `client === sdk.messages`. The one-line assignment also typechecks cleanly against the existing `MessagesClient` interface (SDK's first `create` overload: `(MessageCreateParamsNonStreaming, Core.RequestOptions?) => APIPromise<Message>` is assignable structurally). This gives us compile-time regression protection: anyone reverting to `new Anthropic()` would fail tsc because `Anthropic` has no top-level `.create`. (The companion chore commit puts `tsc --noEmit` in CI so this guard is enforced.) Also adds a `makeAnthropic?: () => Anthropic` dep-injection seam so the factory default construction branch is testable without real API calls. Regression test drives one handler turn through a fake SDK, asserting `sdk.messages.create` is actually called. If someone later reverts to `new Anthropic()`, both guards fire: tsc fails AND the test fails. Co-Authored-By: Wintermute <wintermute@garrytan.com> * chore(tests): add bunfig.toml + 60s hook timeouts to stabilize PGLite-heavy suites After turning on tsc in CI (previous commit), running the full `bun run test` suite in one shot triggered flaky `beforeEach/afterEach hook timed out` failures on 8+ test files. Every failure traced to PGLite WASM init contention when many test files spin up fresh PGLite instances in parallel; each one alone passes in isolation. - `bunfig.toml` sets the global test hook timeout to 60s (default is 5s), covering every test file without per-file edits. - Individual `beforeAll(fn, 60_000)` / `beforeEach(fn, 15_000)` calls on the 8 tests that flaked most stay in place as explicit safety nets so a future bunfig config change doesn't silently re-introduce the flake. Result: 1997 pass, 0 fail on `bun run test` (117 tests added since the prior baseline by picking up typecheck-gated passes). No infrastructure flake tolerated in CI. * chore: bump version and changelog (v0.16.3) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Wintermute <wintermute@garrytan.com> Co-authored-by: Wintermute <wintermute@openclaw.ai> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
80 lines
3.6 KiB
TypeScript
80 lines
3.6 KiB
TypeScript
/**
|
|
* Tests for the v0.13.0 frontmatter relationship indexing migration.
|
|
*
|
|
* Iron rule (regression guard for Bug 1, v0.14.0 upgrade night): phase
|
|
* handlers must shell out to the bare string `gbrain`, NOT to
|
|
* `process.execPath`. On bun-installed trees execPath is the bun runtime;
|
|
* `bun extract ...` gets interpreted as `bun run extract` and the upgrade
|
|
* crashes mid-migration. The canonical shim on PATH is the right target.
|
|
*/
|
|
|
|
import { describe, test, expect } from 'bun:test';
|
|
import { readFileSync } from 'fs';
|
|
import { join } from 'path';
|
|
|
|
const SRC_PATH = join(__dirname, '..', 'src', 'commands', 'migrations', 'v0_13_0.ts');
|
|
|
|
describe('v0.13.0 — Frontmatter relationship indexing migration', () => {
|
|
test('registered in the TS migration registry', async () => {
|
|
const { migrations, getMigration } = await import('../src/commands/migrations/index.ts');
|
|
const versions = migrations.map(m => m.version);
|
|
expect(versions).toContain('0.13.0');
|
|
const m = getMigration('0.13.0');
|
|
expect(m).not.toBeNull();
|
|
expect(typeof m!.orchestrator).toBe('function');
|
|
});
|
|
|
|
test('phase functions exported for unit testing', async () => {
|
|
const { __testing } = await import('../src/commands/migrations/v0_13_0.ts');
|
|
expect(typeof __testing.phaseASchema).toBe('function');
|
|
expect(typeof __testing.phaseBBackfill).toBe('function');
|
|
expect(typeof __testing.phaseCVerify).toBe('function');
|
|
});
|
|
|
|
test('dry-run skips all side-effect phases', async () => {
|
|
const { v0_13_0 } = await import('../src/commands/migrations/v0_13_0.ts');
|
|
const result = await v0_13_0.orchestrator({ yes: true, dryRun: true, noAutopilotInstall: true });
|
|
expect(result.version).toBe('0.13.0');
|
|
for (const phase of result.phases) {
|
|
expect(phase.status).toBe('skipped');
|
|
expect(phase.detail).toBe('dry-run');
|
|
}
|
|
});
|
|
|
|
// ── Regression guards (Bug 1) ──────────────────────────────
|
|
|
|
test('source does NOT reference process.execPath (Bug 1 regression)', () => {
|
|
// process.execPath on a bun install is the bun runtime itself, so
|
|
// `${process.execPath} extract` becomes `bun run extract` and dies.
|
|
// See v0.14.0 upgrade-night postmortem.
|
|
const src = readFileSync(SRC_PATH, 'utf-8');
|
|
expect(src).not.toContain('process.execPath');
|
|
});
|
|
|
|
test('source does NOT build commands from a GBRAIN constant (Bug 1 regression)', () => {
|
|
// Earlier revisions used `const GBRAIN = process.execPath` and built
|
|
// commands as `${GBRAIN} extract ...`. The constant was the vector.
|
|
const src = readFileSync(SRC_PATH, 'utf-8');
|
|
expect(src).not.toMatch(/const\s+GBRAIN\s*=/);
|
|
expect(src).not.toMatch(/\$\{GBRAIN\}/);
|
|
});
|
|
|
|
test('phase commands invoke bare `gbrain` shell-out (Bug 1 fix)', () => {
|
|
const src = readFileSync(SRC_PATH, 'utf-8');
|
|
// All three phases shell out to bare `gbrain` so the canonical shim
|
|
// on PATH wins. This is the shape v0_12_0 has always used.
|
|
expect(src).toContain("execSync('gbrain init --migrate-only'");
|
|
expect(src).toContain("execSync('gbrain extract links --source db --include-frontmatter'");
|
|
expect(src).toContain("execSync('gbrain call get_stats'");
|
|
});
|
|
|
|
test('phase commands never reference `bun` or `.ts` paths (Bug 1 regression)', () => {
|
|
// Belt-and-suspenders: even if someone reintroduces a runtime-path
|
|
// helper, they must not produce `bun ...` or `<path>.ts` as the spawn
|
|
// target.
|
|
const src = readFileSync(SRC_PATH, 'utf-8');
|
|
expect(src).not.toMatch(/execSync\([^)]*\bbun\b/);
|
|
expect(src).not.toMatch(/execSync\([^)]*\.ts/);
|
|
});
|
|
});
|