Files
gbrain/test
Garry TanandClaude Opus 4.7 bd751f6f99 v0.41: Bug 2 — lease-full bypass that doesn't burn attempts
The field-report dead-letter loop closed at the root.

Pre-v0.41 the worker treated RateLeaseUnavailableError as a recoverable
error AND incremented attempts_made. After 3 lease-full bounces the job
hit max_attempts (default 3) and dead-lettered with message `rate lease
"anthropic:messages" full (8/8)`. The operator who reported the bug
submitted 100 jobs at --concurrency 10 with a default cap of 8; all 100
dead-lettered before the upstream had a chance to drain.

Fix:

  MinionQueue.releaseLeaseFullJob(jobId, lockToken, errorText, backoffMs)
    Mirrors failJob() but skips the attempts_made increment. Same
    lock_token + status='active' idempotency guard as failJob; returns
    null on lock-token mismatch so racing stall sweeps / cancels still win.

  Worker catch block (src/core/minions/worker.ts:741-792)
    Detects `err instanceof RateLeaseUnavailableError` BEFORE the existing
    `isUnrecoverable || attemptsExhausted` gate. Routes through
    releaseLeaseFullJob with 1-3s jittered backoff. The handler comment
    at subagent.ts:425 ("treat as renewable error so the worker re-claims")
    is now actually true.

  src/core/minions/lease-pressure-audit.ts (NEW)
    Best-effort logLeasePressure() writes one row to migration v93's
    minion_lease_pressure_log per bounce. Denormalized context columns
    (queue_name, job_name, model, provider, root_owner_id) populated
    inline so post-prune forensic queries still see context (Eng D8 /
    codex pass-3 #7). Stderr-warn on write failure; never blocks the
    bypass path.

Pinned by test/minions-lease-full-retry.test.ts (7 cases):
  - flips status to delayed without incrementing attempts_made
  - returns null on lock_token mismatch
  - 5 bounces leaves attempts_made=0; failJob comparison shows the
    asymmetry (failJob DOES bump)
  - logLeasePressure writes denormalized columns
  - countRecentLeasePressure for doctor + jobs stats consumers
  - audit row survives hard-delete via SET NULL FK
  - best-effort no-throw contract on write failure

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-24 00:32:25 -07:00
..