* v0.36.5.0 feat: secure DATABASE_URL access for shell jobs (inherit: ["database_url"]) Replaces PR #1137's plaintext-config / plaintext-env workarounds with code. Shell-job params gain `inherit: ["database_url"]`, validated pre-enqueue in both the CLI (`gbrain jobs submit`) and `submit_job` MCP op handler. Worker resolves the value from its own loadConfig() at child-spawn time; the persisted `minion_jobs.data` row stores only the name. Plain `env: { GBRAIN_DATABASE_URL: ... }` / `env: { DATABASE_URL: ... }` / `env: { GBRAIN_DIRECT_DATABASE_URL: ... }` are rejected pre-enqueue with a paste-ready hint pointing at `inherit:`. Codex pre-landing review caught two bypasses + one missing shadow name: - H1: cmd/argv inline-secret regex scan (cmd:"GBRAIN_DATABASE_URL=... gbrain sync" was a clean bypass — fixed) - H3: GBRAIN_DIRECT_DATABASE_URL added to shadowKeys - H2: honest docs about output-side leakage (stdout_tail/stderr_tail can still carry the value if the script prints it; that's the script author's responsibility, not gbrain's) Also: gbrain doctor learns home_dir_in_worktree (warns when ~/.gbrain lives inside a git worktree); ~/.gbrain/.gitignore retroactive via saveConfig + post-upgrade. New canonical guide: docs/guides/agent-to-gbrain.md (two-domain framing for downstream agent authors: MCP ops via OAuth vs localOnly admin ops via shell-job inherit:). Closes #1137. Tests: +53 new (21 validator + 12 inherit-record + 6 ensureGitignore + 5 doctor + 2 PGLite E2E + 7 codex-driven H1/H3 cases). Credit: @wintermute filed PR #1137 which made the env-stripping gap visible enough to fix in code. Thank you. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * v0.36.5.0 redesign: free-form inherit:, drop closed enum User feedback: "agent spawning minions should have agency to do what it wants with secrets and pass only the ones that it needs. don't be a security nazi please." Replaces the closed INHERITABLE enum (database_url only) with three small helpers in shell-inherit.ts: - INHERIT_NAME_RE: snake_case shape guard. Rejects __proto__, leading underscore, uppercase, path-traversal. Prototype-pollution defense. - deriveEnvKey(name): config-key → child-env-key. Uppercase by default with one override: database_url → GBRAIN_DATABASE_URL. - resolveInheritValue(cfg, name): value lookup with Object.hasOwn. inherit: now accepts any snake_case config-key the worker has. Agent picks what it needs per-job (database_url, anthropic_api_key, voyage_api_key, or any custom field). Validator does NOT police WHICH keys — single-uid trust model treats agent as peer of worker. Drops the v0.36.5.0-RC rules that were paternalistic for the actual threat model: - closed-enum check - env-shadow rejection - cmd/argv inline-secret scan Keeps the parts that defend real problems: - pre-enqueue validation (closes the persistence-before-throw window) - snake_case regex (prototype-pollution + audit-log readability) - fail-fast on missing config value (UX guardrail, not security) Tests: shell-validate (existing rules + new free-form + prototype-pollution defense + T1 regression guard) and shell-inherit (regex matrix, deriveEnvKey per-name, resolveInheritValue with hasOwn defense). E2E case now exercises inherit:["anthropic_api_key"] to prove genuinely free-form. Docs and CHANGELOG rewritten to reflect the open design + the design-arc story (closed → cut → free-form). Migration file too. 7653 unit tests green. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * v0.36.5.0 add: redact_secrets opt-in for stdout/stderr scrubbing Honest defense for the documented output-side leakage. When a script prints an inherited secret, the value lands plaintext in result.stdout_tail / result.stderr_tail / error_text. v0.36.5.0 adds: - `redact_secrets: true` ShellJobParams field - `--redact-secrets` CLI convenience flag on `gbrain jobs submit shell` - shell-redact.ts: pure `redactSecretsInText(text, secrets)` helper (string-mode replaceAll; regex metachars in values stay literal) - Handler post-processes both tails before throw/return, so the persisted row carries `<REDACTED:name>` tokens instead of values Only inherit-resolved values are scrubbed. env: values are not (those are the agent's "fine in the row" channel by design). Heuristic — defeats accidental `echo "$GBRAIN_DATABASE_URL"`, not adversarial encode-then-print. Default false for back-compat. Tests: - test/minions-shell-redact.test.ts (9 cases): pure-function behavior, regex-metachar safety, multi-secret independent redaction, substring overlap, empty-input/map edge cases - test/minions-shell-validate.test.ts: +4 cases for redact_secrets shape - test/e2e/minions-shell-pglite.test.ts: +2 cases proving redact_secrets: true scrubs persisted row AND redact_secrets:false preserves plaintext (back-compat regression guard) Docs + CHANGELOG + migration file + CLAUDE.md updated. 7667 unit tests green. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
13 KiB
Minions shell jobs — move deterministic crons off the gateway
30 seconds
# Run your first shell job:
GBRAIN_ALLOW_SHELL_JOBS=1 gbrain jobs submit shell \
--params '{"cmd":"echo hello","cwd":"/tmp"}' --follow
# → exit_code: 0, stdout_tail: "hello\n", duration_ms: 43
That's it. Your cron scripts now have a home with retry, backoff, DLQ, and
gbrain jobs list visibility, without each one booting a full LLM session.
PGLite users: gbrain jobs work does not run on PGLite (exclusive file
lock). Every crontab invocation must use --follow for inline execution.
Postgres users can run a persistent worker; see recipes below.
Why it exists
If your agent runs deterministic scripts from cron (token refresh, API fetch, scrape + write), each one pays the cost of a full LLM session on the gateway. Fourteen simultaneous fires on a Series A deployment pin CPU at 100% and block live messages. None of those scripts need reasoning. They need a shell.
Shell jobs move them to the Minions worker: one deterministic-script execution per cron, zero LLM tokens, unified visibility and retry.
Security model (read this)
Shell exec is a large blast radius. We ship two independent gates, both must pass:
- MCP boundary.
submit_jobwithname: 'shell'is rejected whenctx.remote === true(MCP callers). Independent of the env flag. Remote agents can never submit shell jobs.MinionQueue.add('shell', ...)has its own guard too, so an in-process handler can't programmatically bypass this. - Env flag. The worker only registers the shell handler when
GBRAIN_ALLOW_SHELL_JOBS=1is set on the worker process. Default: off. Your agent opts in per-host.
What the env allowlist does AND does not do. Shell jobs run with a minimal
env: PATH, HOME, USER, LANG, TZ, NODE_ENV. Your secrets like OPENAI_API_KEY
and DATABASE_URL are NOT passed to the child. You opt-in additional keys per
job via env: { ... } (non-secret values only — see "Secrets" below) or via
inherit: ["database_url"] (recommended for secrets — names only in the row,
values resolved at child-spawn from gbrain config set). This stops accidental
$OPENAI_API_KEY interpolation in a user-authored script. It does not
sandbox filesystem reads: a shell script can cat ~/.env or any file the
worker process can read. The operator picks a safe cwd. That is the trust
boundary.
Audit trail, not forensic insurance. Every submission writes a JSONL line
to ~/.gbrain/audit/shell-jobs-YYYY-Www.jsonl (ISO-week rotation; override
with GBRAIN_AUDIT_DIR). Failures log to stderr and don't block submission, so
a disk-full adversary could silently disable the trail. Good for "what did
this cron submit last Tuesday", not for security-critical forensics.
The command text is logged as-is. If you embed a secret in cmd
(curl -H 'Authorization: Bearer ...'), it shows up in the audit file. Put
secrets in env: instead.
Migrate a cron
Postgres worker (recommended)
On one terminal, start a persistent worker:
GBRAIN_ALLOW_SHELL_JOBS=1 gbrain jobs work
Rewrite crontab to submit shell jobs (no --follow):
# Before (LLM gateway):
# OpenClaw cron: x-garrytan-unified
# After (Minions worker):
3 13,16,19,22,1,4,7,10 * * * \
gbrain jobs submit shell \
--params '{"cmd":"node scripts/x-garrytan-daily.mjs","cwd":"/data/.openclaw/workspace"}' \
--max-attempts 3 --timeout-ms 300000
Worker claims the job on next poll, runs it, records exit_code +
stdout_tail + stderr_tail in the result. Failures retry per
--max-attempts with exponential backoff.
PGLite (inline execution)
PGLite doesn't support the persistent worker daemon. Every crontab invocation
uses --follow to run inline:
# Each cron tick spawns a short-lived worker that runs the job inline.
3 13,16,19,22,1,4,7,10 * * * \
GBRAIN_ALLOW_SHELL_JOBS=1 gbrain jobs submit shell \
--params '{"cmd":"node scripts/x-garrytan-daily.mjs","cwd":"/data/.openclaw/workspace"}' \
--follow --timeout-ms 300000
Note: --follow blocks the crontab slot until the job finishes. If 14 shell
crons land at the same minute and each takes 30s, they serialize through
crontab's spawning limits. Postgres + persistent worker scales better.
Calling gbrain itself from a shell job — use inherit: for DATABASE_URL
A common pattern is submitting shell jobs that run gbrain CLI commands:
gbrain jobs submit shell --params '{
"cmd": "gbrain sync --skip-failed && gbrain embed --stale",
"cwd": "/data/gbrain",
"inherit": ["database_url"]
}'
inherit: ["database_url"] tells the worker to look up database_url from its
own loadConfig() (file + env merged) and inject the value into the child's
env as GBRAIN_DATABASE_URL. The job row in minion_jobs.data stores
inherit: ["database_url"] — names only, never values. The shell-audit
JSONL records the same. Pre-enqueue validation rejects the submission if the
worker can't resolve the requested key, with a paste-ready
gbrain config set database_url <value> hint.
Why not just write the URL into env: directly? Pre-v0.36.5.0 callers
wrote things like:
// ❌ Deprecated as of v0.36.5.0 — REJECTED at submit time.
{
"cmd": "gbrain stats",
"cwd": "/data/gbrain",
"env": { "GBRAIN_DATABASE_URL": "postgresql://..." }
}
This planted plaintext secrets in minion_jobs.data (DB row) and in the
shell-audit JSONL. Anyone with read access to the brain DB (or a brain dump,
or a shared brain via the mounts feature) saw the URL. v0.36.5.0 doesn't
forbid that pattern — the validator trusts the agent — but prefer
inherit: for any secret you want kept out of the row. Names land in the
row; values resolve at child-spawn from the worker's config.
Scope: v0.36.5.0 inherit: is free-form. Pass any snake_case
config-key name and the worker resolves the value from loadConfig() at
child-spawn time:
inherit: ["database_url"]→ child envGBRAIN_DATABASE_URLinherit: ["anthropic_api_key"]→ child envANTHROPIC_API_KEYinherit: ["openai_api_key"]→ child envOPENAI_API_KEYinherit: ["voyage_api_key"]→ child envVOYAGE_API_KEYinherit: ["groq_api_key", "zeroentropy_api_key"]→ both injected- Or any arbitrary config-key your worker has (
my_custom_field→MY_CUSTOM_FIELD)
The env-key name is derived by uppercasing the config-key name. The one
override is database_url → GBRAIN_DATABASE_URL (plain DATABASE_URL is
ambiguous in most Postgres-app contexts).
Pre-enqueue validation fail-fasts if the worker can't resolve a requested name. The validator does NOT police which secrets you choose to inherit — the agent submitting the minion is in the same uid as the worker, so it's your call.
Output-side leakage (read this). The inherit: allowlist prevents
secrets from landing in the JOB ROW INPUT fields (data.cmd, data.argv,
data.env). By default it does NOT scrub the OUTPUT fields — if your
script prints the secret to stdout or stderr (echo "$GBRAIN_DATABASE_URL",
psql "$GBRAIN_DATABASE_URL" echoing the URL on error), the value lands
plaintext in result.stdout_tail / result.stderr_tail / error_text,
and from there into the brain DB row.
redact_secrets: true opts into output-side scrubbing. Set it per-job
(or pass --redact-secrets on the CLI):
gbrain jobs submit shell --params '{
"cmd": "gbrain sync --skip-failed",
"cwd": "/data/gbrain",
"inherit": ["database_url"],
"redact_secrets": true
}'
# Or, equivalently:
gbrain jobs submit shell \
--params '{"cmd":"gbrain sync --skip-failed","cwd":"/data/gbrain","inherit":["database_url"]}' \
--redact-secrets
When redact_secrets: true, the worker resolves each name in inherit: to
a value, runs the child, then string-replaces every occurrence of those
values in stdout_tail / stderr_tail (and in the error_text derived from
stderr_tail on non-zero exit) with <REDACTED:name> before persistence.
Only inherit:-resolved values are scrubbed; caller-supplied env: values
are not (those are the "I'm fine with this in the row" channel by design).
Heuristic, not perfect. The redactor uses literal string-replace. A script that base64-encodes the secret before printing, or that emits it one character at a time, will bypass the scrub. Those are adversarial shapes — the agent + the script are in the same trust domain, so this layer defends against accidental echo (the common case), not deliberate exfiltration.
Three rules for shell-job authors who deal with secrets:
- Prefer not to echo secrets at all. Even with
redact_secrets, less output means less risk if the redactor ever has an edge-case miss. - Wrap noisy CLI tools to suppress URLs on error.
psql --quiet,pg_dump --quiet, or pipe through2>&1 | sed 's|postgresql://[^@]*@|postgresql://REDACTED@|g'. - Inspect with
gbrain jobs get <id>after a failure to verify what actually persisted.
Submitting with argv (no shell interpolation)
For programmatic callers assembling commands from JSON, use argv instead of
cmd. No shell, no injection surface:
gbrain jobs submit shell \
--params '{"argv":["node","scripts/fetch.mjs","--date","2026-04-19"],"cwd":"/data"}' \
--follow
Debug a failed job
# List dead shell jobs
gbrain jobs list --status dead
# Inspect one
gbrain jobs get 42
# → error_text, stacktrace, result.stdout_tail, result.stderr_tail
# Submission audit log (operator trail, not forensic)
cat ~/.gbrain/audit/shell-jobs-*.jsonl | jq '.'
# First-time failure mode: submitted without env flag on the worker
gbrain jobs list --status waiting --name shell
# If rows pile up here, no worker with GBRAIN_ALLOW_SHELL_JOBS=1 is running.
Limitations
- Filesystem reads are not sandboxed. See "Security model" above. Don't
point
cwdat a directory full of secrets. - Audit log is advisory. Disk-full or EACCES silently disables it.
- Cancel latency is lock-renewal-bounded (~7-15 s by default). A cancelled child keeps running until the next lock-renewal tick fails.
--followclaim order is by priority/created_at. If another job is waiting in the same queue at the time of--follow, that one runs first.cwdsymlink TOCTOU. The absolute-path check doesn't guard against symlinks pointing elsewhere at execution time. Operator-scope concern.
Errors
| Error | What it means | Fix |
|---|---|---|
shell: specify exactly one of cmd or argv |
cmd and argv are mutually exclusive. Both absent is also invalid. |
Choose one. cmd for shell-interpolated strings; argv for structured args. |
shell: cwd is required and must be an absolute path |
cwd must be a string starting with /. |
Set cwd in --params to an absolute path. |
shell: argv must be an array of strings |
argv has a non-string entry or isn't an array. |
Pass argv: ["bin","arg1","arg2"]. |
shell: env values must all be strings |
env has a number/bool/object value. |
Stringify: "env":{"COUNT":"3"} not "env":{"COUNT":3}. |
shell: inherit must be an array of config-key names |
inherit wasn't an array. |
Pass "inherit": ["database_url", ...]. |
shell: inherit entries must be non-empty strings |
An element of inherit was empty, non-string, or null. |
Use snake_case config-key names like database_url, anthropic_api_key. |
shell: inherit name "<X>" must match [a-z][a-z0-9_]* |
Name failed snake_case regex (uppercase, leading digit/underscore, special char). | Use the config-key name verbatim — database_url, not DATABASE_URL. |
shell: inherit requested "<X>" but worker has no <X> configured |
Worker can't resolve the requested name from loadConfig(). |
Run gbrain config set <X> <value> on the worker host, OR check the config file at ~/.gbrain/config.json. |
shell: redact_secrets must be a boolean if set |
Caller passed a non-boolean for redact_secrets. |
Pass true or false (or omit). The CLI --redact-secrets flag sets it automatically. |
permission_denied: shell jobs cannot be submitted over MCP |
An MCP client tried to submit a shell job. By design CLI-only. | Submit from CLI or via a trusted operation handler (ctx.remote === false). |
protected job name 'shell' requires CLI or operation-local submitter |
A caller invoked MinionQueue.add('shell', ...) without the trusted opt-in. |
Pass { allowProtectedSubmit: true } as the 4th arg. CLI and submit_job do this automatically. |
aborted: timeout / aborted: cancel / aborted: shutdown / aborted: lock-lost |
The worker's abort signal fired mid-execution. Child got SIGTERM, 5s grace, then SIGKILL. | Expected: timeout / user cancel / deploy restart / stall. Inspect gbrain jobs get to see which. |
exit N: <stderr_tail_500> |
Script exited non-zero. | Read stderr_tail in gbrain jobs get. |