From 2f99dec73db5c2e300357088738233c95db31506 Mon Sep 17 00:00:00 2001 From: Steven Enamakel Date: Thu, 5 Feb 2026 01:14:59 +0530 Subject: [PATCH] fix: update Google Play upload condition in CI workflow - Modified the condition for uploading AAB files to Google Play in package-android.yml to check for the GOOGLE_PLAY_UPLOAD_ENABLED variable instead of the GOOGLE_PLAY_SERVICE_ACCOUNT_JSON secret, ensuring proper configuration for the upload process. --- .github/workflows/package-android.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/package-android.yml b/.github/workflows/package-android.yml index d2b1634a1..3885b3d22 100644 --- a/.github/workflows/package-android.yml +++ b/.github/workflows/package-android.yml @@ -257,10 +257,10 @@ jobs: --data-binary "@${{ steps.find-aab.outputs.path }}" \ "https://uploads.github.com/repos/$PUBLISH_REPO/releases/$RELEASE_ID/assets?name=${{ steps.find-aab.outputs.filename }}" - # Requires secret GOOGLE_PLAY_SERVICE_ACCOUNT_JSON (full JSON key from Play Console API access) + # Requires secret GOOGLE_PLAY_SERVICE_ACCOUNT_JSON and vars.GOOGLE_PLAY_UPLOAD_ENABLED = 'true' # Track: internal | alpha | beta | production (use vars.GOOGLE_PLAY_TRACK to override) - name: Upload AAB to Google Play - if: needs.get-version.outputs.should-publish == 'true' && ${{ secrets.GOOGLE_PLAY_SERVICE_ACCOUNT_JSON != '' }} + if: needs.get-version.outputs.should-publish == 'true' && vars.GOOGLE_PLAY_UPLOAD_ENABLED == 'true' uses: r0adkll/upload-google-play@v1 with: serviceAccountJsonPlainText: ${{ secrets.GOOGLE_PLAY_SERVICE_ACCOUNT_JSON }}