diff --git a/app/src-tauri/Cargo.lock b/app/src-tauri/Cargo.lock index b7c77d5ef..944e8031a 100644 --- a/app/src-tauri/Cargo.lock +++ b/app/src-tauri/Cargo.lock @@ -4,7 +4,7 @@ version = 4 [[package]] name = "OpenHuman" -version = "0.53.12" +version = "0.53.13" dependencies = [ "anyhow", "async-trait", @@ -1289,7 +1289,7 @@ dependencies = [ "core-foundation-sys 0.8.7", "coreaudio-rs", "dasp_sample", - "jni 0.21.1", + "jni", "js-sys", "libc", "mach2 0.4.3", @@ -2788,34 +2788,6 @@ version = "3.5.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "62adaabb884c94955b19907d60019f4e145d091c75345379e70d1ee696f7854f" -[[package]] -name = "html2md" -version = "0.2.15" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "8cff9891f2e0d9048927fbdfc28b11bf378f6a93c7ba70b23d0fbee9af6071b4" -dependencies = [ - "html5ever 0.27.0", - "jni 0.19.0", - "lazy_static", - "markup5ever_rcdom", - "percent-encoding", - "regex", -] - -[[package]] -name = "html5ever" -version = "0.27.0" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "c13771afe0e6e846f1e67d038d4cb29998a6779f93c809212e4e9c32efd244d4" -dependencies = [ - "log", - "mac", - "markup5ever 0.12.1", - "proc-macro2", - "quote", - "syn 2.0.117", -] - [[package]] name = "html5ever" version = "0.29.1" @@ -3310,20 +3282,6 @@ dependencies = [ "syn 2.0.117", ] -[[package]] -name = "jni" -version = "0.19.0" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "c6df18c2e3db7e453d3c6ac5b3e9d5182664d28788126d39b91f2d1e22b017ec" -dependencies = [ - "cesu8", - "combine", - "jni-sys 0.3.1", - "log", - "thiserror 1.0.69", - "walkdir", -] - [[package]] name = "jni" version = "0.21.1" @@ -3678,20 +3636,6 @@ dependencies = [ "libc", ] -[[package]] -name = "markup5ever" -version = "0.12.1" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "16ce3abbeba692c8b8441d036ef91aea6df8da2c6b6e21c7e14d3c18e526be45" -dependencies = [ - "log", - "phf 0.11.3", - "phf_codegen 0.11.3", - "string_cache 0.8.9", - "string_cache_codegen 0.5.4", - "tendril 0.4.3", -] - [[package]] name = "markup5ever" version = "0.14.1" @@ -3717,18 +3661,6 @@ dependencies = [ "web_atoms", ] -[[package]] -name = "markup5ever_rcdom" -version = "0.3.0" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "edaa21ab3701bfee5099ade5f7e1f84553fd19228cf332f13cd6e964bf59be18" -dependencies = [ - "html5ever 0.27.0", - "markup5ever 0.12.1", - "tendril 0.4.3", - "xml5ever", -] - [[package]] name = "match_token" version = "0.1.0" @@ -4473,7 +4405,7 @@ version = "0.6.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "e8b61bebd49e5d43f5f8cc7ee2891c16e0f41ec7954d36bcb6c14c5e0de867fb" dependencies = [ - "jni 0.21.1", + "jni", "ndk 0.8.0", "ndk-context", "num-derive", @@ -4522,7 +4454,7 @@ dependencies = [ [[package]] name = "openhuman" -version = "0.53.12" +version = "0.53.13" dependencies = [ "aes-gcm", "anyhow", @@ -4553,7 +4485,6 @@ dependencies = [ "hmac 0.12.1", "hostname", "hound", - "html2md", "iana-time-zone", "image", "lettre", @@ -5962,7 +5893,7 @@ checksum = "1d99feebc72bae7ab76ba994bb5e121b8d83d910ca40b36e0921f53becc41784" dependencies = [ "core-foundation 0.10.1", "core-foundation-sys 0.8.7", - "jni 0.21.1", + "jni", "log", "once_cell", "rustls", @@ -6887,7 +6818,7 @@ dependencies = [ "dpi", "gdkwayland-sys", "gtk", - "jni 0.21.1", + "jni", "libc", "log", "ndk 0.9.0", @@ -6951,7 +6882,7 @@ dependencies = [ "gtk", "heck 0.5.0", "http", - "jni 0.21.1", + "jni", "libc", "log", "mime", @@ -7170,7 +7101,7 @@ dependencies = [ "dpi", "gtk", "http", - "jni 0.21.1", + "jni", "objc2 0.6.4", "objc2-ui-kit", "raw-window-handle", @@ -7216,7 +7147,7 @@ version = "2.10.1" dependencies = [ "gtk", "http", - "jni 0.21.1", + "jni", "log", "objc2 0.6.4", "objc2-app-kit 0.3.2", @@ -9375,7 +9306,7 @@ dependencies = [ "gtk", "http", "javascriptcore-rs", - "jni 0.21.1", + "jni", "libc", "ndk 0.9.0", "objc2 0.6.4", @@ -9465,17 +9396,6 @@ version = "0.2.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "b9cc00251562a284751c9973bace760d86c0276c471b4be569fe6b068ee97a56" -[[package]] -name = "xml5ever" -version = "0.18.1" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "9bbb26405d8e919bc1547a5aa9abc95cbfa438f04844f5fdd9dc7596b748bf69" -dependencies = [ - "log", - "mac", - "markup5ever 0.12.1", -] - [[package]] name = "xz2" version = "0.1.7" diff --git a/app/src-tauri/vendor/tauri-cef b/app/src-tauri/vendor/tauri-cef index c10bc0f72..f1ee9554f 160000 --- a/app/src-tauri/vendor/tauri-cef +++ b/app/src-tauri/vendor/tauri-cef @@ -1 +1 @@ -Subproject commit c10bc0f7293f6070478fc8af1a157004f5916f10 +Subproject commit f1ee9554ffc414524ed6c2013dd286f0fe38907f diff --git a/docs/qa/SLACK-PARITY.md b/docs/qa/SLACK-PARITY.md index 04de8a812..6f6618962 100644 --- a/docs/qa/SLACK-PARITY.md +++ b/docs/qa/SLACK-PARITY.md @@ -23,7 +23,7 @@ | 2 | **Messaging** β€” channels, DMs, group DMs; threads | βœ… pass | User confirmed send-receive works in DMs/channels. Threads navigable. UI parity matches web Slack. | Memory-side extraction blocked by #7 (scanner doesn't run); will re-verify post-fix. | | 3 | **Reactions & emoji** β€” picker opens; reactions post correctly | βœ… pass | User confirmed reactions + threads work end-to-end. UI render confirmed in screenshot (`πŸ™ 1`, `πŸ‘ 1`). | Pre-audit "extraction missing" claim DEFERRED β€” unverifiable until #7 fix lands and scanner actually runs. Will re-recall memories post-fix; if reactions show in memory docs, the static audit was wrong (like #4 was). Only if missing post-#7-fix do we touch `extract.rs`. | | 4 | **File sharing** β€” upload, download; image previews | βœ… pass | User confirmed upload/download/preview all work. | Pre-audit "allowed_hosts mismatch" was a **false alarm**: `slackb.com` IS the working CDN host. Spec's `slack-imgs.com` + `slack-files.com` are stale β€” DO NOT change `webview_accounts/mod.rs:101`. Drop that fix from the plan. | -| 5 | **Huddles** β€” popup spawn (about:blank β†’ huddle URL whitelisted); audio/video; popup cleanup on end | ❌ **fail** (paint lifecycle bug; deferred to CEF tracking issue) | `OPENHUMAN_SLACK_HUDDLE_PROBE=1` debug instrumentation captured the popup lifecycle 12:28:29–12:28:37: `windowOpen url=about:blank`, `target_created`, `target_info_changed url=about:blank` (and stays at about:blank for 8s), `target_destroyed`. **No `Page.frameNavigated` ever fires on the popup target** β€” URL never leaves `about:blank`. Combined with user-observed behaviour ("name + voice + camera tile briefly render then go white"), the working hypothesis (CEF doesn't honor cross-window `popup.location = huddleURL`) was **invalidated**. Real root cause: Slack uses `popup.document.write(html)` to inject huddle UI into the same `about:blank` document β€” there is no URL navigation to intercept; the bug is CEF's paint/compositor lifecycle on same-document popups. | Tracked in **[#1074](https://github.com/tinyhumansai/openhuman/issues/1074)** (popup paint) β†’ root-cause refined to **[#1079](https://github.com/tinyhumansai/openhuman/issues/1079)** (CEF same-document popup paint lifecycle). The #1074 PR ships partial fixes (media perms grant + slack:// deep-link isolation, see "Fixes shipped in this PR" below); full huddle paint resolution gated on the CEF tracking issue. Joins the runtime-gap family in `feedback_cef_runtime_gaps.md` (Web Push, BrowserChannel, MediaPipe segmentation, **same-document popup paint**). | +| 5 | **Huddles** β€” popup spawn (about:blank β†’ huddle URL whitelisted); audio/video; popup cleanup on end | βœ… **pass** (paint lifecycle fixed) | Original symptom: popup briefly rendered "name + voice + camera tile" then went white after ~1s. Root cause turned out to be embedder-side (NOT a CEF runtime gap, as initially feared): tauri-cef's `BrowserLifeSpanHandler::on_after_created` scheduled a 1s blank-page guard using `self.initial_url`. CEF passes the opener's `CefClient` through `on_before_popup` unless the embedder overrides it, so the handler also fires for popup browsers β€” and `self.initial_url` is the OPENER's URL, never the popup's. The guard then saw the popup's `about:blank` URL (legit β€” Slack uses `popup.document.write(html)`, no navigation) and called `frame.load_url(parent_initial_url)`, wiping Slack's document-written huddle content. **Fix**: skip the blank-page guard when `browser.is_popup() != 0`. Verified working β€” popup stays interactive for full huddle lifetime. | Fixed in [tinyhumansai/tauri-cef#12](https://github.com/tinyhumansai/tauri-cef/pull/12) + this PR (submodule pin bump). Closes [#1079](https://github.com/tinyhumansai/openhuman/issues/1079). The earlier #1074 work (media perms grant + slack:// deep-link isolation, see "Fixes shipped in this PR" below) is still required β€” the popup-paint fix unlocks getUserMedia/getDisplayMedia in the popup, but those require the perms grant from row E. | | 6 | **Notifications** β€” native OS notifications; per-channel mute; DND; `notification_settings` toggle | ❌ **fail** | User received Slack DM from Shanu while NOT focused on OpenHuman. macOS Notifications perm granted for OpenHuman.app. Result: **no native toast fired**. Log shows zero `forward_native_notification` / `webview_notification` events at message-arrival time. CEF shim `installed shims browser_id=3 origin=https://app.slack.com/client` was registered, but page-side `new Notification(...)` never reached Rust handler. | **CHILD ISSUE TO FILE**: title `[Bug] webview/slack: native OS notifications never fire β€” pageβ†’Rust bridge broken`. Repro: signed-in Slack workspace, OpenHuman backgrounded, peer sends DM β†’ no toast. Hypothesis: (a) Slack web suppresses Notification when its own permission state for the origin isn't `"granted"`, or (b) CEF Notification shim wrap doesn't actually call `forward_native_notification`. Need to verify CEF `Notification.permission` value at slack.com origin and confirm the constructor wrap path. Pre-audit gaps (per-channel mute missing; default=true) are still valid but moot until basic toast path works. | | 7 | **Memory ingestion** β€” IDB scanner; `memory_doc_ingest` posts; current behavior groups by `channel_id` (per-day grouping deferred) | ❌ **fail (scanner never spawns)** | RPC call `openhuman.memory_recall_memories {"namespace":"slack-web:29da7de6...","limit":20}` returns `{memories:[]}`. Log shows: `[webview-accounts] slack ScannerRegistry not in app state` immediately after Slack account opens. Zero `memory_doc_ingest` events ever fired. **Root cause**: `app/src-tauri/src/lib.rs:998` does `manage(std::sync::Arc::new(slack_scanner::ScannerRegistry::new()))` β€” but `slack_scanner::ScannerRegistry::new()` already returns `Arc` (`mod.rs:744-746`). Result: managed state is `Arc>`. Lookup at `webview_accounts/mod.rs:1751` is `try_state::>()` β†’ returns None β†’ scanner never spawns. WhatsApp/Discord/Telegram lines (997/999/1000) correctly use the bare `ScannerRegistry::new()` (no extra Arc wrap). Slack alone is double-wrapped. | **ONE-LINE FIX**. Change `lib.rs:998` from `.manage(std::sync::Arc::new(slack_scanner::ScannerRegistry::new()))` to `.manage(slack_scanner::ScannerRegistry::new())`. Post-fix: confirmed scanner ingests one doc per channel (`emit_and_persist` at `mod.rs:230` explicitly groups by `channel_id` only β€” no per-day split); the `(channel_id, day)` shape from the original spec remains a deferred follow-up rather than a regression. Reactions/threads extraction gaps still apply but blocked by getting scanner running first. | | 8 | **DOM snapshot** β€” fast-tick captures unread badges + channel list | βœ… pass | Sidebar matches web Slack: channel list (general, random, team-backend/frontend/product, notify-frontend-gi/se, External connections), DMs (Sanil 1, Alan, Aniketh, Cyrus, Mega Mind, Shanu, Steven), DMs+Activity nav badges (1 each), per-DM unread badge on Sanil (1). | DOM extraction working as designed. | @@ -93,8 +93,8 @@ These were confirmed by static read of `main` before smoke. The smoke run will v ## Out of scope (separate child issues recommended) -- **Huddle popup blank** β€” root cause refined after [#1074 Phase 0 CDP probe](https://github.com/tinyhumansai/openhuman/issues/1074). Slack uses `popup.document.write(html)` to inject huddle UI into the same `about:blank` document, NOT `popup.location = url` β€” so there is no URL signal to intercept. The bug is CEF's paint/compositor lifecycle on same-document popups (popup paints first frame correctly, then surface goes white). Tracked in **[#1079](https://github.com/tinyhumansai/openhuman/issues/1079)**. Pre-conditions for huddle audio/video are now in place (`Browser.grantPermissions` for `audioCapture`/`videoCapture`/`displayCapture` on `app.slack.com`, see Fixes shipped in this PR row E); huddle becomes functional immediately once the CEF paint bug clears. -- **CEF parent webview blanks after huddle interaction + tab switch** β€” likely shares root cause with the huddle popup; verify after that lands. +- **Huddle popup blank** β€” **resolved 2026-05-04**. Initial hypothesis (CEF same-document popup paint runtime gap) was wrong; real cause was tauri-cef's blank-page reload guard firing on popup browsers with the opener's URL, wiping Slack's `document.write` content after 1s. Fixed in [tinyhumansai/tauri-cef#12](https://github.com/tinyhumansai/tauri-cef/pull/12) (skip guard when `is_popup()`); openhuman picks up the fix via the submodule pin bump in this PR (closes [#1079](https://github.com/tinyhumansai/openhuman/issues/1079)). Combined with the earlier #1074 row E perms grant, Slack huddles are now end-to-end functional in the embedded webview. +- **CEF parent webview blanks after huddle interaction + tab switch** β€” tracked as [#1075](https://github.com/tinyhumansai/openhuman/issues/1075). Pre-fix theory was that the popup's spurious `frame.load_url(opener_url)` clobbered the parent's loading state, so #1079 may resolve this as a side-effect; needs re-verification on a build with the submodule bump from this PR. If still broken post-#1079 it becomes its own track focused on `host->Invalidate(PET_VIEW)` / `WasResized()` on parent reveal. - **`pnpm dev:app` `restart_app` regression on PR #1007** β€” orthogonal bug, broader than Slack; affects all dev:app sessions. Requires instrumenting `getActiveUserIdFromCore()` to confirm whether it returns `null` in dev mode and triggers the seed/identity mismatch. - **In-app Slack logout removes the OpenHuman sidebar tile but cookies persist** β€” UX inconsistency (re-add = already signed in). Decide between (a) keep the tile after in-app logout, or (b) purge the per-account CEF profile on the logout signal. - **Pre-audit hypotheses dropped after smoke**: `slackb.com` is the working CDN host (spec's `slack-imgs.com`/`slack-files.com` were stale) β€” DO NOT change `webview_accounts/mod.rs:101`; reactions + threads + per-channel mute + per-day grouping all dropped or deferred (gated on confirming actual gaps after Bug A+D made the scanner usable).