From 9c83f7ecd99cbb3147f1070812f410640fb4e559 Mon Sep 17 00:00:00 2001 From: Steven Enamakel Date: Sun, 29 Mar 2026 23:04:55 -0700 Subject: [PATCH] Refactor release workflow to streamline CLI artifact resolution - Removed the standalone core CLI binary build step from the release workflow to simplify the process. - Introduced a new step to resolve the CLI artifact path, enhancing clarity and maintainability in the workflow. - Updated environment variable handling for better integration with the build process, ensuring consistent artifact management. --- .github/workflows/release.yml | 33 ++++++++++++--------------------- 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index fb125c826..c318b5076 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -386,6 +386,18 @@ jobs: CORE_BIN_NAME: ${{ steps.core-paths.outputs.core_bin_name }} SIDECAR_BASE: ${{ steps.core-paths.outputs.sidecar_base }} + - name: Resolve standalone core CLI artifact path + id: cli-paths + shell: bash + run: | + BASE_DIR="$CORE_TARGET_DIR" + echo "base_dir=$BASE_DIR" >> "$GITHUB_OUTPUT" + echo "cli_path=$BASE_DIR/$CORE_BIN_NAME" >> "$GITHUB_OUTPUT" + env: + MATRIX_TARGET: ${{ matrix.settings.target }} + CORE_TARGET_DIR: ${{ steps.core-paths.outputs.core_target_dir }} + CORE_BIN_NAME: ${{ steps.core-paths.outputs.core_bin_name }} + - name: Build, package and upload to release uses: tauri-apps/tauri-action@v0.6.2 id: tauri-build @@ -434,27 +446,6 @@ jobs: exit 1 fi - - name: Build standalone core CLI binary - shell: bash - run: | - cargo build --manifest-path "$CORE_MANIFEST" --release --target "$MATRIX_TARGET" --bin "$CORE_BIN_NAME" - env: - MATRIX_TARGET: ${{ matrix.settings.target }} - CORE_MANIFEST: ${{ steps.core-paths.outputs.core_manifest }} - CORE_BIN_NAME: ${{ steps.core-paths.outputs.core_bin_name }} - - - name: Resolve standalone core CLI artifact path - id: cli-paths - shell: bash - run: | - BASE_DIR="$CORE_TARGET_DIR" - echo "base_dir=$BASE_DIR" >> "$GITHUB_OUTPUT" - echo "cli_path=$BASE_DIR/$CORE_BIN_NAME" >> "$GITHUB_OUTPUT" - env: - MATRIX_TARGET: ${{ matrix.settings.target }} - CORE_TARGET_DIR: ${{ steps.core-paths.outputs.core_target_dir }} - CORE_BIN_NAME: ${{ steps.core-paths.outputs.core_bin_name }} - - name: Upload standalone CLI artifacts uses: actions/upload-artifact@v4 with: