admin/gbrain
1
0
Fork 0
mirror of https://github.com/garrytan/gbrain.git synced 2026-07-30 03:12:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(facts): pin embedding dims in facts-engine — kill the shard-order 1280/1536 flake

Browse Source 
facts-engine.test.ts hardcodes Float32Array(1536) vectors (vec()) but lets
initSchema size its vector columns from process-global gateway state
(getEmbeddingDimensions(), default 1280). Whether the file passes depends
on which test files run before it in the shard; adding
test/frontmatter-validate-slug-565.test.ts reshuffled the weight-packed
shards and tripped it on this PR's CI (test (1):
'expected 1280 dimensions, not 1536' in findCandidateDuplicates cosine
ordering).

Same fix + rationale as doctor-hidden-by-search-policy.test.ts (#2801),
engine-find-trajectory.test.ts and cosine-rescore-column.test.ts:
configureGateway(1536) in beforeAll BEFORE initSchema, resetGateway in
afterAll.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-07-24 11:02:00 -07:00
co-authored by Claude Fable 5
parent c18cee8c87
commit 1b6606c7bb
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/facts-engine.test.ts
+16
View File
@@ -13,10 +13,25 @@
import { describe, test, expect, beforeAll, afterAll } from 'bun:test';
import { PGLiteEngine } from '../src/core/pglite-engine.ts';
import { configureGateway, resetGateway } from '../src/core/ai/gateway.ts';
let engine: PGLiteEngine;
beforeAll(async () => {
// Pin the embedding dim to 1536 BEFORE initSchema. vec() hardcodes
// Float32Array(1536), but initSchema sizes vector columns from
// process-global gateway state (getEmbeddingDimensions(), default 1280).
// Whether this file passes therefore depends on which test files run
// before it in the shard; adding test files to the repo reshuffles the
// weight-packed shards, so unrelated PRs trip it ("expected 1280
// dimensions, not 1536"). Same fix + rationale as
// doctor-hidden-by-search-policy.test.ts (#2801),
// engine-find-trajectory.test.ts and cosine-rescore-column.test.ts.
configureGateway({
embedding_model: 'openai:text-embedding-3-large',
embedding_dimensions: 1536,
env: { OPENAI_API_KEY: 'sk-test-facts-engine' },
});
engine = new PGLiteEngine();
await engine.connect({});
await engine.initSchema();
@@ -24,6 +39,7 @@ beforeAll(async () => {
afterAll(async () => {
await engine.disconnect();
resetGateway();
});
const vec = (...vals: number[]): Float32Array => {