test,fix: align stale assertions with generalized advisory + advisor resolver triggers (#2180)

- post-install-advisory.test.ts: install→scaffold wording (the install verb was
  removed); restore two-column in book-mirror copy; drop the removed skillpack-list line.
- RESOLVER.md: gbrain-advisor trigger now fuzzy-matches a declared frontmatter
  trigger (resolver round-trip D5/C).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-06-16 22:09:35 -07:00
co-authored by Claude Opus 4.8
parent e41215b2d3
commit 2b444e4fc2
3 changed files with 8 additions and 8 deletions
+1 -1
View File
@@ -57,7 +57,7 @@ This is the dispatcher. Skills are the implementation. **Read the skill file bef
| Morning prep, meeting context, day planning | `skills/daily-task-prep/SKILL.md` |
| Daily briefing, "what's happening today" | `skills/briefing/SKILL.md` |
| Cron scheduling, quiet hours, job staggering | `skills/cron-scheduler/SKILL.md` |
| "How do I get more out of gbrain", "is my brain set up right", "weekly brain checkup", "advise me on my brain", gbrain advisor | `skills/gbrain-advisor/SKILL.md` |
| "get more out of gbrain", "is my brain set up right", "weekly brain checkup", "advise me on my brain", "gbrain advisor" | `skills/gbrain-advisor/SKILL.md` |
| Save or load reports | `skills/reports/SKILL.md` |
| "Create a skill", "improve this skill" | `skills/skill-creator/SKILL.md` |
| "Skillify this", "is this a skill?", "make this proper" | `skills/skillify/SKILL.md` |
+1 -1
View File
@@ -19,7 +19,7 @@ export const RECOMMENDED: RecommendedSkill[] = [
{
slug: 'book-mirror',
description:
'FLAGSHIP. Take any book (EPUB/PDF), produce a personalized chapter-by-chapter analysis that maps every idea to your life using brain context.',
'FLAGSHIP. Take any book (EPUB/PDF), produce a personalized two-column chapter-by-chapter analysis that maps every idea to your life using brain context.',
},
{
slug: 'article-enrichment',
+6 -6
View File
@@ -113,7 +113,7 @@ describe('buildAdvisory — partial-install path', () => {
expect(advisory).toContain('book-mirror');
expect(advisory).not.toContain('article-enrichment');
expect(advisory).not.toContain('strategic-reading');
expect(advisory).toContain('gbrain skillpack install book-mirror');
expect(advisory).toContain('gbrain skillpack scaffold book-mirror');
});
it('uses --all command when ALL recommended are missing (fresh workspace)', () => {
@@ -125,7 +125,7 @@ describe('buildAdvisory — partial-install path', () => {
targetSkillsDir: skillsDir,
});
expect(advisory).not.toBeNull();
expect(advisory).toContain('gbrain skillpack install --all');
expect(advisory).toContain('gbrain skillpack scaffold --all');
expect(advisory).toContain('book-mirror');
expect(advisory).toContain('article-enrichment');
expect(advisory).toContain('strategic-reading');
@@ -167,7 +167,7 @@ describe('buildAdvisory — agent-readable framing', () => {
})!;
expect(advisory).toContain('ACTION FOR THE AGENT');
expect(advisory).toContain('Ask the user');
expect(advisory).toContain('Do NOT install without asking');
expect(advisory).toContain('Do NOT scaffold without asking');
expect(advisory).toContain('user owns this decision');
});
@@ -213,8 +213,8 @@ describe('buildAdvisory — agent-readable framing', () => {
targetWorkspace: workspace,
targetSkillsDir: skillsDir,
})!;
expect(advisory).toContain('gbrain skillpack install --all');
expect(advisory).toContain('gbrain skillpack list');
expect(advisory).toContain('gbrain skillpack scaffold --all');
expect(advisory).toContain('ACTION FOR THE AGENT');
});
});
@@ -228,6 +228,6 @@ describe('buildAdvisory — no workspace detected', () => {
});
expect(advisory).not.toBeNull();
// No workspace -> empty installed set -> all recommended treated as missing.
expect(advisory).toContain('gbrain skillpack install --all');
expect(advisory).toContain('gbrain skillpack scaffold --all');
});
});