admin/gbrain
1
0
Fork 0
mirror of https://github.com/garrytan/gbrain.git synced 2026-07-30 19:49:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: use withEnv() in hybrid-recency-config test (check-test-isolation R1)

Browse Source 
The test-isolation lint (shipped after #2386 was written) rejects raw
process.env mutation in non-serial test files. Wrap the
GBRAIN_RECENCY_DECAY overrides in withEnv() from test/helpers/with-env.ts;
assertions unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-07-24 11:01:47 -07:00
co-authored by Claude Fable 5
parent bf23a84b5b
commit 9591ca5195
1 changed files with 19 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/hybrid-recency-config.test.ts
+19 -20
View File
@@ -9,7 +9,8 @@
* assert the boost the hybrid path applies reflects that config.
*/
import { describe, test, expect, afterEach } from 'bun:test';
import { describe, test, expect } from 'bun:test';
import { withEnv } from './helpers/with-env.ts';
import { runPostFusionStages } from '../src/core/search/hybrid.ts';
import type { SearchResult } from '../src/core/types.ts';
import type { BrainEngine } from '../src/core/engine.ts';
@@ -59,38 +60,36 @@ function makeResult(slug: string): SearchResult {
const RECENCY_ONLY = { applyBacklinks: false, salience: 'off', recency: 'on' } as const;
afterEach(() => {
delete process.env.GBRAIN_RECENCY_DECAY;
});
describe('runPostFusionStages recency config wiring', () => {
test('GBRAIN_RECENCY_DECAY evergreen override suppresses the boost on the hybrid path', async () => {
// `custom/` is absent from DEFAULT_RECENCY_DECAY. Without honoring the env,
// the slug falls to DEFAULT_FALLBACK (90d/0.5) and gets boosted. Declaring
// it evergreen (0/0) must short-circuit the boost — proof the env reached
// the hybrid stage.
process.env.GBRAIN_RECENCY_DECAY = 'custom/:0:0';
const results = [makeResult('custom/foo')];
await runPostFusionStages(makeEngine(30), results, RECENCY_ONLY);
await withEnv({ GBRAIN_RECENCY_DECAY: 'custom/:0:0' }, async () => {
const results = [makeResult('custom/foo')];
await runPostFusionStages(makeEngine(30), results, RECENCY_ONLY);
expect(results[0].recency_boost).toBeUndefined();
expect(results[0].score).toBe(1.0);
expect(results[0].recency_boost).toBeUndefined();
expect(results[0].score).toBe(1.0);
});
});
test('GBRAIN_RECENCY_DECAY custom coefficient/halflife flows into the applied factor', async () => {
// Pin an aggressive config for a prefix the defaults don't carry. The
// applied factor must match the custom config, not DEFAULT_FALLBACK.
const halflife = 14, coefficient = 2.0, daysOld = 14;
process.env.GBRAIN_RECENCY_DECAY = `custom/:${halflife}:${coefficient}`;
const results = [makeResult('custom/foo')];
await runPostFusionStages(makeEngine(daysOld), results, RECENCY_ONLY);
await withEnv({ GBRAIN_RECENCY_DECAY: `custom/:${halflife}:${coefficient}` }, async () => {
const results = [makeResult('custom/foo')];
await runPostFusionStages(makeEngine(daysOld), results, RECENCY_ONLY);
// factor = 1 + coefficient * halflife / (halflife + daysOld); at daysOld==halflife → 1 + coefficient/2.
const expected = 1 + coefficient * halflife / (halflife + daysOld);
const fallbackFactor = 1 + DEFAULT_FALLBACK_COEFF * DEFAULT_FALLBACK_HL / (DEFAULT_FALLBACK_HL + daysOld);
expect(results[0].recency_boost).toBeCloseTo(expected, 4);
// Sanity: the custom factor is distinguishable from the fallback the
// unpatched hybrid path would have applied.
expect(Math.abs(expected - fallbackFactor)).toBeGreaterThan(0.1);
// factor = 1 + coefficient * halflife / (halflife + daysOld); at daysOld==halflife → 1 + coefficient/2.
const expected = 1 + coefficient * halflife / (halflife + daysOld);
const fallbackFactor = 1 + DEFAULT_FALLBACK_COEFF * DEFAULT_FALLBACK_HL / (DEFAULT_FALLBACK_HL + daysOld);
expect(results[0].recency_boost).toBeCloseTo(expected, 4);
// Sanity: the custom factor is distinguishable from the fallback the
// unpatched hybrid path would have applied.
expect(Math.abs(expected - fallbackFactor)).toBeGreaterThan(0.1);
});
});
});