admin/gbrain
1
0
Fork 0
mirror of https://github.com/garrytan/gbrain.git synced 2026-07-27 22:15:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(eval): use withEnv() for ANTHROPIC_API_KEY mutation in longmemeval client test

Browse Source 
check:test-isolation rule R1 flagged the manual process.env save/restore
in test/eval-longmemeval-client.test.ts. Wrap the gateway-routing test in
withEnv() (the canonical pattern) so restore is try/finally-safe too.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-07-22 10:52:28 -07:00
co-authored by Claude Fable 5
parent 140509be75
commit f45d4a6345
1 changed files with 30 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/eval-longmemeval-client.test.ts
+30 -32
View File
@@ -18,6 +18,7 @@ import {
__setChatTransportForTests,
} from '../src/core/ai/gateway.ts';
import type { ChatOpts, ChatResult } from '../src/core/ai/gateway.ts';
import { withEnv } from './helpers/with-env.ts';
afterAll(() => {
__setChatTransportForTests(null);
@@ -50,38 +51,35 @@ describe('buildLLMClient (#2099)', () => {
const seen: string[] = [];
// probeChatModel's Anthropic branch reads process.env (hasAnthropicKey),
// not the gateway cfg.env — set both so the test is hermetic on CI.
const priorKey = process.env.ANTHROPIC_API_KEY;
process.env.ANTHROPIC_API_KEY = 'sk-ant-test';
configureGateway({
chat_model: 'anthropic:claude-sonnet-4-6',
env: { ANTHROPIC_API_KEY: 'sk-ant-test' },
} as never);
__setChatTransportForTests(async (opts: ChatOpts): Promise<ChatResult> => {
seen.push(opts.model ?? '<none>');
return {
text: 'stubbed answer',
blocks: [],
stopReason: 'end',
usage: { input_tokens: 1, output_tokens: 1, cache_read_tokens: 0, cache_creation_tokens: 0 },
model: opts.model ?? '',
providerId: 'anthropic',
} as ChatResult;
await withEnv({ ANTHROPIC_API_KEY: 'sk-ant-test' }, async () => {
configureGateway({
chat_model: 'anthropic:claude-sonnet-4-6',
env: { ANTHROPIC_API_KEY: 'sk-ant-test' },
} as never);
__setChatTransportForTests(async (opts: ChatOpts): Promise<ChatResult> => {
seen.push(opts.model ?? '<none>');
return {
text: 'stubbed answer',
blocks: [],
stopReason: 'end',
usage: { input_tokens: 1, output_tokens: 1, cache_read_tokens: 0, cache_creation_tokens: 0 },
model: opts.model ?? '',
providerId: 'anthropic',
} as ChatResult;
});
const client = await buildLLMClient('anthropic:claude-sonnet-4-6', false);
const msg = await client.create({
model: 'anthropic:claude-sonnet-4-6',
max_tokens: 32,
messages: [{ role: 'user', content: 'q' }],
});
// Pre-#2099 this path constructed `new Anthropic()` and sent the
// prefixed id verbatim → HTTP 404. Now the gateway serves it.
expect(seen).toEqual(['anthropic:claude-sonnet-4-6']);
const first = msg.content[0];
expect(first && first.type === 'text' ? first.text : '').toBe('stubbed answer');
});
const client = await buildLLMClient('anthropic:claude-sonnet-4-6', false);
const msg = await client.create({
model: 'anthropic:claude-sonnet-4-6',
max_tokens: 32,
messages: [{ role: 'user', content: 'q' }],
});
// Pre-#2099 this path constructed `new Anthropic()` and sent the
// prefixed id verbatim → HTTP 404. Now the gateway serves it.
expect(seen).toEqual(['anthropic:claude-sonnet-4-6']);
const first = msg.content[0];
expect(first && first.type === 'text' ? first.text : '').toBe('stubbed answer');
if (priorKey === undefined) delete process.env.ANTHROPIC_API_KEY;
else process.env.ANTHROPIC_API_KEY = priorKey;
});
});