mirror of
https://github.com/garrytan/gbrain.git
synced 2026-07-30 11:22:34 +00:00
* feat: agent-voice reference skillpack (Mars + Venus) + copy-into-host-repo install paradigm Ships a new skillpack paradigm: gbrain holds the REFERENCE content; `gbrain integrations install agent-voice --target <repo>` COPIES it into the operator's host agent repo where it becomes user-owned and mutable. Future refresh is diff-and-propose against per-file SHA-256 hashes from .gbrain-source.json, not blind overwrite. What ships: - recipes/agent-voice.md entrypoint + recipes/agent-voice/ bundle - Two voice personas (Mars dual-mode SOLO/DEMO, Venus executive assistant) with PII / private-agent-name / hardcoded-path scrubbed out - WebRTC-first browser client (call.html) with ?test=1 gated instrumentation and Web Audio API tee -> MediaRecorder capture for E2E roundtrip testing - Read-only tool router (D14-A allow-list: search, query, get_page, list_pages, find_experts, get_recent_salience, get_recent_transcripts, read_article). Write ops permanently denylisted; opt-in via local override - Persona-aware prompt builder with identity-first composition + Unicode sanitization for OpenAI Realtime API safety - Upstream-error classifier (HTTP 429/500/503 -> soft-fail, plumbing -> hard) - Three SKILL.md skills (voice-persona-mars, voice-persona-venus, voice-post-call) with routing-eval.jsonl fixtures - 99 host-side tests (vitest-compatible, runs in bun) covering registry, prompt-shape privacy guards, tool allow-list, upstream classifier - install/manifest.json + refresh-algorithm.md + post-install-hint.md Privacy infrastructure: - scripts/check-no-pii-in-agent-voice.sh wired into bun run verify Shape regex (phone/email/SSN/JWT/bearer/credit-card) + path patterns + $AGENT_VOICE_PII_BLOCKLIST env-driven name blocklist - scripts/import-from-upstream.sh + scripts/upstream-scrub-table.txt Deterministic refresh from upstream voice-agent source. Placeholder- driven (envsubst-expanded at run time) so no private names land in checked-in files - recipes/agent-voice/code/lib/personas/private-name-blocklist.json Single source of truth for the regex contract (shape categories + path patterns + env-var contract for operator-specific names) src/ surface: - src/commands/integrations.ts gains `install <recipe-id>` subcommand with install_kind: 'local-managed' | 'copy-into-host-repo' discriminator. Path-traversal hardening (rejects '..', absolute paths, symlink escapes). Refuses target == gbrain itself, missing .git, existing files (without --overwrite). Writes .gbrain-source.json with per-file SHA-256. Appends resolver rows to host repo's RESOLVER.md or AGENTS.md. - test/integrations-install.test.ts: 11 cases (happy path, manifest shape, no upstream_repo field per D11-A, resolver appending, file modes, refusal cases, dry-run) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: bump version and changelog (v0.36.0.0) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(privacy): scrub literal private agent names from prompt-shape tests + guard script The prompt-shape tests carried regex patterns naming the literal banned terms (Garry/Steph/Garrison/Solomon/Herbert/Wintermute) inline. CLAUDE.md's "never use Wintermute in any public artifact" applies to test source files too. Master's check-privacy.sh correctly caught this. Replaced with env-driven check that reads AGENT_VOICE_PII_BLOCKLIST (the single source of truth from private-name-blocklist.json). Same enforcement guarantee via the env var, zero literal names in shipped source. Also scrubbed the literal /data/.openclaw/ from the guard script's comment and the literal 'tell_wintermute' from the venus write-tools test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat: ship all v0.36.0.0 deferred items in this PR (E2E + evals + pipeline + refresh + multilingual + twilio deprecation) Closes the "deferred to follow-up" section of the v0.36.0.0 CHANGELOG. E2E tests + harness (env-gated): - tests/e2e/voice-roundtrip.test.mjs — spawns server, drives puppeteer + fake-audio, three-tier assertions (CONNECTION hard, NON-SILENT hard, SEMANTIC soft via Whisper + LLM judge). Upstream errors (429/500/503, WS 1011/1013) soft-fail via lib/upstream-classifier.mjs. - tests/e2e/voice-full-flow.test.mjs — wraps openclaw doing the install, then runs the roundtrip. Friction-discovery flavor, NOT a ship gate. - tests/e2e/lib/browser-audio.mjs — puppeteer + fake-audio harness; reads window._gbrainTest namespace; PCM RMS-variance helper. - tests/e2e/lib/whisper-judge.mjs — Whisper transcription + LLM-judge for SEMANTIC tier. - tests/e2e/audio-fixtures/utterance-{add,joke,brain-query}.wav — 16kHz mono WAV via `say` + ffmpeg, committed for reproducibility. - test/fixtures/claw-test-scenarios/voice-agent-install/{BRIEF.md, scenario.json, expected.json} — labeled BENCHMARK_FRICTION, blocks_ship=false. LLM-judge persona evals + synthetic canonical baselines: - tests/evals/judge.mjs — gateway-routed 3-model (Claude + GPT + Gemini) harness with 4-strategy JSON repair + 2/3-quorum aggregation (per the v0.27.x cross-modal pattern). Pass criterion: every axis mean ≥7 AND no model <5. - tests/evals/fixtures/{mars-solo,mars-demo,venus,persona-routing,mars-multilingual}.jsonl — 5 fixture sets covering all axes. - tests/evals/{mars-eval,venus-eval,mars-multilingual-eval,persona-routing-eval}.mjs — per-axis drivers. - tests/evals/baseline-runs/canonical/*.json — agent-authored synthetic exemplars (PII-impossible by construction; demonstrate expected pass shape; never overwrite with live model output). - tests/evals/baseline-runs/.gitignore — live receipts excluded. DIY pipeline (Option B): - code/pipeline.mjs — streaming STT (Deepgram nova-2) + LLM (Claude Sonnet 4.6 streaming SSE with sentence-boundary TTS dispatch) + TTS (Cartesia primary, OpenAI TTS fallback). 20-turn history cap, exponential-backoff reconnects, 25s keepalives, VAD presets (quiet/normal/noisy/very_noisy), barge-in via STT speechStart → LLM interrupt. Modular adapters for swapping providers. --refresh mode (D3-A diff-and-propose): - src/commands/integrations.ts: refreshRecipeIntoHostRepo() + classifyForRefresh() implementing the five states from refresh-algorithm.md (unchanged-identical, unchanged-stale, locally-modified, source-deleted, host-deleted, new-in-manifest). Transaction journal at .gbrain-source.refresh.log. Default policy: preserve operator's local edits (keep-mine); --auto take-theirs to overwrite; --dry-run for preview. - test/integrations-install.test.ts: 7 new test cases pinning each classification state + default-preserve behavior + take-theirs overwrite + transaction journal + refusal on uninstalled target. Mars multilingual restore: - code/lib/personas/mars.mjs: explicit cross-lingual rule (Mandarin, Spanish, French, Japanese, Korean default to English but follow the speaker). Voice (Orus) supports the languages natively. - tests/unit/mars-prompt-shape.test.mjs: assertion flipped from "MUST NOT claim multilingual" to "declares cross-lingual capability with English bias." - tests/evals/fixtures/mars-multilingual.jsonl: 5 fixtures across Mandarin/Spanish/Japanese/French + explicit switch-back, pinned by mars-multilingual-eval.mjs. Twilio recipe deprecation: - recipes/twilio-voice-brain.md: deprecation banner pointing at agent-voice.md. Frontmatter version bumped to 0.8.2. Will be removed in v0.37. Verify: bun run verify clean, 6736+ unit tests pass, 18/18 install+refresh tests pass, 96/98 host-side persona/tool/classifier tests pass (2 skipped env-gated). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs: update CHANGELOG — all v0.36.0.0 deferred items now shipped in this PR Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: rebump version v0.36.0.0 → v0.37.0.0 Captures the wave-1 + wave-2 scope at the v0.37 slot. The bump reflects the size of what this PR ships: copy-into-host-repo install paradigm (new install_kind discriminator + new install/refresh subcommand) + Mars/Venus voice agent reference + 5,500+ LOC of vendored scrubbed code + 4 LLM-judge eval suites + 2 env-gated E2E test suites + DIY Option B pipeline + 18-case install subcommand test coverage. A minor bump felt too small. Side fix: privacy guard caught two stale literal "wintermute" and "/data/.openclaw/" references in wave-2 files (voice-full-flow.test.mjs comment, expected.json blocklist payload). Both replaced with env-driven references to $AGENT_VOICE_PII_BLOCKLIST matching the D15-A pattern from the original review. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: rebump v0.37.0.0 → v0.40.0.0 Jumps past the v0.37/v0.38/v0.39 slots master might claim in subsequent PRs. The wave's scope (copy-into-host-repo skillpack paradigm + agent-voice + install/refresh + LLM-judge evals + DIY pipeline + Mars multilingual) justifies a larger version arithmetic step. Files bumped: - VERSION 0.37.0.0 → 0.40.0.0 - package.json 0.37.0.0 → 0.40.0.0 - CHANGELOG.md header + "To take advantage of v0.40.0.0" block - recipes/twilio-voice-brain.md deprecation banner (now "removed in v0.41") - recipes/agent-voice/tests/evals/mars-multilingual-eval.mjs comment Left alone: master's pre-existing "v0.37+" roadmap labels in src/core/calibration/*, src/core/cycle/*, DESIGN.md, CLAUDE.md, etc. Those are master's author-intent references to "the next planned release" relative to master's frame at the time — rewriting them just to keep numbering consistent would overreach. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
149 lines
6.1 KiB
JavaScript
149 lines
6.1 KiB
JavaScript
/**
|
|
* upstream-classifier.mjs — failure-source classifier for the voice-agent E2E.
|
|
*
|
|
* D4-A invariant: the full-flow E2E (~$1-2/run) must NOT block a ship when
|
|
* the failure is caused by external upstream services (OpenAI Realtime API,
|
|
* Anthropic, browser media stack glitches). It MUST block on real plumbing
|
|
* bugs in the copied voice-agent code.
|
|
*
|
|
* `classifyFailure(err)` returns one of:
|
|
* - 'upstream' — external service is degraded; soft-fail, log to friction
|
|
* - 'plumbing' — our copied code is broken; hard-fail
|
|
* - 'semantic' — LLM-judge returned a fail verdict; soft-fail (recorded)
|
|
* - 'unknown' — can't classify confidently; treat as plumbing (fail-loud)
|
|
*
|
|
* Calibration: this classifier is conservative — anything not clearly
|
|
* upstream is plumbing. False positive (classifying a real bug as upstream)
|
|
* is the worst outcome (silently passes broken code); false negative
|
|
* (classifying a transient outage as plumbing) is recoverable (re-run).
|
|
*/
|
|
|
|
/**
|
|
* Classify a failure object. `err` may be:
|
|
* - a thrown Error with .status / .statusCode (for HTTP failures)
|
|
* - a structured object with .type / .code / .reason
|
|
* - an object with .closeCode (for WebSocket close codes)
|
|
* - a plain Error with a message string
|
|
*
|
|
* The classifier mostly inspects fields; it only falls back to message
|
|
* matching as a last resort.
|
|
*
|
|
* @param {Error|object} err
|
|
* @returns {'upstream'|'plumbing'|'semantic'|'unknown'}
|
|
*/
|
|
export function classifyFailure(err) {
|
|
if (err == null) return 'unknown';
|
|
|
|
// Explicit type tag wins. E.g. {type: 'semantic_judge_fail'}.
|
|
if (err.type === 'semantic' || err.type === 'semantic_judge_fail') return 'semantic';
|
|
if (err.type === 'upstream') return 'upstream';
|
|
if (err.type === 'plumbing') return 'plumbing';
|
|
|
|
// HTTP status (e.g. fetch() Response or axios-shaped error).
|
|
const status = err.status ?? err.statusCode ?? err.response?.status;
|
|
if (typeof status === 'number') {
|
|
// 429 (rate limit), 500/502/503 (server-side outage) → upstream.
|
|
if (status === 429 || status === 500 || status === 502 || status === 503 || status === 504) {
|
|
return 'upstream';
|
|
}
|
|
// 401/403 → auth problem, our config issue, plumbing.
|
|
if (status === 401 || status === 403) return 'plumbing';
|
|
// 400 — usually our payload shape is wrong; plumbing.
|
|
if (status === 400) return 'plumbing';
|
|
}
|
|
|
|
// WebSocket close codes. 1011 = server error, 1013 = try again later,
|
|
// 1006 = abnormal closure (could be either; lean upstream since it's
|
|
// usually a network-layer issue we can't fix).
|
|
const closeCode = err.closeCode ?? err.code;
|
|
if (typeof closeCode === 'number') {
|
|
if (closeCode === 1011 || closeCode === 1013) return 'upstream';
|
|
if (closeCode === 1006) return 'upstream';
|
|
// 1000 (normal) shouldn't be classified as failure at all.
|
|
}
|
|
|
|
// Symbolic counter checks for plumbing: explicit zero-frame markers.
|
|
if (err.audioSendCount === 0) return 'plumbing';
|
|
if (err.audioPlayCount === 0 && (err.audioSendCount ?? 0) > 0) return 'plumbing';
|
|
if (err.iceFailure === true) return 'plumbing';
|
|
if (err.healthCheckFailed === true) return 'plumbing';
|
|
|
|
// Reason field (some libs use this).
|
|
const reason = err.reason || err.code || '';
|
|
if (typeof reason === 'string') {
|
|
const r = reason.toLowerCase();
|
|
if (r.includes('rate') && r.includes('limit')) return 'upstream';
|
|
if (r.includes('upstream')) return 'upstream';
|
|
if (r.includes('degraded')) return 'upstream';
|
|
if (r.includes('timeout') && r.includes('openai')) return 'upstream';
|
|
if (r.includes('timeout') && r.includes('anthropic')) return 'upstream';
|
|
if (r === 'semantic_fail' || r === 'judge_fail') return 'semantic';
|
|
}
|
|
|
|
// Last-resort message inspection. Only match strings that are clearly
|
|
// upstream — anything ambiguous falls through to 'unknown' → caller
|
|
// treats as plumbing.
|
|
const msg = (err.message || String(err) || '').toLowerCase();
|
|
if (
|
|
msg.includes('api.openai.com') &&
|
|
(msg.includes('429') || msg.includes('500') || msg.includes('503'))
|
|
) return 'upstream';
|
|
if (msg.includes('api.anthropic.com') && msg.includes('rate_limit')) return 'upstream';
|
|
if (msg.includes('econnreset') || msg.includes('econnrefused')) {
|
|
// ECONNRESET to api.openai.com is upstream; to localhost is plumbing.
|
|
if (msg.includes('openai') || msg.includes('anthropic')) return 'upstream';
|
|
return 'plumbing';
|
|
}
|
|
|
|
return 'unknown';
|
|
}
|
|
|
|
/**
|
|
* Verdict helper. Given a classification, return the recommended action:
|
|
* - 'soft_fail' — exit 0, log to friction channel, do not block ship.
|
|
* - 'hard_fail' — exit 1, real bug.
|
|
*
|
|
* `unknown` maps to `hard_fail` so we err on the side of catching bugs.
|
|
*/
|
|
export function verdictFor(kind) {
|
|
switch (kind) {
|
|
case 'upstream': return 'soft_fail';
|
|
case 'semantic': return 'soft_fail';
|
|
case 'plumbing': return 'hard_fail';
|
|
case 'unknown': return 'hard_fail';
|
|
default: return 'hard_fail';
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Pre-flight check: probe the OpenAI status page. If it reports anything
|
|
* other than 'none' (the operational status), return 'upstream' immediately
|
|
* before the test even tries to connect — saves an expensive run on a known
|
|
* outage day.
|
|
*
|
|
* Returns either {status: 'ok'} or {status: 'degraded', detail: <text>}.
|
|
* Never throws. Treats any fetch failure as 'ok' (don't false-degrade on
|
|
* a status-page outage that isn't a real Realtime outage).
|
|
*/
|
|
export async function preflightOpenAIStatus({ fetch = globalThis.fetch, timeoutMs = 3000 } = {}) {
|
|
if (typeof fetch !== 'function') return { status: 'ok' };
|
|
const ctrl = new AbortController();
|
|
const timer = setTimeout(() => ctrl.abort(), timeoutMs);
|
|
try {
|
|
const res = await fetch('https://status.openai.com/api/v2/status.json', {
|
|
signal: ctrl.signal,
|
|
});
|
|
if (!res.ok) return { status: 'ok' };
|
|
const body = await res.json();
|
|
const indicator = body?.status?.indicator;
|
|
if (indicator && indicator !== 'none') {
|
|
return { status: 'degraded', detail: body.status.description || indicator };
|
|
}
|
|
return { status: 'ok' };
|
|
} catch {
|
|
return { status: 'ok' };
|
|
} finally {
|
|
clearTimeout(timer);
|
|
}
|
|
}
|