mirror of
https://github.com/garrytan/gbrain.git
synced 2026-07-28 06:23:01 +00:00
* feat(progress): step 1 - shared ProgressReporter + CliOptions Adds the foundation for v0.14.2's bulk-action progress streaming work: - src/core/progress.ts: dependency-free reporter with auto/human/json/quiet modes, TTY-aware rendering, time+item rate gating, heartbeat helper for slow single queries, dot-composed child phases, EPIPE defense (both sync throw and async 'error' event), and a singleton module-level signal coordinator so SIGINT/SIGTERM emits abort events for all live phases without leaking per-instance listeners. - src/core/cli-options.ts: parseGlobalFlags() for --quiet / --progress-json / --progress-interval=<ms> (both space and = forms), plus cliOptsToProgressOptions() that resolves to the right mode. Non-TTY default is human-plain one-line-per-event; JSON is explicit opt-in so shell pipelines don't suddenly see structured noise. - test/progress.test.ts (17 cases): mode resolution, rate gating, no-fake- totals on heartbeat paths, EPIPE paths, SIGINT singleton, child phase composition. - test/cli-options.test.ts (14 cases): flag parsing, invalid values, interleaved flags, mode resolution. Follow-ups wire doctor/embed/files/export/extract/import/sync/migrate/ repair-jsonb/backlinks/orphans/lint/integrity/eval/autopilot/jobs plus the apply-migrations orchestrators through this reporter, and route Minion handlers to job.updateProgress instead of stderr. See the plan in ~/.claude/plans/. 1682 unit tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(progress): step 2 - wire global flags into cli.ts Parse --quiet / --progress-json / --progress-interval from argv BEFORE command dispatch, strip them, stash resolved CliOptions on a module-level singleton (same pattern as Commander's program.opts()) and on every OperationContext created for shared-op dispatch. - src/cli.ts: parseGlobalFlags(rawArgs) at the top of main(); setCliOptions once; dispatch sees only the stripped argv. Fixes the "gbrain --progress-json doctor" unknown-command case that Codex flagged. - src/core/cli-options.ts: expose setCliOptions/getCliOptions/ _resetCliOptionsForTest singleton. Commands that want progress call getCliOptions() to construct their reporter. - src/core/operations.ts: OperationContext gains optional cliOpts field so shared-op handlers (and MCP-invoked ops that need a reporter) can read the same settings. MCP callers leave it undefined and consumers default to quiet. - test/cli-options.test.ts: +4 cases covering singleton round-trip and an integration smoke spawning `bun src/cli.ts --progress-json --version` to prove the global flag survives dispatch. 45 relevant unit tests pass (progress + cli-options + cli.test.ts). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(progress): step 3a - doctor + orphans heartbeat streaming Doctor on a 52K-page brain used to sit silent for 10+ minutes while the DB checks ran, then get killed by an agent timeout. Wired through the new reporter so agents see which check is running and the slow ones heartbeat every second. doctor.ts: - Start a single `doctor.db_checks` phase around the DB section, with a per-check heartbeat before each step (connection, pgvector, rls, schema_version, embeddings, graph_coverage, integrity, jsonb_integrity, markdown_body_completeness). - jsonb_integrity now scans 5 targets, not 4: added page_versions. frontmatter so the check surface matches `repair-jsonb` (per Codex review of the plan — the old 4-target scan missed a known repair site). Per-target heartbeat so 50K-row scans show incremental progress. - markdown_body_completeness: wrap the existing query in a 1s heartbeat timer. The regex scan over rd.data ->> 'content' can't be paginated usefully; this just lets agents see life during the sequential scan. No fake totals — the LIMIT 100 query has no meaningful total count. - integrity sample: same heartbeat pattern around the 500-page scan. orphans.ts: - findOrphans() wraps the NOT EXISTS anti-join in a 1s heartbeat. Keyset pagination was considered and rejected: without an index on links.to_page_id it's no faster than the full scan, and may re-plan the anti-join per batch. A schema migration adding that index is the right fix and is queued for v0.14.3. Follow-ups: - Step 3b: wire embed/files/export (the \r-only stdout offenders). - Step 5: end-to-end progress test spawning `gbrain doctor --progress-json` against a fixture brain, asserting stderr events and clean stdout. All existing unit tests continue to pass (76/76 in doctor + orphans + progress + cli-options). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(progress): step 3b - embed + files + export stderr progress Replaces the \r-on-stdout progress pattern in the three worst offenders (embed, files sync, export) with the shared reporter on stderr. Stdout now carries only final summaries, so scripts and tests that grep for counts ("Embedded N chunks", "Files sync complete", "Exported N pages") still work when output is piped. - embed.ts: runEmbedCore accepts an optional onProgress callback. The CLI wrapper builds a reporter and passes reporter.tick(); Minion handlers will pass job.updateProgress in Step 4. Worker-pool is single-threaded JS so no rate-gate race (per Codex review #18). - files.ts syncFiles(): tick per file; summary preserved on stdout. - export.ts: tick per page; summary preserved on stdout. Also fixes a --quiet flag collision. `skillpack-check` has its own --quiet mode (suppress all stdout). parseGlobalFlags strips --quiet globally now, and skillpack-check reads the resolved CliOptions singleton via getCliOptions() instead of re-parsing argv. Test updated to match the stripping behavior. 1686 unit tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(progress): step 3c - extract + import + sync reporter streaming Extract, import, and sync now stream per-file progress to stderr through the shared reporter. All three kept their stdout summaries + JSON action-events intact so existing tests + agent scripts are unaffected. - extract.ts (4 paths: links/timeline × fs/db): replaced the ad-hoc `process.stderr.write({event:"progress"...})` lines with reporter ticks. Same channel (stderr), canonical schema now, visible in both text and --json modes. Stdout action-events (`add_link` / `add_timeline`) untouched — tests grep them. - import.ts: the logProgress() function that printed every 100 files to stdout is now a progress.tick() call per file. Rate-gated by the reporter. Stdout still gets the final "Import complete (Xs)" summary and the --json payload. - sync.ts: three new phases (`sync.deletes`, `sync.renames`, `sync.imports`) tick per file, so big syncs show each step rather than a single end-of-run summary. Phase hierarchy ready to be child()-chained into runImport / runEmbed later, per Codex review #26. Updated the #132 nested-transaction regression test in test/sync.test.ts to also accept the new hoisted-loop shape — the guarantee (this loop is not wrapped in engine.transaction) still holds. 1686 unit tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(progress): step 3d - migrate/repair/backlinks/lint/integrity/eval Wires the remaining bulk commands through the reporter: - migrate-engine: phase starts (migrate.copy_pages, migrate.copy_links), per-page tick. Old \"Progress: N/total\" stdout logs replaced by stderr ticks; final stdout summary preserved. - repair-jsonb: per-column start + a heartbeat timer while each UPDATE runs (minutes on 50K-row tables). CRITICAL: stdout stays clean so migrations/v0_12_2.ts's JSON.parse(child.stdout) still works. Per Codex review #12. - backlinks: 1s heartbeat around findBacklinkGaps() (sync double-walk of the brain dir). - lint: tick per page; per-issue stdout output preserved. - integrity auto: tick per page in the main resolver loop. The separate ~/.gbrain/integrity-progress.jsonl resume marker is untouched (its role shifts from live progress reporting to resume-only). - eval: add an onProgress option to core's runEval(), CLI wraps with a reporter. Phases: eval.single / eval.ab. Tick per query. core/search/eval.ts gains a RunEvalOptions type so future callers (MCP eval op, Minion handlers) can also hook in without the reporter. 1686 unit tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(progress): step 3e - onProgress callbacks on core libs - src/core/embedding.ts: embedBatch() gains an optional EmbedBatchOptions.onBatchComplete callback, fired after each 100-item sub-batch. CLI wrappers pass reporter.tick; Minion handlers can pass job.updateProgress. - src/core/enrichment-service.ts: enrichEntities() config gains onProgress(done, total, name) fired after each entity. Same split: CLI -> reporter, Minion -> DB-backed progress. No CLI behavior change on its own. Wiring these callbacks into the Minion handlers is Step 4. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(progress): step 4 - orchestrators + upgrade + minion handlers - cli-options.ts: childGlobalFlags() returns the flag suffix to append to child gbrain subprocesses. Empty string by default, " --quiet --progress-json" when the parent has them set, so child behavior inherits the parent's progress-mode without scattering string-concat logic across every execSync site. - migrations/v0_12_2.ts: each execSync inherits the parent's global flags. Phase C (repair-jsonb --dry-run --json) pins explicit stdio to ['ignore','pipe','inherit'] so child stderr streams straight through while stdout stays captured for JSON.parse. Per Codex review #12. - migrations/v0_12_0.ts + v0_11_0.ts: same childGlobalFlags wiring at each gbrain-subcommand execSync. - upgrade.ts: post-upgrade timeout bumped 300s → 30min (1_800_000 ms) with GBRAIN_POST_UPGRADE_TIMEOUT_MS override. The old 300s cap killed v0.12.0 graph-backfill migrations on 50K+ brains; the heartbeat wiring added in v0.14.2 makes long waits observable, so a generous ceiling no longer means users stare at a silent terminal. - jobs.ts: the embed Minion handler passes job.updateProgress as the onProgress callback, so per-job progress is durable in minion_jobs and readable via `gbrain jobs get <id>`. Primary Minion progress channel is DB-backed — stderr from `jobs work` stays coarse for daemon liveness only. Per Codex review #20. 1686 unit tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(progress): step 5 - E2E doctor-progress test + CI guard scripts/check-progress-to-stdout.sh greps src/ for the banned `process.stdout.write('\r…')` pattern that v0.14.2 removed from the bulk-action codepaths. Wired into the `bun run test` script so any future regression that puts progress back on stdout fails fast. An empty allowlist documents the position: every known call site was migrated; new exceptions need a rationale in the allowlist. test/e2e/doctor-progress.test.ts (Tier 1, needs Postgres + pgvector): - `gbrain --progress-json doctor --json`: stderr carries JSONL progress events with the canonical {event, phase, ts} shape, starts + finishes for `doctor.db_checks`. Stdout stays parseable JSON — no progress pollution. - `gbrain doctor` (no flag): human-plain progress goes to stderr only, stdout stays free of `[doctor.db_checks]`. - `gbrain --quiet doctor`: reporter emits nothing; doctor still runs to completion. test/cli-options.test.ts: +2 spawning integration tests. One verifies `gbrain --progress-json --version` keeps stdout clean of progress events (single-shot commands that don't use a reporter aren't affected). One guards the skillpack-check --quiet regression — --quiet suppresses stdout by reading the resolved CliOptions singleton, not re-parsing argv. Full test matrix: bun run test -> 1726 pass / 184 skipped (no DB) / 0 fail bun run test:e2e -> 136 pass / 13 skipped / 0 fail Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(progress): step 6 - docs + v0.14.2 release bump - VERSION + package.json bumped to 0.14.2. - docs/progress-events.md (new): canonical JSON event schema reference. Stable from v0.14.2, additive only. Lists every phase name shipped in this release, the five event types (start/tick/heartbeat/finish/ abort), the TTY/non-TTY rendering rules, subprocess inheritance semantics, and the Minion DB-backed progress model. - CLAUDE.md: "Bulk-action progress reporting" section under the build instructions; Key files entries for src/core/progress.ts, src/core/cli-options.ts, scripts/check-progress-to-stdout.sh, and docs/progress-events.md; doctor.ts entry updated to note the v0.14.2 5-target jsonb_integrity scan + heartbeat wiring. - CHANGELOG.md v0.14.2: full release summary per project voice rules. The "numbers that matter" table, per-command before/after grid, backward-compat warnings for stdout→stderr moves, and an itemized changes section covering reporter/CLI plumbing/schema/Minion handlers/doctor fixes/upgrade timeout/CI guard/tests. No em dashes. Real file paths, real commands, real numbers. - skills/migrations/v0.14.2.md (new): agent migration note. Mechanical step is "nothing" since v0.14.2 is purely additive. Walks agents through the three new global flags, the 14 wired commands, the event schema cheat sheet, Minion progress via job.updateProgress, and scripts/verification commands. Full test matrix: bun run test (unit + guards) -> 1726 pass / 184 skipped / 0 fail bun run test:e2e (Postgres) -> 141 pass / 8 skipped / 0 fail Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: bump version to 0.15.2, restore master's [0.14.2] CHANGELOG entry Master sits at 0.14.2 (reliability wave). This PR lands on top as 0.15.2 (progress streaming wave). Splits the merge-time combined CHANGELOG entry back into two discrete release sections so history stays honest: - [0.15.2] = progress reporter, CliOptions, 14 wired commands, Minion embed handler, doctor jsonb_integrity 5-target fix, upgrade timeout bump, CI guard, progress unit+E2E tests. - [0.14.2] = master's eight root-cause bug fixes, restored verbatim from origin/master. Touched files: - VERSION + package.json: 0.14.2 -> 0.15.2 (next patch off master). - skills/migrations/v0.14.2.md -> skills/migrations/v0.15.2.md (rename + rewrite frontmatter + body to v0.15.2). - CHANGELOG.md: split into two entries; progress-wave refs renamed v0.14.2 -> v0.15.2; reliability-wave entry restored from master. - src/core/progress.ts, src/commands/doctor.ts, src/commands/sync.ts, src/commands/upgrade.ts, docs/progress-events.md, test/sync.test.ts: progress-wave v0.14.2 references -> v0.15.2. The remaining v0.14.2 references in test/e2e/migration-flow.test.ts (Bug 3 context) and CLAUDE.md (reliability-wave key commands, Bug 3 ledger move) correctly point at master's 0.14.2 release. Test matrix after version bump: bun run test -> 1780 pass / 179 skipped / 0 fail Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
192 lines
6.7 KiB
Markdown
192 lines
6.7 KiB
Markdown
# Progress events
|
|
|
|
Canonical reference for the JSONL progress stream that `gbrain` writes to
|
|
`stderr` when a bulk command runs with `--progress-json`. Stable from
|
|
v0.15.2. Additive changes only; no renames or removals without a major
|
|
version bump.
|
|
|
|
Most humans won't read this page. Agents parsing progress will.
|
|
|
|
## When do I get these events?
|
|
|
|
Any of these commands stream events when `--progress-json` is set:
|
|
|
|
- `gbrain doctor` (DB checks, JSONB integrity, markdown body completeness,
|
|
integrity sample)
|
|
- `gbrain orphans`
|
|
- `gbrain embed`
|
|
- `gbrain files sync`
|
|
- `gbrain export`
|
|
- `gbrain extract [links|timeline|all]` (fs or db source)
|
|
- `gbrain import`
|
|
- `gbrain sync`
|
|
- `gbrain migrate --to …`
|
|
- `gbrain repair-jsonb`
|
|
- `gbrain check-backlinks`
|
|
- `gbrain lint`
|
|
- `gbrain integrity auto`
|
|
- `gbrain eval`
|
|
- `gbrain apply-migrations` (the orchestrator + every child command)
|
|
|
|
Non-bulk commands (`stats`, `graph-query`, `get`, `put`, etc.) don't emit
|
|
events — they return in under a second.
|
|
|
|
## Channel
|
|
|
|
- Progress events: **`stderr`**, one JSON object per line, `\n`-terminated.
|
|
- Data results (`--json` payloads from each command): **`stdout`**.
|
|
- Final human summaries: **`stdout`**.
|
|
|
|
Agents can safely capture stdout for their result parsing and read stderr
|
|
separately for progress.
|
|
|
|
## Flags
|
|
|
|
| Flag | Behavior |
|
|
|---|---|
|
|
| *(none)* | Auto. TTY: `\r`-rewriting single line. Non-TTY: plain line-per-event on stderr. |
|
|
| `--progress-json` | Force JSON-lines mode on stderr (this doc). |
|
|
| `--quiet` | Suppress progress entirely. Warnings and final output still print. |
|
|
| `--progress-interval=<ms>` | Override the minimum interval between tick emits (default 1000). |
|
|
|
|
Global flags: parsed by `src/core/cli-options.ts` before command dispatch,
|
|
so `gbrain --progress-json doctor` works the same as
|
|
`gbrain doctor --progress-json` (the latter also works — per-command
|
|
parsers see the flag via the shared `CliOptions` singleton).
|
|
|
|
## Event types
|
|
|
|
Every event is a single-line JSON object with these common fields:
|
|
|
|
| Field | Type | Notes |
|
|
|---|---|---|
|
|
| `event` | string | One of: `start`, `tick`, `heartbeat`, `finish`, `abort`. |
|
|
| `phase` | string | Machine-stable snake_case, dot-separated. See "Phase names" below. |
|
|
| `ts` | ISO 8601 UTC string | Event emission time. |
|
|
| `elapsed_ms` | number | Ms since the phase started. Present on `tick`/`heartbeat`/`finish`/`abort`. |
|
|
|
|
### `start`
|
|
|
|
Emitted when a phase begins.
|
|
|
|
```json
|
|
{"event":"start","phase":"doctor.db_checks","ts":"2026-04-20T12:34:56.789Z"}
|
|
{"event":"start","phase":"import.files","total":52000,"ts":"2026-04-20T12:34:56.789Z"}
|
|
```
|
|
|
|
Optional fields:
|
|
|
|
- `total` — the total item count if known at start.
|
|
|
|
### `tick`
|
|
|
|
Emitted periodically during iteration. Time- and item-gated: the reporter
|
|
won't emit more often than `minIntervalMs` (default 1000) and
|
|
`minItems` (default `max(10, ceil(total/100))`).
|
|
|
|
```json
|
|
{"event":"tick","phase":"orphans.scan","done":15000,"total":52000,"pct":28.8,"elapsed_ms":4200,"eta_ms":10300,"ts":"..."}
|
|
```
|
|
|
|
Fields:
|
|
|
|
- `done` — items completed in this phase.
|
|
- `total` — total items, if known. Omitted when the scan doesn't have a
|
|
total up front (e.g. a streaming iterator).
|
|
- `pct` — `done/total * 100`, one decimal. Omitted when `total` is unknown.
|
|
- `eta_ms` — projected ms until `done === total`, from the observed rate.
|
|
Omitted when `total` is unknown.
|
|
- `note` — optional string with the current item (e.g. a slug or filename).
|
|
|
|
### `heartbeat`
|
|
|
|
Emitted for long-running single operations that don't iterate
|
|
(e.g. `SELECT` against a 50K-row table). No `done`, no `total` — just a
|
|
signal that work is still happening.
|
|
|
|
```json
|
|
{"event":"heartbeat","phase":"doctor.markdown_body_completeness","note":"scanning pages for truncation…","elapsed_ms":1000,"ts":"..."}
|
|
```
|
|
|
|
### `finish`
|
|
|
|
Emitted when a phase completes normally.
|
|
|
|
```json
|
|
{"event":"finish","phase":"import.files","done":52000,"total":52000,"elapsed_ms":187000,"ts":"..."}
|
|
```
|
|
|
|
### `abort`
|
|
|
|
Emitted by a single process-level SIGINT/SIGTERM handler that tracks every
|
|
live phase. After `abort`, no further events emit for that phase.
|
|
|
|
```json
|
|
{"event":"abort","phase":"doctor.markdown_body_completeness","reason":"SIGINT","elapsed_ms":5300,"ts":"..."}
|
|
```
|
|
|
|
## Phase names
|
|
|
|
Phases use `snake_case.dot.path` naming. A fresh reporter starts at the
|
|
root; `child()` composition appends to the parent's current phase, so a
|
|
sync that calls import emits `sync.import.<file>`, not `import.<file>`.
|
|
|
|
Stable phase names shipped in v0.15.2:
|
|
|
|
- `doctor.db_checks` (umbrella for all DB-side doctor checks)
|
|
- `orphans.scan`
|
|
- `embed.pages`
|
|
- `extract.links_fs`, `extract.timeline_fs`, `extract.links_db`, `extract.timeline_db`
|
|
- `import.files`
|
|
- `sync.deletes`, `sync.renames`, `sync.imports`
|
|
- `migrate.copy_pages`, `migrate.copy_links`
|
|
- `repair_jsonb.run`, `repair_jsonb.<table>.<column>`
|
|
- `backlinks.scan`
|
|
- `lint.pages`
|
|
- `integrity.auto`
|
|
- `eval.single`, `eval.ab`
|
|
- `export.pages`
|
|
- `files.sync`
|
|
|
|
Sub-phases exposed via `child()`:
|
|
|
|
- `sync.import.files` — nested inside a sync
|
|
- `apply_migrations.v0_12_2.jsonb_repair` — nested inside the orchestrator
|
|
|
|
## Subprocess inheritance
|
|
|
|
When a parent CLI spawns `gbrain …` child processes (mostly in
|
|
`src/commands/migrations/*`), global flags (`--quiet`, `--progress-json`,
|
|
`--progress-interval`) are propagated to the child's argv via the
|
|
`childGlobalFlags()` helper in `src/core/cli-options.ts`. Child stderr
|
|
passes straight through `stdio: 'inherit'` so the event stream is one
|
|
merged JSONL feed on the parent's stderr.
|
|
|
|
One exception: the orchestrator phase in `migrations/v0_12_2.ts` that
|
|
captures child stdout (`repair-jsonb --dry-run --json` for verification)
|
|
does not pass `--progress-json` to avoid any risk of stdout pollution
|
|
breaking the orchestrator's `JSON.parse`. Its stdio is explicit:
|
|
`['ignore', 'pipe', 'inherit']` so stderr still flows through.
|
|
|
|
## Minion jobs
|
|
|
|
`gbrain jobs work` (the Minion worker daemon) keeps progress in the DB,
|
|
not on stderr. Each Minion handler that runs a bulk core (embed, sync,
|
|
extract, import, backlinks) calls `job.updateProgress({done, total,
|
|
…})` per iteration. Agents read per-job progress via the
|
|
`get_job_progress` MCP operation or `gbrain jobs get <id>`.
|
|
|
|
The `jobs work` daemon itself emits coarse one-line-per-job stderr output
|
|
for liveness only. Per-page detail lives in the DB.
|
|
|
|
## Compatibility
|
|
|
|
- **Added**: only. A new event type, a new field, a new phase name — all
|
|
safe. Agents must ignore unknown fields and unknown event types.
|
|
- **Removed/renamed**: never without a major version bump.
|
|
- **Schema changes**: announced in `CHANGELOG.md` and in
|
|
`skills/migrations/v<next>.md`.
|
|
|
|
If your agent depends on this schema and something surprises you, open
|
|
an issue with the event you received and what you expected.
|