Files
gbrain/test/cross-modal-eval-cli.test.ts
T
a1a2671c21 v0.28.4 feat(skillpack): enhance skillify with cross-modal eval quality gate (#674)
* feat(skillpack): enhance skillify with cross-modal eval quality gate

Updates skillify from v1.0.0 to v2.0.0 with the key innovation:
cross-modal evaluation runs BEFORE tests (step 3) to establish
quality, then tests lock in the proven-good behavior.

Key changes:
- 11-item checklist (was 10) - adds cross-modal eval as step 3
- Cross-modal eval uses 3 models to score output on 5 dimensions
- Quality gate: all dimensions ≥ 7 average before proceeding to tests
- Prevents locking in mediocrity through tests-first approach
- References cross-modal-review skill for eval pipeline
- Updated all gbrain-specific paths (bun test, scripts/*.ts)
- Maintains compatibility with gbrain check-resolvable workflow

The meta-skill for turning raw features into properly-skilled,
tested, resolvable capabilities. Cross-modal eval ensures output
quality before tests cement the behavior.

* feat: skillify hardened via 2 cross-modal eval cycles (8.1/10)

Applied top improvements from GPT-5.5 + Opus 4-7 + DeepSeek V4 Pro:
- Named 3 frontier models explicitly with provider table
- Inlined eval prompt template with CONTEXT param + scoring calibration
- Defined aggregation math: mean >= 7 AND no single dim < 5
- Added eval receipt JSON schema
- Structured 3-cycle fix loop with before/after delta tracking
- Added worked example (summarize-pr, end-to-end)
- Added cost guardrails (skip < 200 tokens, max 9 API calls)
- Added representative input selection rule
- Added SKILL.md frontmatter template (copy-paste ready)
- Added Phase 0 decision gate (is this worth skillifying?)

Also includes cross-modal-eval runner recipe with robust JSON
parsing for LLMs that return malformed JSON (3-tier repair).

* chore(recipes): remove cross-modal-eval.mjs

Superseded by `gbrain eval cross-modal` (next commit). The .mjs script
was the original PR's hand-rolled provider stack; the replacement reuses
src/core/ai/gateway.ts so config/auth/model-aliasing comes from the
canonical recipe registry instead of a parallel stack.

No code references the .mjs (it was invoked by skill prose only), so
this delete is independently safe to bisect through.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(eval): cross-modal-eval core module + unit tests

Pure-logic foundation for the new `gbrain eval cross-modal` command
(wired in the next commit). All five modules are self-contained — no
CLI surface, no I/O outside the receipt writer's mkdirSync. Imported
from src/core/ai/gateway.ts at runtime via gwChat (no config impact
at load time).

Modules:
  - json-repair.ts:    parseModelJSON 4-strategy fallback chain.
                       Adversarial nuclear-option throws rather than
                       fabricating scores (Q6 + Q3 in plan).
  - aggregate.ts:      verdict logic. PASS = (>=2 successes) AND
                       (every dim mean >= 7) AND (every dim min
                       across models >= 5). INCONCLUSIVE when <2/3
                       models returned parseable scores — closes the
                       v1 .mjs `Object.values({}).every(...) === true`
                       empty-array silent-PASS bug (Q2 + Q3).
  - receipt-name.ts:   receipt filename binds (slug, sha8 of SKILL.md)
                       so `gbrain skillify check` can detect stale
                       audits (T10 in plan).
  - receipt-write.ts:  thin wrapper over writeFileSync that auto-mkdirs
                       the parent directory. Standalone module because
                       gbrainPath() does NOT auto-mkdir (T5 plan
                       correction — Codex caught this).
  - runner.ts:         orchestrator. Promise.allSettled across 3 slots
                       per cycle; up to 3 cycles; stops early on PASS
                       or INCONCLUSIVE. Default slots: openai:gpt-4o /
                       anthropic:claude-opus-4-7 / google:gemini-1.5-pro.
                       estimateCost() exports a small per-model
                       pricing table (drifts; refresh alongside
                       model-family bumps).

Tests (32 cases total, all green):
  - json-repair.test.ts:  10 cases (clean JSON, fences, trailing
                          commas, single quotes, embedded newlines,
                          mismatched braces, nuclear-option success
                          + adversarial throws, empty input,
                          numeric-shorthand scores).
  - aggregate.test.ts:    8 cases pinning Q2/Q3/dedup. The 0-of-3
                          INCONCLUSIVE case is the regression guard
                          for the v1 silent-PASS bug.
  - cli.test.ts:          12 cases on receipt-name / receipt-write /
                          GBRAIN_HOME isolation. Uses withEnv()
                          helper for env mutation (R1 isolation rule).

Verifies bisect-clean: typecheck passes, all 32 unit cases green.
The runner.ts import of gateway.chat() is dead until commit 3 wires
the CLI surface.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(eval): wire `gbrain eval cross-modal` CLI subcommand

User-facing surface for the multi-model quality gate. Three different-
provider frontier models score the OUTPUT against the TASK on a 5-dim
rubric. Verdict drives exit code: 0 PASS, 1 FAIL, 2 INCONCLUSIVE
(<2/3 models returned parseable scores per Q3 in plan).

Wiring touches three files:

  - src/commands/eval-cross-modal.ts (new, ~290 lines)
    CLI handler. Self-configures the AI gateway from loadConfig() +
    process.env so it works without `gbrain init` (the cli.ts no-DB
    branch bypasses connectEngine()). Defaults: cycles=3 in TTY,
    cycles=1 in non-TTY (T11 partial cost guardrail — limits scripted
    bulk spend; full --budget-usd hard cap is a v0.27.x TODO). Prints
    estimated max-cost-per-cycle to stderr before each run. Uses
    gbrainPath('eval-receipts') for receipt directory.

  - src/cli.ts (no-DB dispatch branch, 5-line addition)
    Special-cases `eval cross-modal` BEFORE the existing
    handleCliOnly path that requires connectEngine(). Mirrors the
    `dream` no-DB pattern but doesn't even attempt the connect — the
    command never touches the DB. New users can run the gate before
    `gbrain init` (T3 in plan).

  - src/commands/eval.ts (sub-subcommand dispatch)
    Adds `cross-modal` alongside `export`/`prune`/`replay`. The
    cli.ts branch takes precedence in the user-facing path; this
    branch only fires when callers re-enter runEvalCommand with an
    existing engine. Engine is intentionally unused — the handler
    self-routes.

  - test/e2e/cross-modal-eval.test.ts (new, 4 cases)
    Mocked-fetch E2E. Lives at test/e2e/* (NOT *.serial.test.ts) per
    plan T8: test/e2e/* is exempt from the test-isolation lint and
    already runs serially via scripts/run-e2e.sh, so the
    mock.module() call doesn't need a quarantine rename. Cases:
    PASS / FAIL (mean<7) / FAIL (min<5 — Q2 floor) / INCONCLUSIVE
    (2 mock 5xx — Q3 contract).

The runner from commit 2 now has live callers. typecheck passes;
the 4 E2E cases all green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(skillify): add informational 11th item (cross-modal eval)

Promotes the skillify contract from 10 to 11 items. The 11th item
(cross-modal eval) is `required:false` per T7 in the plan — a
missing or stale receipt surfaces in the audit output but does not
fail the gate. Existing skills keep their current required-score;
the bump is additive, not breaking.

Changes:

  - src/commands/skillify.ts
    Header jsdoc updated 10-item -> 11-item. No code-flow changes.

  - src/commands/skillify-check.ts (the per-skill audit; not
    src/commands/skillpack-check.ts which is a different command —
    plan T6 corrected the conflation in the original plan)
    New informational item at position 11. Reuses
    findReceiptForSkill() helper from
    src/core/cross-modal-eval/receipt-name.ts to detect:
      * found  — receipt matches current SKILL.md sha-8
      * stale  — receipt exists for an older SKILL.md
      * missing — no receipt yet
    Audit output cases pass through to existing pretty/JSON formats.

  - src/core/skillify/templates.ts
    Scaffolded SKILL.md now includes a "Phase 3: Cross-modal eval
    (informational)" section with copy-paste `gbrain eval cross-modal`
    invocation, pass criteria, and receipt-naming convention. Helps
    new skill authors discover the gate.

  - test/skillify-scaffold.test.ts
    New T9 case verifies the scaffold emits the Phase 3 section,
    points at the correct command, documents the receipt path, and
    appends exactly one resolver row. Replaces the original plan's
    `gbrain skillify scaffold demo-eleven` shell verification (which
    Codex caught as invalid + repo-mutating).

Verifies: typecheck passes; scaffold test 19/19 (was 18, +1 T9 case).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs: skillify v1.1.0 + cross-modal-eval references

Documentation catches up with the new behavior shipped in commits 1-4.

  - skills/skillify/SKILL.md (1.0.0 -> 1.1.0)
    Full rewrite. Frontmatter version is additive (T7 in plan); the
    11th item is informational, not breaking. Phase 3 now points at
    `gbrain eval cross-modal` with copy-paste invocation, default
    slot table, pass criteria, receipt-naming convention, cycles +
    cost guardrails (T11 partial cap), provider configuration via
    the AI gateway, and the cycle-1/2/3 fix loop. Adds Output Format
    section (skills-conformance.test.ts requires it). Drops the
    original `(or lib/cross-modal-eval.ts)` parenthetical (Q5 plan
    correction — that path never existed).

  - skills/cross-modal-review/SKILL.md
    Adds 4-line Relationship section pointing at `gbrain eval
    cross-modal` (D3 plan reciprocal). Distinguishes the manual
    second-opinion gate (this skill) from the automated multi-model
    score-and-iterate gate (the new command).

  - CLAUDE.md
    Key Files entries for src/commands/eval-cross-modal.ts and the
    five new src/core/cross-modal-eval/* modules. Commands list
    gains the `gbrain eval cross-modal` entry under v0.27.x. Notes
    the non-TTY default 1-cycle behavior + the gbrainPath('eval-
    receipts') resolution.

  - TODOS.md
    Four v0.27.x follow-ups filed under a new "cross-modal-eval"
    section: full --budget-usd cap (T11 follow-up), subagent
    integration (recovers cross-process rate-leases T4 deferred),
    skill adoption telemetry (revisit T7=C with data after 30 days),
    docs/cross-modal-eval.md user guide.

  - llms-full.txt
    Regenerated via `bun run build:llms` to match the CLAUDE.md
    edits — sync guard at test/build-llms.test.ts requires this.

Verifies: typecheck passes; skills-conformance 199/199 green;
build-llms 7/7 green; full unit fast loop 3861/3861 green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: bump version and changelog (v0.28.4)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: garrytan-agents <garrytan-agents@users.noreply.github.com>
Co-authored-by: Garry Tan <garrytan@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-06 20:39:56 -07:00

196 lines
7.0 KiB
TypeScript

import { describe, expect, test } from 'bun:test';
import { mkdtempSync, mkdirSync, readdirSync, rmSync, writeFileSync, readFileSync, existsSync } from 'fs';
import { tmpdir } from 'os';
import { join } from 'path';
import {
describeReceiptStatus,
findReceiptForSkill,
inferSlugFromSkillPath,
isReceiptFile,
listReceiptsForSlug,
receiptName,
sha8,
} from '../src/core/cross-modal-eval/receipt-name.ts';
import { writeReceipt } from '../src/core/cross-modal-eval/receipt-write.ts';
import { withEnv } from './helpers/with-env.ts';
function makeTempDir(): string {
return mkdtempSync(join(tmpdir(), 'gbrain-cme-cli-'));
}
describe('cross-modal-eval CLI helpers', () => {
test('sha8 is deterministic and 8 hex chars', () => {
const a = sha8('hello world');
const b = sha8('hello world');
expect(a).toBe(b);
expect(a).toMatch(/^[0-9a-f]{8}$/);
expect(sha8('different')).not.toBe(a);
});
test('receiptName: <slug>-<sha8>.json shape', () => {
const name = receiptName('my-skill', '# SKILL.md content');
expect(name).toMatch(/^my-skill-[0-9a-f]{8}\.json$/);
const expected = `my-skill-${sha8('# SKILL.md content')}.json`;
expect(name).toBe(expected);
});
test('receiptName rejects invalid slug', () => {
expect(() => receiptName('Bad Slug', 'x')).toThrow();
expect(() => receiptName('', 'x')).toThrow();
expect(() => receiptName('../escape', 'x')).toThrow();
});
test('inferSlugFromSkillPath: pulls parent directory name', () => {
expect(inferSlugFromSkillPath('skills/my-skill/SKILL.md')).toBe('my-skill');
expect(inferSlugFromSkillPath('/abs/path/skills/foo-bar/SKILL.md')).toBe('foo-bar');
expect(() => inferSlugFromSkillPath('skills/my-skill/notes.md')).toThrow();
expect(() => inferSlugFromSkillPath('SKILL.md')).toThrow();
});
test('findReceiptForSkill: missing skill -> missing', () => {
const dir = makeTempDir();
try {
const result = findReceiptForSkill(join(dir, 'skills', 'nope', 'SKILL.md'), join(dir, 'receipts'));
expect(result.status).toBe('missing');
} finally {
rmSync(dir, { recursive: true, force: true });
}
});
test('findReceiptForSkill: found when sha matches', () => {
const dir = makeTempDir();
try {
const skillDir = join(dir, 'skills', 'demo');
mkdirSync(skillDir, { recursive: true });
const skillPath = join(skillDir, 'SKILL.md');
const content = '# demo skill\n';
writeFileSync(skillPath, content);
const receiptDir = join(dir, 'receipts');
mkdirSync(receiptDir, { recursive: true });
const expected = receiptName('demo', content);
writeFileSync(join(receiptDir, expected), '{"schema_version":1}');
const status = findReceiptForSkill(skillPath, receiptDir);
expect(status.status).toBe('found');
if (status.status === 'found') {
expect(status.path.endsWith(expected)).toBe(true);
expect(status.sha).toBe(sha8(content));
}
} finally {
rmSync(dir, { recursive: true, force: true });
}
});
test('findReceiptForSkill: stale when sha mismatches', () => {
const dir = makeTempDir();
try {
const skillDir = join(dir, 'skills', 'demo');
mkdirSync(skillDir, { recursive: true });
const skillPath = join(skillDir, 'SKILL.md');
writeFileSync(skillPath, '# updated content\n');
const receiptDir = join(dir, 'receipts');
mkdirSync(receiptDir, { recursive: true });
const oldSha = sha8('# original content\n');
writeFileSync(join(receiptDir, `demo-${oldSha}.json`), '{"schema_version":1}');
const status = findReceiptForSkill(skillPath, receiptDir);
expect(status.status).toBe('stale');
if (status.status === 'stale') {
expect(status.latestSha).toBe(oldSha);
expect(status.currentSha).toBe(sha8('# updated content\n'));
}
} finally {
rmSync(dir, { recursive: true, force: true });
}
});
test('describeReceiptStatus: human-readable string for each status', () => {
const found = describeReceiptStatus('demo', { status: 'found', path: '/r/demo-aabbccdd.json', sha: 'aabbccdd' });
expect(found).toContain('found');
expect(found).toContain('demo');
const stale = describeReceiptStatus('demo', {
status: 'stale',
latestPath: '/r/demo-old.json',
latestSha: 'old-sha',
currentSha: 'new-sha',
});
expect(stale).toContain('older');
expect(stale).toContain('Re-run');
const missing = describeReceiptStatus('demo', { status: 'missing', currentSha: 'x' });
expect(missing).toContain('no cross-modal eval receipt');
});
test('listReceiptsForSlug returns newest first', () => {
const dir = makeTempDir();
try {
mkdirSync(dir, { recursive: true });
writeFileSync(join(dir, 'demo-11111111.json'), '{}');
// Sleep tiny so mtimes differ on filesystems with low resolution.
const start = Date.now();
while (Date.now() - start < 10) {
// tight spin
}
writeFileSync(join(dir, 'demo-22222222.json'), '{}');
const list = listReceiptsForSlug('demo', dir);
expect(list).toHaveLength(2);
expect(list[0]!.endsWith('22222222.json')).toBe(true);
} finally {
rmSync(dir, { recursive: true, force: true });
}
});
test('isReceiptFile recognizes pattern', () => {
expect(isReceiptFile('demo-aabbccdd.json')).toBe(true);
expect(isReceiptFile('/some/dir/my-skill-12345678.json')).toBe(true);
expect(isReceiptFile('demo.json')).toBe(false);
expect(isReceiptFile('demo-toolong.json')).toBe(false);
expect(isReceiptFile('not a receipt')).toBe(false);
});
test('writeReceipt auto-mkdirs parent (T5 correction)', () => {
const dir = makeTempDir();
try {
const target = join(dir, 'nested', 'deeper', 'demo-aabbccdd.json');
expect(existsSync(target)).toBe(false);
writeReceipt(target, { hello: 'world' });
expect(existsSync(target)).toBe(true);
const body = JSON.parse(readFileSync(target, 'utf-8'));
expect(body).toEqual({ hello: 'world' });
} finally {
rmSync(dir, { recursive: true, force: true });
}
});
test('writeReceipt accepts pre-stringified content', () => {
const dir = makeTempDir();
try {
const target = join(dir, 'demo-aabbccdd.json');
writeReceipt(target, '{"already":"json"}');
const body = readFileSync(target, 'utf-8');
expect(body).toBe('{"already":"json"}');
} finally {
rmSync(dir, { recursive: true, force: true });
}
});
test('GBRAIN_HOME isolates receipts under <home>/.gbrain/eval-receipts', async () => {
const dir = makeTempDir();
try {
await withEnv({ GBRAIN_HOME: dir }, async () => {
const { gbrainPath } = await import('../src/core/config.ts');
const path = gbrainPath('eval-receipts');
expect(path.startsWith(dir)).toBe(true);
expect(path.endsWith('eval-receipts')).toBe(true);
expect(path.includes('.gbrain')).toBe(true);
});
} finally {
rmSync(dir, { recursive: true, force: true });
}
});
});