mirror of
https://github.com/garrytan/gbrain.git
synced 2026-07-27 22:15:33 +00:00
be8fffad71
PgBouncer transaction-mode poolers can silently swallow ALTER TABLE statements: the SQL doesn't error, but the column never gets created. The migration system increments the schema version counter anyway, so gbrain thinks it's on the latest version but the actual table is missing columns. This caused production embed failures when the embed handler tried to INSERT into columns that didn't exist. Add verifySchema() that runs after all migrations complete: 1. Parses CREATE TABLE + ALTER TABLE ADD COLUMN from schema-embedded.ts 2. Queries information_schema.columns for actual DB state 3. Diffs expected vs actual columns 4. Self-heals missing columns via ALTER TABLE ADD COLUMN IF NOT EXISTS 5. Throws with actionable diagnostics if self-heal fails Called from PostgresEngine.initSchema() after runMigrations(). PGLite skipped (in-process, no PgBouncer). Co-authored-by: root <root@localhost>
109 lines
3.8 KiB
TypeScript
109 lines
3.8 KiB
TypeScript
import { describe, it, expect } from 'bun:test';
|
|
import { parseExpectedColumns, simplifyColumnDef } from '../src/core/schema-verify.ts';
|
|
|
|
describe('parseExpectedColumns', () => {
|
|
it('extracts columns from all major tables', () => {
|
|
const columns = parseExpectedColumns();
|
|
|
|
// Should find columns from known tables
|
|
const tables = new Set(columns.map(c => c.table));
|
|
expect(tables.has('pages')).toBe(true);
|
|
expect(tables.has('content_chunks')).toBe(true);
|
|
expect(tables.has('links')).toBe(true);
|
|
expect(tables.has('sources')).toBe(true);
|
|
expect(tables.has('minion_jobs')).toBe(true);
|
|
expect(tables.has('files')).toBe(true);
|
|
|
|
// Should find specific columns that have historically been missed by PgBouncer
|
|
const columnKeys = new Set(columns.map(c => `${c.table}.${c.column}`));
|
|
expect(columnKeys.has('content_chunks.symbol_type')).toBe(true);
|
|
expect(columnKeys.has('content_chunks.start_line')).toBe(true);
|
|
expect(columnKeys.has('content_chunks.end_line')).toBe(true);
|
|
expect(columnKeys.has('content_chunks.parent_symbol_path')).toBe(true);
|
|
expect(columnKeys.has('content_chunks.doc_comment')).toBe(true);
|
|
expect(columnKeys.has('content_chunks.symbol_name_qualified')).toBe(true);
|
|
expect(columnKeys.has('content_chunks.search_vector')).toBe(true);
|
|
|
|
// pages columns
|
|
expect(columnKeys.has('pages.slug')).toBe(true);
|
|
expect(columnKeys.has('pages.source_id')).toBe(true);
|
|
expect(columnKeys.has('pages.page_kind')).toBe(true);
|
|
expect(columnKeys.has('pages.search_vector')).toBe(true);
|
|
|
|
// sources columns
|
|
expect(columnKeys.has('sources.chunker_version')).toBe(true);
|
|
});
|
|
|
|
it('does not include CONSTRAINT lines as columns', () => {
|
|
const columns = parseExpectedColumns();
|
|
const colNames = columns.map(c => c.column);
|
|
|
|
// These are constraint names, not column names
|
|
expect(colNames).not.toContain('constraint');
|
|
expect(colNames).not.toContain('unique');
|
|
expect(colNames).not.toContain('check');
|
|
expect(colNames).not.toContain('primary');
|
|
expect(colNames).not.toContain('foreign');
|
|
});
|
|
|
|
it('returns non-empty definitions for all columns', () => {
|
|
const columns = parseExpectedColumns();
|
|
for (const col of columns) {
|
|
expect(col.definition.length).toBeGreaterThan(0);
|
|
}
|
|
});
|
|
});
|
|
|
|
describe('simplifyColumnDef', () => {
|
|
it('strips REFERENCES clauses', () => {
|
|
const result = simplifyColumnDef(
|
|
"TEXT NOT NULL DEFAULT 'default' REFERENCES sources(id) ON DELETE CASCADE"
|
|
);
|
|
expect(result).toBe("TEXT NOT NULL DEFAULT 'default'");
|
|
});
|
|
|
|
it('strips CHECK constraints', () => {
|
|
const result = simplifyColumnDef(
|
|
"TEXT NOT NULL DEFAULT 'markdown' CHECK (page_kind IN ('markdown','code'))"
|
|
);
|
|
expect(result).toBe("TEXT NOT NULL DEFAULT 'markdown'");
|
|
});
|
|
|
|
it('preserves simple type + NOT NULL + DEFAULT', () => {
|
|
const result = simplifyColumnDef("INTEGER NOT NULL DEFAULT 0");
|
|
expect(result).toBe("INTEGER NOT NULL DEFAULT 0");
|
|
});
|
|
|
|
it('strips UNIQUE keyword', () => {
|
|
const result = simplifyColumnDef("TEXT NOT NULL UNIQUE");
|
|
expect(result).toBe("TEXT NOT NULL");
|
|
});
|
|
|
|
it('handles complex REFERENCES with ON DELETE and ON UPDATE', () => {
|
|
const result = simplifyColumnDef(
|
|
"INTEGER NOT NULL REFERENCES pages(id) ON DELETE CASCADE"
|
|
);
|
|
expect(result).toBe("INTEGER NOT NULL");
|
|
});
|
|
|
|
it('handles bare type', () => {
|
|
const result = simplifyColumnDef("TEXT");
|
|
expect(result).toBe("TEXT");
|
|
});
|
|
|
|
it('handles vector type', () => {
|
|
const result = simplifyColumnDef("vector(1536)");
|
|
expect(result).toBe("vector(1536)");
|
|
});
|
|
|
|
it('handles TSVECTOR type', () => {
|
|
const result = simplifyColumnDef("TSVECTOR");
|
|
expect(result).toBe("TSVECTOR");
|
|
});
|
|
|
|
it('handles array types', () => {
|
|
const result = simplifyColumnDef("TEXT[]");
|
|
expect(result).toBe("TEXT[]");
|
|
});
|
|
});
|