admin/openhuman
1
0
Fork 0
mirror of https://github.com/tinyhumansai/openhuman.git synced 2026-07-27 21:08:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(legacy_aliases): tolerate unquoted keys + skip comments in alias-table parser (#2865)

Browse Source 
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
sanil-23
2026-05-29 00:45:18 +05:30
committed by GitHub
co-authored by Claude
parent 9415fd1b01
commit 29aeba82d4
1 changed files with 37 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/legacy_aliases.rs
+37 -2
View File
@@ -223,7 +223,7 @@ mod tests {
let compact = body
.lines()
.map(str::trim)
.filter(|line| !line.is_empty())
.filter(|line| !line.is_empty() && !line.starts_with("//"))
.collect::<Vec<_>>()
.join(" ");
let mut aliases = BTreeMap::new();
@@ -235,7 +235,14 @@ mod tests {
let (legacy, target_expr) = entry
.split_once(':')
.unwrap_or_else(|| panic!("expected legacy alias entry, got `{entry}`"));
let legacy = quoted_value(legacy);
// Prettier strips quotes from keys that are valid JS identifiers
// (e.g. `health_snapshot`), so accept both `'foo':` and bare `foo:`.
let legacy_trimmed = legacy.trim();
let legacy = if legacy_trimmed.starts_with('\'') || legacy_trimmed.starts_with('"') {
quoted_value(legacy)
} else {
legacy_trimmed.to_string()
};
let target_expr = target_expr.trim();
let canonical = if let Some(key) = target_expr.strip_prefix("CORE_RPC_METHODS.") {
core_methods
@@ -345,6 +352,34 @@ mod tests {
);
}
#[test]
fn parse_frontend_legacy_aliases_accepts_bare_identifier_keys_and_skips_comments() {
// Prettier strips redundant quotes from keys that are valid JS
// identifiers, so the canonical form for a simple key like
// `health_snapshot` is unquoted. The parser must accept both
// `'foo':` and bare `foo:`, and must ignore `//` comment lines
// in the LEGACY_METHOD_ALIASES body.
let source = "export const CORE_RPC_METHODS = {\n alphaMethod: 'openhuman.alpha',\n betaMethod: 'openhuman.beta',\n} as const;\n\nexport const LEGACY_METHOD_ALIASES: Record<string, CoreRpcMethod> = {\n // legacy aliases for the alpha method\n 'openhuman.legacy_alpha': CORE_RPC_METHODS.alphaMethod,\n beta_legacy: CORE_RPC_METHODS.betaMethod,\n};\n";
let core_methods = parse_core_rpc_methods(source);
let aliases = parse_frontend_legacy_aliases(source, &core_methods);
assert_eq!(
aliases.get("openhuman.legacy_alpha").map(String::as_str),
Some("openhuman.alpha"),
"quoted-key entry should still resolve"
);
assert_eq!(
aliases.get("beta_legacy").map(String::as_str),
Some("openhuman.beta"),
"bare-identifier key should resolve (Prettier-normalized form)"
);
assert!(
!aliases
.keys()
.any(|k| k.contains("//") || k.contains("legacy aliases")),
"comment text must not be captured as a key"
);
}
#[test]
#[should_panic(expected = "legacy alias references unknown CORE_RPC_METHODS")]
fn parse_frontend_legacy_aliases_panics_on_unknown_core_method_ref() {