refactor(composio): hide raw connection ID, derive friendly label (#1153) (#1185)

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
This commit is contained in:
oxoxDev
2026-05-04 10:49:25 -07:00
committed by GitHub
co-authored by google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
parent d29fa23c66
commit 8f38f4e582
3 changed files with 115 additions and 2 deletions
@@ -0,0 +1,100 @@
import { render, screen } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';
import { type ComposioConnection } from '../../lib/composio/types';
import ComposioConnectModal from './ComposioConnectModal';
import { composioToolkitMeta } from './toolkitMeta';
vi.mock('../../lib/composio/composioApi', () => ({
authorize: vi.fn(),
deleteConnection: vi.fn(),
getUserScopes: vi.fn(() => Promise.resolve({ read: true, write: true, admin: false })),
listConnections: vi.fn(),
setUserScopes: vi.fn(),
}));
vi.mock('../../utils/openUrl', () => ({ openUrl: vi.fn() }));
// Mock TriggerToggles because it does its own API calls
vi.mock('./TriggerToggles', () => ({ default: () => <div data-testid="trigger-toggles" /> }));
const mockToolkit = composioToolkitMeta('gmail');
describe('<ComposioConnectModal>', () => {
it('hides raw connection ID and "id:" label in connected phase', () => {
const connection: ComposioConnection = { id: 'ca_xyz', toolkit: 'gmail', status: 'ACTIVE' };
render(
<ComposioConnectModal toolkit={mockToolkit} connection={connection} onClose={() => {}} />
);
// Should be in 'connected' phase because connection.status is 'ACTIVE'
expect(screen.getByText(/Gmail is connected/)).toBeInTheDocument();
expect(screen.queryByText(/ca_xyz/)).not.toBeInTheDocument();
expect(screen.queryByText(/id:/)).not.toBeInTheDocument();
});
it('renders accountEmail when provided', () => {
const connection: ComposioConnection = {
id: 'ca_xyz',
toolkit: 'gmail',
status: 'ACTIVE',
accountEmail: 'foo@bar.com',
};
render(
<ComposioConnectModal toolkit={mockToolkit} connection={connection} onClose={() => {}} />
);
expect(screen.getByText('(foo@bar.com)')).toBeInTheDocument();
});
it('renders workspace when accountEmail is missing', () => {
const connection: ComposioConnection = {
id: 'ca_xyz',
toolkit: 'gmail',
status: 'ACTIVE',
workspace: 'Acme',
};
render(
<ComposioConnectModal toolkit={mockToolkit} connection={connection} onClose={() => {}} />
);
expect(screen.getByText('(Acme)')).toBeInTheDocument();
});
it('renders username when email and workspace are missing', () => {
const connection: ComposioConnection = {
id: 'ca_xyz',
toolkit: 'gmail',
status: 'ACTIVE',
username: 'oxox',
};
render(
<ComposioConnectModal toolkit={mockToolkit} connection={connection} onClose={() => {}} />
);
expect(screen.getByText('(oxox)')).toBeInTheDocument();
});
it('prioritizes accountEmail over workspace and username', () => {
const connection: ComposioConnection = {
id: 'ca_xyz',
toolkit: 'gmail',
status: 'ACTIVE',
accountEmail: 'foo@bar.com',
workspace: 'Acme',
username: 'oxox',
};
render(
<ComposioConnectModal toolkit={mockToolkit} connection={connection} onClose={() => {}} />
);
expect(screen.getByText('(foo@bar.com)')).toBeInTheDocument();
expect(screen.queryByText('(Acme)')).not.toBeInTheDocument();
expect(screen.queryByText('(oxox)')).not.toBeInTheDocument();
});
});
@@ -32,6 +32,14 @@ import { openUrl } from '../../utils/openUrl';
import type { ComposioToolkitMeta } from './toolkitMeta';
import TriggerToggles from './TriggerToggles';
function deriveConnectionLabel(c: ComposioConnection): string | null {
for (const value of [c.accountEmail, c.workspace, c.username]) {
const normalized = value?.trim();
if (normalized) return normalized;
}
return null;
}
type Phase = 'idle' | 'authorizing' | 'waiting' | 'connected' | 'disconnecting' | 'error';
interface ComposioConnectModalProps {
@@ -392,9 +400,9 @@ export default function ComposioConnectModal({
<div className="w-2 h-2 rounded-full bg-sage-500" />
<div>
{toolkit.name} is connected. &nbsp;
{activeConnection && (
{activeConnection && deriveConnectionLabel(activeConnection) && (
<span className="text-[11px] text-stone-400 font-mono">
(id: {activeConnection.id})
({deriveConnectionLabel(activeConnection)})
</span>
)}
</div>
+5
View File
@@ -16,6 +16,11 @@ export interface ComposioConnection {
status: string;
/** ISO timestamp (backend passthrough). */
createdAt?: string;
/** Optional friendly identity fields populated by later backend versions. */
accountEmail?: string;
workspace?: string;
username?: string;
}
export interface ComposioConnectionsResponse {