2 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
4 people	b2ae12ad02	perf(agent): prewarm session integrations before first turn ... ## Summary - prewarm session `connected_integrations` from the shared Composio cache during `from_config_*` agent construction - synthesize delegation tools against the prewarmed integration view so fresh sessions start with the correct `delegate_<toolkit>` surface - skip the turn-1 integration fetch and delegation-surface rebuild when the builder already had an authoritative cache snapshot - carry the runtime `Config` snapshot on the session agent so mid-session integration-cache probes stop reloading config on the hot path - add a regression test for the initialized/hash bookkeeping when integrations are injected onto an agent ## Problem - Fresh agent sessions were doing avoidable cold-start work inside `Agent::turn()` before the first provider call. - On a new session, the turn path loaded transcript state, fetched connected integrations, rebuilt delegation tools, fetched learned context, and only then froze the system prompt. - The integration fetch itself reloaded `Config` inside the hot path, and the session builder always synthesized delegation tools against an empty integration set, guaranteeing a repair pass on turn 1. - That inflated first-token latency for orchestrator-style sessions even when the Composio cache already had a valid integration snapshot. ## Solution - Reuse `composio::cached_active_integrations(config)` during session construction to prewarm `connected_integrations` when the shared cache is already warm. - Build delegation tools against that cached integration slice instead of hardcoding `&[]`, then persist the synthesized-tool name set onto the built `Agent`. - Track whether a session's integration view is authoritative with `connected_integrations_initialized`; turn 1 now only fetches integrations and refreshes delegation tools when the builder could not prewarm the cache. - Store the full runtime `Config` snapshot on the session agent so mid-session cache reads and fallback integration fetches do not call `Config::load_or_init()` on the hot path. - Keep the existing fallback behavior for cold-cache sessions and shared-`Arc` reconciliation failures so correctness stays unchanged when prewarming is unavailable. ## Submission Checklist > If a section does not apply to this change, mark the item as `N/A` with a one-line reason. Do not delete items. - [x] Tests added or updated (happy path + at least one failure / edge case) per [Testing Strategy](../gitbooks/developing/testing-strategy.md#failure-path-requirement) - [x] N/A: diff coverage is enforced by CI; local coverage commands were blocked in this environment (`pnpm` unavailable on PATH, focused Rust tests blocked by missing `cmake`). - [x] Coverage matrix updated — `N/A: behaviour-only change` - [x] All affected feature IDs from the matrix are listed in the PR description under `## Related` - [x] No new external network dependencies introduced (mock backend used per [Testing Strategy](../gitbooks/developing/testing-strategy.md#mock-policy)) - [x] Manual smoke checklist updated if this touches release-cut surfaces ([`docs/RELEASE-MANUAL-SMOKE.md`](../docs/RELEASE-MANUAL-SMOKE.md)) - [x] Linked issue closed via `Closes #NNN` in the `## Related` section ## Impact - Runtime/platform impact: desktop/in-process core agent sessions. - Performance: reduces first-turn latency when the Composio cache is already warm by avoiding a redundant integration fetch, avoiding a redundant delegation-tool rebuild, and avoiding `Config::load_or_init()` on subsequent cache probes. - Compatibility: cold-cache sessions preserve the old fallback behavior and still fetch integrations on turn 1 when no prewarmed snapshot exists. - Security: no change in privilege or network surface; this only changes when cached integration metadata is reused. ## Related - Closes: - Follow-up PR(s)/TODOs: --- ## AI Authored PR Metadata (required for Codex/Linear PRs) > Keep this section for AI-authored PRs. For human-only PRs, mark each field `N/A`. ### Linear Issue - Key: N/A - URL: N/A ### Commit & Branch - Branch: feat/agent-spawn-depth-gate - Commit SHA: 44ca700909 ### Validation Run - [x] N/A: local environment does not have `pnpm` on PATH, so this command could not be run here. - [x] N/A: local environment does not have `pnpm` on PATH, so this command could not be run here. - [x] N/A: focused Rust tests were attempted, but the build is blocked locally because `whisper-rs-sys` requires `cmake`, which is not installed in this environment. - [x] Rust fmt/check (if changed): `cargo fmt --manifest-path Cargo.toml` passed; `git diff --check origin/main...HEAD` clean. - [x] N/A: Tauri shell files were not changed in this PR; a local `cargo check --manifest-path app/src-tauri/Cargo.toml` attempt was also blocked because the vendored `tauri-cef` dependency tree is missing in this environment. ### Validation Blocked - `command:` `GGML_NATIVE=OFF cargo test --manifest-path Cargo.toml set_connected_integrations_marks_session_initialized_and_updates_hash -- --nocapture` and `GGML_NATIVE=OFF cargo test --manifest-path Cargo.toml turn_without_tools_returns_text -- --nocapture` - `error:` `whisper-rs-sys` build script failed because `cmake` is not installed in the local environment - `impact:` focused Rust tests did not complete locally; correctness is based on source review plus the added regression coverage ### Behavior Changes - Intended behavior change: sessions built from a warm Composio cache now start with prewarmed integrations and delegation tools instead of repairing that state inside the first turn - User-visible effect: lower first-token latency for fresh orchestrator-style sessions when integration metadata is already cached ### Parity Contract - Legacy behavior preserved: when the Composio cache is cold or unavailable, turn 1 still fetches integrations and rebuilds the delegation surface before freezing the prompt - Guard/fallback/dispatch parity checks: shared-`Arc` reconciliation fallback, mid-session cache-driven refresh, and config-load fallback behavior remain intact ### Duplicate / Superseded PR Handling - Duplicate PR(s): none - Canonical PR: this PR - Resolution (closed/superseded/updated): N/A <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Enforced sub-agent spawn-depth limit (max 3) with surfaced error on overflow. * Sessions now preload and track connected integrations and their runtime config. * Connected integrations now include a gated-tools catalogue describing hidden toolkit actions. * **Tests** * Added tests for spawn-depth enforcement and reset behavior. * Added tests validating integration-initialization state and hash updates. * **Documentation** * Marked spawn-depth runtime limiter as implemented in architecture docs. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/tinyhumansai/openhuman/pull/2454?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: SRIKANTH A <yatheendrudusrikanth@gmail.com> Co-authored-by: M3gA-Mind <megamind@mahadao.com>	2026-05-22 19:01:37 +05:30
3 people	73ea22e011	feat(agent): cap runtime subagent spawn depth at MAX_SPAWN_DEPTH=3 (#2234) ... Co-authored-by: Cursor <cursoragent@cursor.com>	2026-05-19 14:30:32 -07:00